Merge pull request #160 from edx/cdodge/enumerate-review-status

better enumerate the SoftwareSecure review status strings

edx_proctoring/backends/software_secure.py

@@ -54,6 +54,8 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider):
         self.crypto_key = crypto_key
         self.timeout = 10
         self.software_download_url = software_download_url
+        self.passing_review_status = ['Clean', 'Rules Violation']
+        self.failing_review_status = ['Not Reviewed', 'Suspicious']
 
     def register_exam_attempt(self, exam, context):
         """
@@ -137,9 +139,7 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider):
         # get the SoftwareSecure status on this attempt
         review_status = payload['reviewStatus']
 
-        bad_status = review_status not in [
-            'Not Reviewed', 'Suspicious', 'Rules Violation', 'Clean'
-        ]
+        bad_status = review_status not in self.passing_review_status + self.failing_review_status
 
         if bad_status:
             err_msg = (
@@ -232,7 +232,7 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider):
             # only 'Clean' and 'Rules Violation' could as passing
             status = (
                 ProctoredExamStudentAttemptStatus.verified
-                if review_status in ['Clean', 'Rules Violation']
+                if review_status in self.passing_review_status
                 else ProctoredExamStudentAttemptStatus.rejected
             )