Commit 3596324d by Chris Dodge

better enumerate the SoftwareSecure review status strings

parent b353ec2b
...@@ -54,6 +54,8 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider): ...@@ -54,6 +54,8 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider):
self.crypto_key = crypto_key self.crypto_key = crypto_key
self.timeout = 10 self.timeout = 10
self.software_download_url = software_download_url self.software_download_url = software_download_url
self.passing_review_status = ['Clean', 'Rules Violation']
self.failing_review_status = ['Not Reviewed', 'Suspicious']
def register_exam_attempt(self, exam, context): def register_exam_attempt(self, exam, context):
""" """
...@@ -137,9 +139,7 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider): ...@@ -137,9 +139,7 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider):
# get the SoftwareSecure status on this attempt # get the SoftwareSecure status on this attempt
review_status = payload['reviewStatus'] review_status = payload['reviewStatus']
bad_status = review_status not in [ bad_status = review_status not in self.passing_review_status + self.failing_review_status
'Not Reviewed', 'Suspicious', 'Rules Violation', 'Clean'
]
if bad_status: if bad_status:
err_msg = ( err_msg = (
...@@ -232,7 +232,7 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider): ...@@ -232,7 +232,7 @@ class SoftwareSecureBackendProvider(ProctoringBackendProvider):
# only 'Clean' and 'Rules Violation' could as passing # only 'Clean' and 'Rules Violation' could as passing
status = ( status = (
ProctoredExamStudentAttemptStatus.verified ProctoredExamStudentAttemptStatus.verified
if review_status in ['Clean', 'Rules Violation'] if review_status in self.passing_review_status
else ProctoredExamStudentAttemptStatus.rejected else ProctoredExamStudentAttemptStatus.rejected
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment