Skip to content

E
edx-platform
Switch branch/tag
  1. 10 Nov, 2015 1 commit
  3. 25 Aug, 2015 1 commit
  5. 19 Jun, 2015 1 commit
  7. 17 Mar, 2015 1 commit
  9. 04 Feb, 2015 1 commit
    • Better support specifying of modulestore configuration in test cases · b353ed2e 
      The existing pattern of using `override_settings(MODULESTORE=...)` prevented
us from having more than one layer of subclassing in modulestore tests.

In a structure like:

    @override_settings(MODULESTORE=store_a)
    class BaseTestCase(ModuleStoreTestCase):
        def setUp(self):
            # use store

    @override_settings(MODULESTORE=store_b)
    class ChildTestCase(BaseTestCase):
        def setUp(self):
            # use store

In this case, the store actions performed in `BaseTestCase` on behalf of
`ChildTestCase` would still use `store_a`, even though the `ChildTestCase`
had specified to use `store_b`. This is because the `override_settings`
decorator would be the innermost wrapper around the `BaseTestCase.setUp` method,
no matter what `ChildTestCase` does.

To remedy this, we move the call to `override_settings` into the
`ModuleStoreTestCase.setUp` method, and use a cleanup to remove the override.
Subclasses can just defined the `MODULESTORE` class attribute to specify which
modulestore to use _for the entire `setUp` chain_.

[PLAT-419]
      Calen Pennington committed
  11. 14 Jan, 2015 1 commit
  13. 02 Dec, 2014 1 commit
  15. 01 Dec, 2014 1 commit
  17. 14 Oct, 2014 1 commit
  19. 02 Oct, 2014 2 commits
  21. 03 Sep, 2014 1 commit
  23. 15 Aug, 2014 1 commit
  25. 06 Aug, 2014 1 commit
  27. 16 Jul, 2014 1 commit
  29. 10 Jul, 2014 2 commits
  31. 26 Jun, 2014 1 commit
  33. 29 May, 2014 1 commit
  35. 19 May, 2014 1 commit
  37. 07 May, 2014 1 commit
    • Make course ids and usage ids opaque to LMS and Studio [partial commit] · e2bfcf2a 
      This commit updates common/djangoapps.

These keys are now objects with a limited interface, and the particular
internal representation is managed by the data storage layer (the
modulestore).

For the LMS, there should be no outward-facing changes to the system.
The keys are, for now, a change to internal representation only. For
Studio, the new serialized form of the keys is used in urls, to allow
for further migration in the future.

Co-Author: Andy Armstrong <andya@edx.org>
Co-Author: Christina Roberts <christina@edx.org>
Co-Author: David Baumgold <db@edx.org>
Co-Author: Diana Huang <dkh@edx.org>
Co-Author: Don Mitchell <dmitchell@edx.org>
Co-Author: Julia Hansbrough <julia@edx.org>
Co-Author: Nimisha Asthagiri <nasthagiri@edx.org>
Co-Author: Sarina Canelake <sarina@edx.org>

[LMS-2370]
      Calen Pennington committed
  39. 25 Feb, 2014 1 commit
  41. 05 Feb, 2014 2 commits
  43. 30 Jan, 2014 1 commit
  45. 03 Dec, 2013 1 commit
  47. 20 Sep, 2013 1 commit
  49. 09 Sep, 2013 1 commit
  51. 06 Sep, 2013 2 commits
    • Address @brianhw review comments · 6a850e27 
      * Fix open redirect vulnerability
* Add Logging To AUDIT_LOG : Note I had to change existing tests
  that mocked AUDIT_LOG with this
* Use external_auth.views.SHIBBOLETH_DOMAIN_PREFIX in student.views
* Add a bunch of documentation
* PEP8 / Pylint
      Jason Bau committed
    • Revamped + Enhanced Shibboleth support · 948c07c4 
      * If a shib users type in their email on the regular login page,
  redirects them to /shib-login/
* Modify student.views.accounts_login to handle redirects
  generated by @login_required for courses that use shib for
  access control.
  Redirect those logins to /shib-login/?next=
      Jason Bau committed
  53. 22 Aug, 2013 1 commit
  55. 21 Aug, 2013 2 commits
    • Pep8/pylint fixes · 8165a033 
      Fixed test_masquerade failure due to not clearing the modulestore
between tests.
      Will Daly committed
    • Removed unnecessary settings wrangling from ModuleStoreTestCase. · 48c6daac 
      Modified navigation tests to use MixedModulestore
Updated factories to find editable modulestore

Updated test_submitting_problems

Updated test_tabs.py

Updated test_view_authentication

Updated test_views

Updated courseware/tests/tests.py

Updated test_masquerade

Updated test_module_render

Pylint fixes

Updated video and word cloud tests

Updated course wiki tests

Updated license and open_ended tests.
One open_ended test still failing due to Mako initialization issues

Updated staticbook

Updated django_comment_client tests

Updated instructor tests

Updated instructor task tests

Updated external_auth tests

Updated course_groups
      Will Daly committed
  57. 14 Aug, 2013 1 commit
    • Shift enroll/unenroll logic to CourseEnrollment model, add is_active and mode. · 3ce87583 
      Features coming down the pipe will want to be able to:
* Refer to enrollments before they are actually activated (approval step).
* See what courses a user used to be enrolled in for when they re-enroll in
  the same course, or a different run of that course.
* Have different "modes" of enrolling in a course, representing things like
  honor certificate enrollment, auditing (no certs), etc.

This change adds an is_active flag and mode (with default being "honor").
The commit is only as large as it is because many parts of the codebase were
manipulating enrollments by adding and removing CourseEnrollment objects
directly. It was necessary to create classmethods on CourseEnrollment to
encapsulate this functionality and then port everything over to using them.

The migration to add columns has been tested on a prod replica, and seems to be
fine for running on a live system with single digit millions of rows of
enrollments.
      David Ormsbee committed
  59. 31 Jul, 2013 1 commit
  61. 25 Jun, 2013 1 commit
  63. 21 Jun, 2013 1 commit
  65. 19 Jun, 2013 2 commits
    • Finishing up tests/modifications per @ormsbee feedback · 084160c1
      Jason Bau committed
    • The bulk of Shibboleth authentication for Stanford · 824fb9a3 
      Highlights:
* The url '/shib-login/' interfaces with apache/mod_shib via
  request.META to handle shibboleth login and registrations
* Courses can designate 'enrollment_domains' to limit enrollment
  to users with a linked ExternalAuthMap verified by a particular
  identity provider
* Tests
* Logging

 Changes to be committed:

	new file:   common/djangoapps/external_auth/migrations/0001_initial.py
	new file:   common/djangoapps/external_auth/migrations/__init__.py
	new file:   common/djangoapps/external_auth/tests/test_shib.py
	modified:   common/djangoapps/external_auth/views.py
	modified:   common/djangoapps/student/views.py
	modified:   common/lib/xmodule/xmodule/course_module.py
	modified:   lms/djangoapps/courseware/access.py
	modified:   lms/djangoapps/courseware/tests/test_access.py
	modified:   lms/envs/common.py
	modified:   lms/envs/dev.py
	modified:   lms/envs/test.py
	modified:   lms/templates/courseware/course_about.html
	modified:   lms/templates/dashboard.html
	modified:   lms/templates/extauth_failure.html
	modified:   lms/templates/navigation.html
	modified:   lms/templates/register.html
	modified:   lms/templates/signup_modal.html
	modified:   lms/urls.py
	renamed:    lms/wsgi_apache.py -> lms/wsgi_apache_lms.py
      Jason Bau committed