- 22 Jun, 2015 1 commit
-
-
Kyle McCormick committed
-
- 12 Jun, 2015 3 commits
-
-
only require ccx-keys once get_current_ccx will now expect a CourseKey instance as its argument, and will raise a value error if this expectation is not met. document reason for local import add special methods to pass attribute setting and deletion through to the wrapped modulestore add __setattr__ and __delattr__ per code review, update __init__ to work with new methods style change per code review clean up context manager usage as recommended by code review remove unused code and imports convert modulestore type tests to use the `get_modulestore_type` api, remove unused imports code quality: add docstrings increase coverage for utils tests fix bug found in testing. increase test coverage on modulestore wrapper code quality fixes code-quality: ignore import error, but mark site for future consideration
cewing committed -
remove references to middleware that were missed previously use key apis rather than local implementation of key conversion. remove local implementationa remove spurious test for attribute fix test setUp to avoid unneeded flattening code quality fixes add security check ensuring that the coach is coach for *this* CCX. prevent ccx/deprecated course id problems 1. do not allow ccx objects to be created if the course id is deprecated 2. filter out any ccx memberships that involve deprecated course ids (in case there are bad ccxs in the database) Fix test failures and errors arising from incorrect code path execution Create context manager to handle unwrapping and restoring ccx values for the modulestore wrapper, employ it throughout modulestore wrapper implementation
cewing committed -
Implement the use of CCX opaque keys throughout the ccx code base include the new custom ccx id package in the github checkouts list update the coach dashboard wrapper to get CCX information from the incoming course_id, if possible update function signatures for all view functions to expect CCX as passed by the dashboard wrapper (default to None), remove calls to get_ccx_for_coach as the ccx is passed in. update reverse calls in python view code to use a CCXLocator for the URL instead of a CourseLocator use CCXLocator where necessary use course id to find ccx, instead of thread local remove unused method and related tests use course id for getting ccx provide course id to the get_current_ccx method ensure the course id passed in is a CourseKey instance of some type whether it starts out as a string or not use the provided block to figure out what the course_id should be, then get the ccx for that redirect to ccx dashboard using coach ccx if no ccx is passed in update student dashboard listing for ccx to build an appropriate url from a CCXLocator, not from the course locator. refactor building the ccx locator so we don't have to do it repeatedly begin test refactoring after ccx_keys introduction Ensure that when access checking happens, the course_locator form of a ccx locator is used. This ensures that the access check happens against the course and it is not necesarry to duplicate the entire access control structure for the course. pick up api change in ccx-keys create and conditionally use a wrapper for the mixed modulestore returned by xmodule.modulestore.django.modulestore the wrapper will strip and restore ccx values from CourseKey and UsageKey objects fix return values on a few methods remove unused symbol pull updated ccx-keys package set course_id on the caching descriptor system to avoid api incompatibilities in some subsystems use ccx.course instead of self.course fix get method to find course keys from blocks that are not themselves keys but have a location attribute (which will be a key) if an item coming out of the db has children, restore the ccx to them as well if the block passed in has a CCX key, unwrap that before we try to look up the override, otherwise it will never be found. pick up a change in the ccx keys package that allows for stripping CCX identity from a usage key begin writing tests to cover this modulestore wrapper remove the switch_pocs view, the url pattern for it, and the tests that covered it remove the ccx context and the middleware responsible for setting the current CCX. These are no longer needed all dashboard views should raise 404 if a ccx is not provided by the coach_dashboard decorator code quality prevent errors resulting from trying to `get` a ccx based on non-unique criteria. remove obsolete usage of ACTIVE_CCX_KEY fix setUp method for grading tests to properly create grades for the ccx rather than for the course. clean up reverse calls code quality adding docstrings to clarify purpose of this patch fix bug in getting ccx for coach fix grading views to properly fetch a ccx-ified course so that grades for that version will be calculated fix small errors in modulestore implementation fix errant merge marker update call to get_current_ccx after key refactoring merged with tab changes
cewing committed
-
- 05 Jun, 2015 1 commit
-
-
Nimisha Asthagiri committed
-
- 27 May, 2015 1 commit
-
-
Nimisha Asthagiri committed
-
- 15 May, 2015 1 commit
-
-
Previously, the mobile api did not check for pre-requisite courses or entrance exams. This change checks for these milestones and then returns course content accordingly.
christopher lee committed
-
- 06 May, 2015 1 commit
-
-
TNL-1261
muzaffaryousaf committed
-
- 31 Mar, 2015 1 commit
-
-
- added entrance exam check on course info - staff can by pass gating and added tests - refined gating logic - changes after rebasing with Asad's branch - check ENTRANCE_EXAMS feature is enabled - updated test to reflect new logic - catering anonymous user in entrance exam permission - fixed broken tests - change after feedback on 16/3 - fix for a broken test - created new entrance_exams module - fixed quality error and improved test coverage - put get_required_content back in milestones helper - Refactored entrance exams logic - Refactored tabs logic - Fixed broken unit test - changes after feedback from dan-f on 3/27 - removed unnecessary user.is_anonymous check - Addressed PR feedback - Addressed commit-specific feedback - Rework guard clauses - Add coverage for course info case
Zia Fazal committed
-
- 26 Mar, 2015 1 commit
-
-
Conflicts: common/lib/xmodule/xmodule/xml_module.py
John Eskew committed
-
- 20 Feb, 2015 1 commit
-
-
stv committed
-
- 15 Jan, 2015 6 commits
-
-
Nimisha Asthagiri committed
-
Zia Fazal committed
-
cahrens committed
-
Andy Armstrong committed
-
TNL-651
Andy Armstrong committed -
jsa committed
-
- 08 Jan, 2015 1 commit
-
-
Nimisha Asthagiri committed
-
- 25 Nov, 2014 1 commit
-
-
does not distinguish itself from next logical line
stv committed
-
- 09 Nov, 2014 1 commit
-
-
Add new course_module field which describes what the catalog visibility should be (both, about, none)
Chris Dodge committed
-
- 24 Sep, 2014 2 commits
-
-
Julia Hansbrough committed
-
Julia Hansbrough committed
-
- 11 Sep, 2014 1 commit
-
-
TNL-208
Usman Khalid committed
-
- 15 Jul, 2014 1 commit
-
-
Added a new advanced setting; invitation_only If invitation_only display "Enrollment in this course is by invitation only" Otherwise, if outside of enrollment period display "Enrollment is Closed" This issue is logged at LMS-2670 Also fixed in this PR is issue LMS-2717; even though the Register button was greyed out, clicking it sent one to the registration page.
David Adams committed
-
- 14 Jul, 2014 1 commit
-
-
STUD-1875
cahrens committed
-
- 11 Jul, 2014 1 commit
-
-
Mat Peterson committed
-
- 02 Jun, 2014 1 commit
-
-
LMS-2737
Waheed Ahmed committed
-
- 30 May, 2014 1 commit
-
-
Julia Hansbrough committed
-
- 29 May, 2014 1 commit
-
-
[LMS-2757]
Calen Pennington committed
-
- 09 May, 2014 1 commit
-
-
Don Mitchell committed
-
- 06 May, 2014 1 commit
-
-
This commit updates lms/djangoapps/courseware. These keys are now objects with a limited interface, and the particular internal representation is managed by the data storage layer (the modulestore). For the LMS, there should be no outward-facing changes to the system. The keys are, for now, a change to internal representation only. For Studio, the new serialized form of the keys is used in urls, to allow for further migration in the future. Co-Author: Andy Armstrong <andya@edx.org> Co-Author: Christina Roberts <christina@edx.org> Co-Author: David Baumgold <db@edx.org> Co-Author: Diana Huang <dkh@edx.org> Co-Author: Don Mitchell <dmitchell@edx.org> Co-Author: Julia Hansbrough <julia@edx.org> Co-Author: Nimisha Asthagiri <nasthagiri@edx.org> Co-Author: Sarina Canelake <sarina@edx.org> [LMS-2370]
Calen Pennington committed
-
- 10 Feb, 2014 1 commit
-
-
Ned Batchelder committed
-
- 30 Jan, 2014 2 commits
-
-
fixing unit tests fixing merge error fixing xqueue submission issue with unicode url (trial 0.1) fixing fotmats as commented upon removing yaml file language selection Unicode changes to support QRF removed unnecessary pass in modulestore/init.py fixing merge error fixing fotmats as commented upon removing yaml file language selection fixing pep8 violations - fixing pylint violations pylint violation fixing line spaces and formats ignore pylint E1101 remove empty line fixing pylint violations pep8 violations bulk mail unicode/decode fix migration error fix pep8 just to push again more unicode/decode Final changes to comments and error messages.
Jay Zoldak committed -
Oleg Marshev committed
-
- 17 Jan, 2014 1 commit
-
-
Don Mitchell committed
-
- 14 Jan, 2014 1 commit
-
-
Don Mitchell committed
-
- 10 Jan, 2014 1 commit
-
-
[LMS-226] [LMS-2013]
Calen Pennington committed
-
- 15 Dec, 2013 1 commit
-
-
Replaced existing test_none_user_index_access_with_startdate_fails test with new test now that the tested function has changed and was causing the original test to fail.
Carson Gee committed
-
- 03 Dec, 2013 1 commit
-
-
David Baumgold committed
-
- 22 Nov, 2013 1 commit
-
-
Calen Pennington committed
-