Fix Jasmine tests

Also, rewrite them to be easier to comprehend, and to not use magic constants (or to use fewer, at least).

cms/static/js/spec_helpers/modal_helpers.js

 /**
  * Provides helper methods for invoking Studio modal windows in Jasmine tests.
  */
-define(["jquery"],
-    function($) {
+define(["jquery", "js/spec_helpers/view_helpers"],
+    function($, view_helpers) {
         var basicModalTemplate = readFixtures('basic-modal.underscore'),
             modalButtonTemplate = readFixtures('modal-button.underscore'),
             feedbackTemplate = readFixtures('system-feedback.underscore'),
@@ -14,11 +14,7 @@ define(["jquery"],
             cancelModalIfShowing;
 
         installModalTemplates = function(append) {
-            if (append) {
-                appendSetFixtures($("<script>", { id: "system-feedback-tpl", type: "text/template" }).text(feedbackTemplate));
-            } else {
-                setFixtures($("<script>", { id: "system-feedback-tpl", type: "text/template" }).text(feedbackTemplate));
-            }
+            view_helpers.installViewTemplates(append);
             appendSetFixtures($("<script>", { id: "basic-modal-tpl", type: "text/template" }).text(basicModalTemplate));
             appendSetFixtures($("<script>", { id: "modal-button-tpl", type: "text/template" }).text(modalButtonTemplate));
         };
@@ -58,11 +54,11 @@ define(["jquery"],
             }
         };
 
-        return {
+        return $.extend(view_helpers, {
             'installModalTemplates': installModalTemplates,
             'isShowingModal': isShowingModal,
             'hideModalIfShowing': hideModalIfShowing,
             'cancelModal': cancelModal,
             'cancelModalIfShowing': cancelModalIfShowing
-        };
+        });
     });

cms/static/js/spec_helpers/view_helpers.js

+/**
+ * Provides helper methods for invoking Studio modal windows in Jasmine tests.
+ */
+define(["jquery"],
+    function($) {
+        var feedbackTemplate = readFixtures('system-feedback.underscore'),
+            installViewTemplates;
+
+        installViewTemplates = function(append) {
+            if (append) {
+                appendSetFixtures($("<script>", { id: "system-feedback-tpl", type: "text/template" }).text(feedbackTemplate));
+            } else {
+                setFixtures($("<script>", { id: "system-feedback-tpl", type: "text/template" }).text(feedbackTemplate));
+            }
+        };
+
+        return {
+            'installViewTemplates': installViewTemplates
+        };
+    });

cms/static/js/views/container.js

@@ -18,8 +18,6 @@ define(["jquery", "underscore", "js/views/xblock", "js/utils/module", "gettext",
                     stop: function (event, ui) {
                         var saving, hideSaving, removeFromParent;
 
-                        console.log('stop');
-
                         if (oldParent === undefined) {
                             // If no actual change occurred,
                             // oldParent will never have been set.
@@ -81,8 +79,6 @@ define(["jquery", "underscore", "js/views/xblock", "js/utils/module", "gettext",
             reorder: function (targetParent, successCallback) {
                 var children, childLocators;
 
-                console.log('calling reorder for ' + targetParent.data('locator'));
-
                 // Find descendants with class "wrapper-xblock" whose parent == targetParent.
                 // This is necessary to filter our grandchildren, great-grandchildren, etc.
                 children = targetParent.find('.wrapper-xblock').filter(function () {
@@ -106,7 +102,6 @@ define(["jquery", "underscore", "js/views/xblock", "js/utils/module", "gettext",
                     }),
                     success: function () {
                         // change data-parent on the element moved.
-                        console.log('SAVED! ' + targetParent.data('locator') + " with " + childLocators.length + "  children");
                         if (successCallback) {
                             successCallback();
                         }