Commit 8de47f24 by Andy Armstrong

Address feedback

parent 3bb63166
...@@ -9,13 +9,13 @@ from paver.easy import BuildFailure ...@@ -9,13 +9,13 @@ from paver.easy import BuildFailure
import pavelib.quality import pavelib.quality
class TestPaverStylelint(unittest.TestCase): class TestPaverESLint(unittest.TestCase):
""" """
For testing run_stylelint For testing run_eslint
""" """
def setUp(self): def setUp(self):
super(TestPaverStylelint, self).setUp() super(TestPaverESLint, self).setUp()
# Mock the paver @needs decorator # Mock the paver @needs decorator
self._mock_paver_needs = patch.object(pavelib.quality.run_eslint, 'needs').start() self._mock_paver_needs = patch.object(pavelib.quality.run_eslint, 'needs').start()
......
...@@ -335,11 +335,11 @@ def _get_stylelint_violations(): ...@@ -335,11 +335,11 @@ def _get_stylelint_violations():
) )
try: try:
return int(_get_count_from_last_line(stylelint_report, "eslint")) return int(_get_count_from_last_line(stylelint_report, "stylelint"))
except TypeError: except TypeError:
raise BuildFailure( raise BuildFailure(
"Error. Number of eslint violations could not be found in {eslint_report}".format( "Error. Number of stylelint violations could not be found in {stylelint_report}".format(
eslint_report=stylelint_report stylelint_report=stylelint_report
) )
) )
...@@ -369,10 +369,6 @@ def run_stylelint(options): ...@@ -369,10 +369,6 @@ def run_stylelint(options):
violations_limit=violations_limit, violations_limit=violations_limit,
) )
) )
if num_violations > 0:
print("Stylelint succeeded with no more violations than {violations_limit}".format(
violations_limit=violations_limit,
))
@task @task
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment