Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
8de47f24
Commit
8de47f24
authored
Sep 12, 2017
by
Andy Armstrong
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Address feedback
parent
3bb63166
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
10 deletions
+6
-10
pavelib/paver_tests/test_eslint.py
+3
-3
pavelib/quality.py
+3
-7
No files found.
pavelib/paver_tests/test_eslint.py
View file @
8de47f24
...
...
@@ -9,13 +9,13 @@ from paver.easy import BuildFailure
import
pavelib.quality
class
TestPaver
Stylel
int
(
unittest
.
TestCase
):
class
TestPaver
ESL
int
(
unittest
.
TestCase
):
"""
For testing run_
style
lint
For testing run_
es
lint
"""
def
setUp
(
self
):
super
(
TestPaver
Stylel
int
,
self
)
.
setUp
()
super
(
TestPaver
ESL
int
,
self
)
.
setUp
()
# Mock the paver @needs decorator
self
.
_mock_paver_needs
=
patch
.
object
(
pavelib
.
quality
.
run_eslint
,
'needs'
)
.
start
()
...
...
pavelib/quality.py
View file @
8de47f24
...
...
@@ -335,11 +335,11 @@ def _get_stylelint_violations():
)
try
:
return
int
(
_get_count_from_last_line
(
stylelint_report
,
"
es
lint"
))
return
int
(
_get_count_from_last_line
(
stylelint_report
,
"
style
lint"
))
except
TypeError
:
raise
BuildFailure
(
"Error. Number of
eslint violations could not be found in {es
lint_report}"
.
format
(
es
lint_report
=
stylelint_report
"Error. Number of
stylelint violations could not be found in {style
lint_report}"
.
format
(
style
lint_report
=
stylelint_report
)
)
...
...
@@ -369,10 +369,6 @@ def run_stylelint(options):
violations_limit
=
violations_limit
,
)
)
if
num_violations
>
0
:
print
(
"Stylelint succeeded with no more violations than {violations_limit}"
.
format
(
violations_limit
=
violations_limit
,
))
@task
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment