Commit 7080c7e4 by Eric Fischer

Review feedback #2: Electric Boogaloo

parent a03a4945
...@@ -361,7 +361,7 @@ class GradeMixin(object): ...@@ -361,7 +361,7 @@ class GradeMixin(object):
) )
self_assessment_part = _get_assessment_part( self_assessment_part = _get_assessment_part(
_('Self Assessment Grade') if is_staff else _('Your Self Assessment'), _('Self Assessment Grade') if is_staff else _('Your Self Assessment'),
_('Your Comments'), _('Your Comments'), # This is only used in the LMS student-facing view
criterion_name, criterion_name,
self_assessment self_assessment
) )
......
...@@ -451,6 +451,11 @@ class GradePage(OpenAssessmentPage): ...@@ -451,6 +451,11 @@ class GradePage(OpenAssessmentPage):
Returns: the tuple of source and value information for the requested grade Returns: the tuple of source and value information for the requested grade
""" """
self.wait_for_element_visibility(
self._bounded_selector('.question--{} .answer .answer__source__value'.format(question + 1)),
"Grade entry was present",
2
)
source = self.q( source = self.q(
css=self._bounded_selector('.question--{} .answer .answer__source__value'.format(question + 1)) css=self._bounded_selector('.question--{} .answer .answer__source__value'.format(question + 1))
)[column] )[column]
......
...@@ -242,7 +242,7 @@ class OpenAssessmentTest(WebAppTest): ...@@ -242,7 +242,7 @@ class OpenAssessmentTest(WebAppTest):
Args: Args:
number_to_assess: the number of submissions to assess. If not provided (or 0), number_to_assess: the number of submissions to assess. If not provided (or 0),
will grade all available submissions. will grade all available submissions.
selected_options (dict): the options to choose when grading. Defaults to OPTIONS_SELECTED. options_selected (dict): the options to choose when grading. Defaults to OPTIONS_SELECTED.
feedback (function(feedback_type)): if feedback is set, it will be used as a function that takes one feedback (function(feedback_type)): if feedback is set, it will be used as a function that takes one
parameter to generate a feedback string. parameter to generate a feedback string.
""" """
...@@ -1147,7 +1147,7 @@ class FeedbackOnlyTest(OpenAssessmentTest, FullWorkflowMixin): ...@@ -1147,7 +1147,7 @@ class FeedbackOnlyTest(OpenAssessmentTest, FullWorkflowMixin):
# Staff assess all available submissions # Staff assess all available submissions
self.do_staff_assessment( self.do_staff_assessment(
options_selected = [0], options_selected = [0], # Select the 0-th option (Yes) on the single scored criterion
feedback=lambda feedback_type: self.generate_feedback("staff", feedback_type) feedback=lambda feedback_type: self.generate_feedback("staff", feedback_type)
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment