Review feedback #2: Electric Boogaloo

openassessment/xblock/grade_mixin.py

@@ -361,7 +361,7 @@ class GradeMixin(object):
         )
         self_assessment_part = _get_assessment_part(
             _('Self Assessment Grade') if is_staff else _('Your Self Assessment'),
-            _('Your Comments'),
+            _('Your Comments'),  # This is only used in the LMS student-facing view
             criterion_name,
             self_assessment
         )

test/acceptance/pages.py

@@ -451,6 +451,11 @@ class GradePage(OpenAssessmentPage):
         Returns: the tuple of source and value information for the requested grade
 
         """
+        self.wait_for_element_visibility(
+            self._bounded_selector('.question--{} .answer .answer__source__value'.format(question + 1)),
+            "Grade entry was present",
+            2
+        )
         source = self.q(
             css=self._bounded_selector('.question--{} .answer .answer__source__value'.format(question + 1))
         )[column]

test/acceptance/tests.py

@@ -242,7 +242,7 @@ class OpenAssessmentTest(WebAppTest):
         Args:
             number_to_assess: the number of submissions to assess. If not provided (or 0),
                 will grade all available submissions.
-            selected_options (dict): the options to choose when grading. Defaults to OPTIONS_SELECTED.
+            options_selected (dict): the options to choose when grading. Defaults to OPTIONS_SELECTED.
             feedback (function(feedback_type)): if feedback is set, it will be used as a function that takes one
                 parameter to generate a feedback string.
         """
@@ -1147,7 +1147,7 @@ class FeedbackOnlyTest(OpenAssessmentTest, FullWorkflowMixin):
 
         # Staff assess all available submissions
         self.do_staff_assessment(
-            options_selected = [0],
+            options_selected = [0],  # Select the 0-th option (Yes) on the single scored criterion
             feedback=lambda feedback_type: self.generate_feedback("staff", feedback_type)
         )