Commit c3b841ae by Piotr Jakimiak

Use Serializer instead of ModelSerializer

parent 6022b9dd
......@@ -479,8 +479,7 @@ class CharField(WritableField):
if not self.allow_none:
return ''
else:
# return None explicitly because smart_text(None) == 'None'
# see #1834 for details
# Return None explicitly because smart_text(None) == 'None'. See #1834 for details
return None
return smart_text(value)
......
......@@ -54,10 +54,6 @@ class ChoiceFieldModel(models.Model):
choice = models.CharField(choices=SAMPLE_CHOICES, blank=True, max_length=255)
class NullableCharFieldModel(models.Model):
char = models.CharField(null=True, blank=True, max_length=4)
class ChoiceFieldModelSerializer(serializers.ModelSerializer):
class Meta:
model = ChoiceFieldModel
......@@ -1013,13 +1009,12 @@ class ModelCharField(TestCase):
Tests for CharField
"""
def test_none_serializing(self):
class CharFieldSerializer(serializers.ModelSerializer):
class Meta:
model = NullableCharFieldModel
class CharFieldSerializer(serializers.Serializer):
char = serializers.CharField(allow_none=True, required=False)
serializer = CharFieldSerializer(data={'char': None})
self.assertTrue(serializer.fields['char'].allow_none)
self.assertTrue(serializer.is_valid())
self.assertIsNone(serializer.object.char)
self.assertIsNone(serializer.object['char'])
class SerializerMethodFieldTest(TestCase):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment