Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
c3b841ae
Commit
c3b841ae
authored
Sep 05, 2014
by
Piotr Jakimiak
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use Serializer instead of ModelSerializer
parent
6022b9dd
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
10 deletions
+4
-10
rest_framework/fields.py
+1
-2
tests/test_fields.py
+3
-8
No files found.
rest_framework/fields.py
View file @
c3b841ae
...
@@ -479,8 +479,7 @@ class CharField(WritableField):
...
@@ -479,8 +479,7 @@ class CharField(WritableField):
if
not
self
.
allow_none
:
if
not
self
.
allow_none
:
return
''
return
''
else
:
else
:
# return None explicitly because smart_text(None) == 'None'
# Return None explicitly because smart_text(None) == 'None'. See #1834 for details
# see #1834 for details
return
None
return
None
return
smart_text
(
value
)
return
smart_text
(
value
)
...
...
tests/test_fields.py
View file @
c3b841ae
...
@@ -54,10 +54,6 @@ class ChoiceFieldModel(models.Model):
...
@@ -54,10 +54,6 @@ class ChoiceFieldModel(models.Model):
choice
=
models
.
CharField
(
choices
=
SAMPLE_CHOICES
,
blank
=
True
,
max_length
=
255
)
choice
=
models
.
CharField
(
choices
=
SAMPLE_CHOICES
,
blank
=
True
,
max_length
=
255
)
class
NullableCharFieldModel
(
models
.
Model
):
char
=
models
.
CharField
(
null
=
True
,
blank
=
True
,
max_length
=
4
)
class
ChoiceFieldModelSerializer
(
serializers
.
ModelSerializer
):
class
ChoiceFieldModelSerializer
(
serializers
.
ModelSerializer
):
class
Meta
:
class
Meta
:
model
=
ChoiceFieldModel
model
=
ChoiceFieldModel
...
@@ -1013,13 +1009,12 @@ class ModelCharField(TestCase):
...
@@ -1013,13 +1009,12 @@ class ModelCharField(TestCase):
Tests for CharField
Tests for CharField
"""
"""
def
test_none_serializing
(
self
):
def
test_none_serializing
(
self
):
class
CharFieldSerializer
(
serializers
.
ModelSerializer
):
class
CharFieldSerializer
(
serializers
.
Serializer
):
class
Meta
:
char
=
serializers
.
CharField
(
allow_none
=
True
,
required
=
False
)
model
=
NullableCharFieldModel
serializer
=
CharFieldSerializer
(
data
=
{
'char'
:
None
})
serializer
=
CharFieldSerializer
(
data
=
{
'char'
:
None
})
self
.
assertTrue
(
serializer
.
fields
[
'char'
]
.
allow_none
)
self
.
assertTrue
(
serializer
.
fields
[
'char'
]
.
allow_none
)
self
.
assertTrue
(
serializer
.
is_valid
())
self
.
assertTrue
(
serializer
.
is_valid
())
self
.
assertIsNone
(
serializer
.
object
.
char
)
self
.
assertIsNone
(
serializer
.
object
[
'char'
]
)
class
SerializerMethodFieldTest
(
TestCase
):
class
SerializerMethodFieldTest
(
TestCase
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment