Merge pull request #2895 from edx/max/mount-ebs

mount ebs role

playbooks/roles/mount_ebs/defaults/main.yml

+# Expects a list of dicts with these keys
+#  - device: /dev/xvdk
+#    mount: /edx/var/mongo
+#    options: "defaults,noatime"
+#    fstype: ext4
+# While mount, options and fstype are pretty standard in our app, the device names
+# will be highly dependent on how you stand up your instances.
+#
+# Additionally - order is important if you have child directories.  If you want to mount
+# /edx/var/mongo and /edx/var/mongo/mongodb/journal, you must specify them in that order,
+# otherwise this role will mount /edx/var/mongo over the top of /edx/var/mongo/mongodb/journal
+# which is not what you wanted.
+volumes: []
+
+UNMOUNT_DISKS: false

playbooks/roles/mount_ebs/tasks/main.yml

+#
+# edX Configuration
+#
+# github:     https://github.com/edx/configuration
+# wiki:       https://github.com/edx/configuration/wiki
+# code style: https://github.com/edx/configuration/wiki/Ansible-Coding-Conventions
+# license:    https://github.com/edx/configuration/blob/master/LICENSE.TXT
+#
+#
+#
+# Tasks for role mount_dbs
+#
+# Overview:
+#
+# This role ensures that the correct EBS volumes are mounted to the right locations.
+# If the volumes are already mounted to the correct place, this role does nothing.
+
+# This task will be skipped if UNMOUNT_DISKS is false, causing the next task
+# to error if the disk has the wrong fstype but is already mounted
+- name: Unmount disk if fstype is wrong
+  mount:
+    name: "{{ (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'mount': None})).mount }}"
+    src: "{{ (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'device': None})).device }}"
+    fstype: "{{ (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'fstype': None})).fstype }}"
+    state: unmounted
+  when: "{{ UNMOUNT_DISKS and (ansible_mounts | selectattr('device', 'equalto', item.device) | first | default({'fstype': None})).fstype != item.fstype }}"
+  with_items: volumes
+
+# Noop & reports "ok" if fstype is correct
+# Errors if fstype is wrong and disk is mounted (hence above task)
+- name: Create filesystem
+  filesystem:
+    dev: "{{ item.device }}"
+    fstype: "{{ item.fstype }}"
+    # Necessary because AWS gives some ephemeral disks the wrong fstype by default
+    force: true
+  with_items: volumes
+
+# This can fail if one volume is mounted on a child directory as another volume
+# and it attempts to unmount the parent first.  This is generally fixable by rerunning.
+# Order is super dependent here, but we're iterating ansible_mounts (in order to identify
+# all current mounts in the system) not volumes, which would be reversible.
+# Possibly fixable by saving this list of unmounts off and comparing it to volumes, but this
+# task rarely runs, since on server setup, the disks are unmounted, and in we won't
+# be unmounting disks unless you set UNMOUNT_DISKS to true.
+- name: Unmount disks mounted to the wrong place
+  mount:
+    name: "{{ item.mount }}"
+    src: "{{ item.device }}"
+    fstype: "{{ item.fstype }}"
+    state: unmounted
+  when: >
+    UNMOUNT_DISKS and
+    volumes | selectattr('device', 'equalto', item.device) | list | length != 0 and
+    (volumes | selectattr('device', 'equalto', item.device) | first).mount != item.mount
+  with_items: ansible_mounts
+
+# If there are disks we want to be unmounting, but we can't because UNMOUNT_DISKS is false
+# that is an errorable condition, since it can easily allow us to double mount a disk.
+- name: Check that we don't want to unmount disks when UNMOUNT_DISKS is false
+  fail: msg="Found disks mounted in the wrong place, but can't unmount them.  This role will need to be re-run with -e 'UNMOUNT_DISKS=True' if you believe that is safe."
+  when: >
+    not UNMOUNT_DISKS and
+    volumes | selectattr('device', 'equalto', item.device) | list | length != 0 and
+    (volumes | selectattr('device', 'equalto', item.device) | first).mount != item.mount
+  with_items: ansible_mounts
+
+- name: Mount disks
+  mount:
+    name: "{{ item.mount }}"
+    src: "{{ item.device }}"
+    state: mounted
+    fstype: "{{ item.fstype }}"
+    opts: "{{ item.options }}"
+  with_items: volumes

requirements.txt

 git+https://github.com/edx/ansible.git@stable-1.9.3-rc1-edx#egg=ansible==1.9.3-edx
 PyYAML==3.11
-Jinja2==2.7.3
+Jinja2==2.8
 MarkupSafe==0.23
 boto==2.32.1
 ecdsa==0.11