- 23 May, 2013 1 commit
-
-
If a variable was provided for an include, in either of these ways: --- - hosts: all tasks: - include: included.yml param=www-data - include: included.yml vars: param: www-data and then that param was used as the value of sudo_user in the included tasks: --- - name: do something as a parameterized sudo_user command: whoami sudo: yes sudo_user: $param you would receive a "failed to parse: usage: sudo" error back and the command would not execute. This seemed to be due to a missing call to template.template somewhere, because the final value being passed through ssh was still `$param`. After some digging, the issue seems to instead have been a problem with providing the wrong context to the template for expansion. Inside the `Task` logic, it was passing `play.vars` as the context, where `module_vars` seemed more appropriate. After replacing it, my test case above ran without issue. There was a comment above suggesting that the template call might be unnecessary, but removing it made the original error return, since it is not getting escaped later down the line. I removed the comment since it was inaccurate. I tried to actually incorporate my test case above into the test suite as a regression test, but was unable to figure out how to structure it. The existing test infrastructure seemed to only be testing for correct number of counts in things (ok vs. changed, etc.), without regard for whether the content generated by the command is correct. If there is an example of a test similar to this one (where I would want to check the JSON generated to make sure sudo_user had been converted), please let me know and I will be happy to submit an additional patch.Kent Frazier committed
-
- 22 May, 2013 1 commit
-
-
Inventory script for Spacewalk servers based on the spacewalk-reports pa...
Michael DeHaan committed
-
- 21 May, 2013 4 commits
-
-
This is particularly important if you've manually ensured you have write access via group permissions and not by owner.
Jon Miller committed -
newrelic_deployment bug fix to support both python 2.4 and 2.6
Michael DeHaan committed -
Jon Miller committed
-
Bruce Pennypacker committed
-
- 20 May, 2013 2 commits
-
-
Prefer categorized modules to uncategorized, such that if someone does an install on top of old content the categorized modules will win over the 1.1 uncategorized modules, as the packages may not automatically clean up the old content.
Michael DeHaan committed -
Michael DeHaan committed
-
- 19 May, 2013 6 commits
-
-
Michael DeHaan committed
-
Michael DeHaan committed
-
Excplicity set paramiko's logging level to WARNING. By default it inherits ansible's DEBUG logging level (set in callbacks.py) and fills the log file with useless debug messages. Obviously it only applies if log_path is set in ansible.cfg
Dimos Alevizos committed -
pip module blowing up when name is not included in arg list
Michael DeHaan committed -
This code: ``` if name.endswith('.tar.gz') or name.endswith('.tar.bz2') or name.endswith('.zip'): is_tar = True ``` was not checking whether name is defined since it is an optional param.John Jarvis committed -
Don't hardcode chroot path
Michael DeHaan committed
-
- 18 May, 2013 26 commits
-
-
fixing syntax error
Michael DeHaan committed -
John Jarvis committed
-
Maykel Moya committed
-
Maykel Moya committed
-
Add vim swap files to gitignore
Michael DeHaan committed -
Darren Worrall committed
-
Fixes in apt module doc: typos, examples
Michael DeHaan committed -
Fix empty requirements specifications in modules documentation
Michael DeHaan committed -
no uses get_bin_path for 2nd use of ip tool
Michael DeHaan committed -
-o and -r option don't exist on AIX
Michael DeHaan committed -
Ben Ritcey committed
-
Add support for crypted passwords to password lookup
Michael DeHaan committed -
Add an update option to the git module
Michael DeHaan committed -
apt now uses module function to find bin paths
Michael DeHaan committed -
flowdock module returns changed=false on succes
Michael DeHaan committed -
Fix registered variable usage example
Michael DeHaan committed -
fix package mentioned twice in setup.py
Michael DeHaan committed -
update archlinux PKGBUILD for pacman 4.1
Michael DeHaan committed -
Added a helpful example to the ec2_facts doc.
Michael DeHaan committed -
Campfire Notification Module: Typo fixes, tighter error handling, corrected check mode support
Michael DeHaan committed -
Ton Kersten committed
-
jabber module returns changed=false on success
Michael DeHaan committed -
notification modules irc, mqtt now exit with changed=False
Michael DeHaan committed -
Make package version comparison use globbing.
Michael DeHaan committed -
Pip's name key can now accept remote package address.
Michael DeHaan committed -
**Summary**: There was a bug in the previous commit; pip module would add --use-mirrors options to a source package when state is absent. The bug is resolved in this commit by checking ``not is_package`` in the if branch. Furthermore, in order to support non-vcs source name like tarballs, we must not add -e option to the arg list. Given this circumstance, this commit have is_tar and is_vcs and the latter is checked to add -e option. Since mirrors do not make sense with vcs or tarball source, this commit will not add --use-mirrors (default to True) as always.
Yeukhon Wong committed
-