1. 07 Jan, 2014 1 commit
  2. 06 Jan, 2014 1 commit
  3. 12 Dec, 2013 1 commit
  4. 10 Dec, 2013 1 commit
  5. 09 Dec, 2013 1 commit
  6. 05 Dec, 2013 1 commit
  7. 03 Dec, 2013 2 commits
  8. 08 Nov, 2013 2 commits
  9. 01 Nov, 2013 1 commit
    • Remove label from forum posts by global staff · c4cdb457
      The motivation for this change is performance. The forums UI code gets
      the list of users for each role and renders the staff label based on
      those lists. The list for the staff role is expensive to compute because
      there is no index on the is_staff attribute, and we cannot create one
      because the User model is built into django.
      
      Users with is_staff=True are still assigned the Moderator role upon
      enrolling in a course, so this change will have no practical effect
      except that a user who is granted staff privileges after enrolling in a
      course will have to be made a Moderator in order for their posts to be
      labeled.
      
      Additionally, the UI did not use the list of users with the Student
      role, so that list has been removed as well.
      Greg Price committed
  10. 30 Oct, 2013 1 commit
  11. 28 Oct, 2013 5 commits
    • Improve performance of forum views · e6ecb6ec
      Avoid recomputing course module information for every thread, which
      should dramatically improve the performance of high-percentile latency
      queries.
      
      JIRA: FOR-250
      Greg Price committed
    • Remove an unnecessary global · a7d769df
      The _DISCUSSIONINFO global was originally used as a cache, but has since
      lost that capability and is therefore just harmful. This is a precursor
      to more refactoring that will improve the performance of the forums and
      may itself provide some performance improvement because it separates the
      computation done by two functions that each previously computed the
      entirety of _DISCUSSIONINFO.
      Greg Price committed
    • Add forum utility code unit test coverage · 545701d5
      This is in preparation for significant refactoring of the code in
      question.
      Greg Price committed
    • Remove unused code · 54ad4110
      Greg Price committed
    • Improve forum error handling · 7abaecd8
      CommentClientError now has sane subclasses that are meaningfully
      distinct, and each subclass is handled appropriately. Errors raised by
      the requests library are no longer handled by turning them into
      CommentClientErrors, since there is no meaningful handling we can do,
      and this way we will get more visibility into why errors are occurring.
      Also, HTTP status codes from the comments service indicating client
      error are correctly passed through to the client.
      Greg Price committed
  12. 22 Oct, 2013 2 commits
  13. 16 Oct, 2013 1 commit
    • Log all comments service requests · bd477581
      Logging the duration of each request will allow us to determine
      whether there is a significant difference in the latency reported by
      the comments service and that observed by the LMS. Each request will
      be assigned a unique identifier to allow correlation of the reported
      latency on each end.
      Greg Price committed
  14. 11 Oct, 2013 2 commits
  15. 10 Oct, 2013 1 commit
  16. 06 Sep, 2013 3 commits
  17. 27 Aug, 2013 1 commit
  18. 23 Aug, 2013 3 commits
  19. 21 Aug, 2013 2 commits
  20. 20 Aug, 2013 1 commit
  21. 19 Aug, 2013 2 commits
  22. 14 Aug, 2013 1 commit
    • Shift enroll/unenroll logic to CourseEnrollment model, add is_active and mode. · 3ce87583
      Features coming down the pipe will want to be able to:
      * Refer to enrollments before they are actually activated (approval step).
      * See what courses a user used to be enrolled in for when they re-enroll in
        the same course, or a different run of that course.
      * Have different "modes" of enrolling in a course, representing things like
        honor certificate enrollment, auditing (no certs), etc.
      
      This change adds an is_active flag and mode (with default being "honor").
      The commit is only as large as it is because many parts of the codebase were
      manipulating enrollments by adding and removing CourseEnrollment objects
      directly. It was necessary to create classmethods on CourseEnrollment to
      encapsulate this functionality and then port everything over to using them.
      
      The migration to add columns has been tested on a prod replica, and seems to be
      fine for running on a live system with single digit millions of rows of
      enrollments.
      David Ormsbee committed
  23. 30 Jul, 2013 1 commit
  24. 29 Jul, 2013 1 commit
  25. 25 Jul, 2013 1 commit
  26. 28 Jun, 2013 1 commit