1. 06 Nov, 2017 1 commit
  2. 09 Oct, 2017 1 commit
  3. 06 Sep, 2017 1 commit
  4. 27 Jul, 2017 1 commit
  5. 25 Jul, 2017 1 commit
  6. 21 Jul, 2017 1 commit
  7. 14 Jul, 2017 1 commit
  8. 11 Jul, 2017 1 commit
  9. 10 Jul, 2017 1 commit
  10. 06 Jul, 2017 1 commit
  11. 20 Jun, 2017 2 commits
  12. 12 Jun, 2017 1 commit
  13. 28 Apr, 2017 1 commit
  14. 27 Apr, 2017 2 commits
  15. 18 Apr, 2017 1 commit
  16. 12 Apr, 2017 1 commit
  17. 01 Mar, 2017 1 commit
  18. 23 Feb, 2017 1 commit
    • Test Speedup: Isolate Modulestore Signals · 2051c909
      There are a number of Django Signals that are on the modulestore's
      SignalHandler class, such as SignalHandler.course_published. These
      signals can trigger very expensive processes to occur, such as course
      overview or block structures generation. Most of the time, the test
      author doesn't care about these side-effects.
      
      This commit does a few things:
      
      * Converts the signals on SignalHandler to be instances of a new
        SwitchedSignal class, that allows signal sending to be disabled.
      
      * Creates a SignalIsolationMixin helper similar in spirit to the
        CacheIsolationMixin, and adds it to the ModuleStoreIsolationMixin
        (and thus to ModuleStoreTestCase and SharedModuleStoreTestCase).
      
      * Converts our various tests to use this new mechanism. In some cases,
        this means adjusting query counts downwards because they no longer
        have to account for publishing listener actions.
      
      Modulestore generated signals are now muted by default during test runs.
      Calls to send() them will result in no-ops. You can choose to enable
      specific signals for a given subclass of ModuleStoreTestCase or
      SharedModuleStoreTestCase by specifying an ENABLED_SIGNALS class
      attribute, like the following example:
      
          from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
      
          class MyPublishTestCase(ModuleStoreTestCase):
              ENABLED_SIGNALS = ['course_published', 'pre_publish']
      
      You should take great care when disabling signals outside of a
      ModuleStoreTestCase or SharedModuleStoreTestCase, since they can leak
      out into other tests. Be sure to always clean up, and never disable
      signals outside of testing. Because signals are essentially process
      globals, it can have a lot of unpleasant side-effects if we start
      mucking around with them during live requests.
      
      Overall, this change has cut the total test execution time for
      edx-platform by a bit over a third, though we still spend a lot in
      pre-test setup during our test builds.
      
      [PERF-413]
      David Ormsbee committed
  19. 03 Nov, 2016 1 commit
  20. 18 Oct, 2016 2 commits
    • [TNL-5632] Optimize the single_thread view. · 6704e17a
      Firstly, we're now explicitly instructing the comments service to not
      return thread responses/comments if the request isn't AJAX.  So, if you
      load the URL for a single discussion thread in your browser, this would
      be a non-AJAX call and we'll avoid loading the responses for the entire
      thread behind-the-scenes.  Big win here for large threads.
      
      Next, we removed a redundant "get threads" call which was also happening
      behind-the-scenes.  This call was redundant as the front-end JS also
      grabs the thread list when a topic is chosen, so we were making an
      extranenous call for no benefit.  Poof, gone!
      
      Finally, we added some caching of database queries that are required to
      drive a lot of the permissions/cohorts machinery around discussion.
      This will have a minimal effect but introduced a cleaner way to apply
      general memoization at the per-request level which will let us further
      cache things as we identify them as issues.
      Toby Lawrence committed
  21. 08 Sep, 2016 1 commit
    • Default to not requesting responses when grabbing a single thread. · 26891bc0
      We're often grabbing the metadata of a specific thread to then be able
      to perform other operations, but we never need the actual responses or
      comments of a thread unless we're displaying it in the normal forum
      view.
      
      This change sets a default of with_responses=False, which instructs the
      comment service to not send back the responses/comments for the given
      thread.  We only ask for responses in the case of rendering a single
      thread or inline discussion.
      Toby Lawrence committed
  22. 03 Aug, 2016 2 commits
  23. 25 Jul, 2016 1 commit
  24. 30 Jun, 2016 1 commit
  25. 16 Jun, 2016 1 commit
  26. 01 Jun, 2016 1 commit
  27. 04 May, 2016 2 commits
  28. 17 Mar, 2016 1 commit
  29. 01 Mar, 2016 1 commit
  30. 15 Jan, 2016 1 commit
  31. 11 Dec, 2015 1 commit
  32. 09 Dec, 2015 1 commit
  33. 22 Nov, 2015 1 commit
  34. 18 Nov, 2015 2 commits