- 09 Jul, 2015 16 commits
-
-
Grading Performance Work
David Ormsbee committed -
Re-enable the video translation Jasmine tests
Andy Armstrong committed -
ORA2: Focus and outline styles
Chris committed -
Credit Payment - Dashboard States
Ahsan Ulhaq committed -
Usman Khalid committed
-
Chris Rodriguez committed
-
Fix the Paver run_all_servers method.
Andy Armstrong committed -
Upgrade Django 1.4 to the latest point release
Sarina Canelake committed -
The progress page did a number of things that make performance terrible for courses with large numbers of problems, particularly if those problems are customresponse CapaModule problems that need to be executed via codejail. The grading code takes pains to not instantiate student state and execute the problem code. If a student has answered the question, the max score is stored in StudentModule. However, if the student hasn't attempted the question yet, we have to run the problem code just to call .max_score() on it. This is necessary in grade() if the student has answered other problems in the assignment (so we can know what to divide by). This is always necessary to know in progress_summary() because we list out every problem there. Code execution can be especially slow if the problems need to invoke codejail. To address this, we create a MaxScoresCache that will cache the max raw score possible for every problem. We select the cache keys so that it will automatically become invalidated when a new version of the course is published. The fundamental assumption here is that a problem cannot have two different max score values for two unscored students. A problem *can* score two students differently such that they have different max scores. So Carlos can have 2/3 on a problem, while Lyla gets 3/4. But if neither Carlos nor Lyla has ever interacted with the problem (i.e. they're just seeing it on their progress page), they must both see 0/4 -- it cannot be the case that Carlos sees 0/3 and Lyla sees 0/4. We used to load all student state into two separate FieldDataCache instances, after which we do a bunch of individual queries for scored items. Part of this split-up was done because of locking problems, but I think we might have gotten overzealous with our manual transaction hammer. In this commit, we consolidate all state access in grade() and progress() to use one shared FieldDataCache. We also use a filter so that we only pull back StudentModule state for things that might possibly affect the grade -- items that either have scores or have children. Because some older XModules do work in their __init__() methods (like Video), instantiating them takes time, particularly on large courses. This commit also changes the code that fetches the grading_context to filter out children that can't possibly affect the grade. Finally, we introduce a ScoresClient that also tries to fetch score information all at once, instead of in separate queries. Technically, we are fetching this information redundantly, but that's because the state and score interfaces are being teased apart as we move forward. Still, this only amounts to one extra SQL query, and has very little impact on performance overall. Much thanks to @adampalay -- his hackathon work in #7168 formed the basis of this. https://openedx.atlassian.net/browse/CSM-17
David Ormsbee committed -
TNL-2689
Andy Armstrong committed -
add 'provider_description' field for CreditProvider model
zubair-arbi committed -
ECOM-1578
Ahsan Ulhaq committed -
ECOM-1842
zubair-arbi committed -
add 'fulfillment_instructions' for 'CreditProvider' model
zubair-arbi committed -
update credit eligibility ui text
zubair-arbi committed -
Comparing currencies with same case
Clinton Blackburn committed
-
- 08 Jul, 2015 24 commits
-
-
Ahodges/staff labeling
Alison Hodges committed -
Sarina Canelake committed
-
This reverts commit c94abd27.
Brandon DeRosier committed -
This reverts commit 85b3bfe4.
Brandon DeRosier committed -
Matt Drayer committed
-
XCOM-312
Clinton Blackburn committed -
Awais committed
-
Adds the "order" field that was introduced in 0011 to the "models" dictionary of migrations 0012 and 0013 so South knows that the field should exist after 0011 is run.
Will Daly committed -
Fix a small typo for credit requirements on the progress page.
Will Daly committed -
Remove unused Ruby gems
David Baumgold committed -
Will Daly committed
-
Fix 'stuck in publish issue' when deleting a component
Mushtaq Ali committed -
Fix hinted login view to be compatible with secondary providers.
Braden MacDonald committed -
Added more descripted release script message
Christopher Lee committed -
These were only used by rake, and we haven't used rake in a year.
David Baumgold committed -
TNL-2665 Prevent Taiwan from being translated
Ben McMorran committed -
Update LMS student dashboard to use CourseOverview
Kyle McCormick committed -
Disable flaky GroupConfigurationsPage JS test TNL-1475
Jesse Zoldak committed -
Revert "Update copy for On Demand Cert Download"
Ben Patterson committed -
christopher lee committed
-
Kyle McCormick committed
-
Kyle McCormick committed
-
Jesse Zoldak committed
-