save the self referencing field 'copy_id_photo_from' for ICRV photo verifications + update test

lms/djangoapps/verify_student/models.py

@@ -663,10 +663,12 @@ class SoftwareSecurePhotoVerification(PhotoVerification):
 
     @status_before_must_be("must_retry", "ready", "submitted")
     def submit(self, copy_id_photo_from=None):
-        """
-        Submit our verification attempt to Software Secure for validation. This
-        will set our status to "submitted" if the post is successful, and
+        """Submit our verification attempt to Software Secure for validation.
+
+        This will set our status to "submitted" if the post is successful, and
         "must_retry" if the post fails.
+        This will also set the self referencing field 'copy_id_photo_from' on
+        the software secure photo validation object.
 
         Keyword Arguments:
             copy_id_photo_from (SoftwareSecurePhotoVerification): If provided, re-send the ID photo
@@ -674,6 +676,12 @@ class SoftwareSecurePhotoVerification(PhotoVerification):
                 are sent with previously-submitted ID photos.
 
         """
+        if copy_id_photo_from:
+            # Update the field 'copy_id_photo_from' with provided software
+            # secure photo verification object
+            self.copy_id_photo_from = copy_id_photo_from
+            self.save()
+
         try:
             response = self.send_request(copy_id_photo_from=copy_id_photo_from)
             if response.ok:

lms/djangoapps/verify_student/tests/test_models.py

@@ -484,9 +484,9 @@ class TestPhotoVerification(ModuleStoreTestCase):
         self.assertIs(result, None)
 
         # Make an initial verification with 'photo_id_key'
-        attempt = SoftwareSecurePhotoVerification(user=user, photo_id_key="dummy_photo_id_key")
-        attempt.status = 'approved'
-        attempt.save()
+        first_attempt = SoftwareSecurePhotoVerification(user=user, photo_id_key="dummy_photo_id_key")
+        first_attempt.status = 'approved'
+        first_attempt.save()
 
         # Check that method 'get_initial_verification' returns the correct
         # initial verification attempt
@@ -494,9 +494,11 @@ class TestPhotoVerification(ModuleStoreTestCase):
         self.assertIsNotNone(first_result)
 
         # Now create a second verification without 'photo_id_key'
-        attempt = SoftwareSecurePhotoVerification(user=user)
-        attempt.status = 'submitted'
-        attempt.save()
+        second_attempt = SoftwareSecurePhotoVerification(user=user)
+        second_attempt.mark_ready()
+        # Parameter 'copy_id_photo_from' is used for reverification, in which
+        # new face photos are sent with previously-submitted ID photos
+        second_attempt.submit(copy_id_photo_from=first_result)
 
         # Test method 'get_initial_verification' still returns the correct
         # initial verification attempt which have 'photo_id_key' set
@@ -504,6 +506,11 @@ class TestPhotoVerification(ModuleStoreTestCase):
         self.assertIsNotNone(second_result)
         self.assertEqual(second_result, first_result)
 
+        # Also verify that second photo verification has set self referencing field
+        # 'copy_id_photo_from' with initial verification
+        self.assertIsNotNone(second_attempt.copy_id_photo_from)
+        self.assertEqual(second_attempt.copy_id_photo_from, first_attempt)
+
 
 @ddt.ddt
 class VerificationCheckpointTest(ModuleStoreTestCase):