Commit fe2e25df by Dave Chamberlain

ECOM-6921: Added aria-modal="true" to Support Modal

    Changed the section to a div, and converted the aria-label
    to a labelledby attr instead (no sense in generating the string
    mulitiple times).
parent cea871ec
...@@ -18,7 +18,7 @@ from xmodule.tabs import CourseTabList ...@@ -18,7 +18,7 @@ from xmodule.tabs import CourseTabList
<a href="#help-modal" rel="leanModal" role="button">${_("Support")}</a> <a href="#help-modal" rel="leanModal" role="button">${_("Support")}</a>
</div> </div>
<section id="help-modal" class="modal" aria-hidden="true" role="dialog" tabindex="-1" aria-label="${_("{platform_name} Support").format(platform_name=static.get_platform_name())}"> <div id="help-modal" class="modal" aria-hidden="true" role="dialog" aria-modal="true" tabindex="-1" aria-labelledby="support-platform-name">
<div class="inner-wrapper"> <div class="inner-wrapper">
## TODO: find a way to refactor this ## TODO: find a way to refactor this
<button class="close-modal" tabindex="0"> <button class="close-modal" tabindex="0">
...@@ -31,7 +31,7 @@ from xmodule.tabs import CourseTabList ...@@ -31,7 +31,7 @@ from xmodule.tabs import CourseTabList
<div id="help_wrapper"> <div id="help_wrapper">
<header> <header>
<h2> <h2 id="support-platform-name">
${Text(_('{platform_name} Support')).format( ${Text(_('{platform_name} Support')).format(
platform_name=HTML(u'<span class="edx">{}</span>').format(static.get_platform_name()) platform_name=HTML(u'<span class="edx">{}</span>').format(static.get_platform_name())
)} )}
...@@ -140,7 +140,7 @@ from xmodule.tabs import CourseTabList ...@@ -140,7 +140,7 @@ from xmodule.tabs import CourseTabList
</p> </p>
</div> </div>
</div> </div>
</section> </div>
<script type="text/javascript"> <script type="text/javascript">
$(document).ready(function() { $(document).ready(function() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment