Commit fa62f48e by David Baumgold

Fix Jasmine test failures

parent e7088d50
...@@ -25,6 +25,17 @@ describe "CMS.Views.ShowTextbook", -> ...@@ -25,6 +25,17 @@ describe "CMS.Views.ShowTextbook", ->
@promptSpies = spyOnConstructor(CMS.Views.Prompt, "Warning", ["show", "hide"]) @promptSpies = spyOnConstructor(CMS.Views.Prompt, "Warning", ["show", "hide"])
@promptSpies.show.andReturn(@promptSpies) @promptSpies.show.andReturn(@promptSpies)
window.section = new CMS.Models.Section({
id: "5",
name: "Course Name",
url_name: "course_name",
org: "course_org",
num: "course_num",
revision: "course_rev"
});
afterEach ->
delete window.section
describe "Basic", -> describe "Basic", ->
it "should render properly", -> it "should render properly", ->
...@@ -334,7 +345,8 @@ describe "CMS.Views.UploadDialog", -> ...@@ -334,7 +345,8 @@ describe "CMS.Views.UploadDialog", ->
it "should render without a file selected", -> it "should render without a file selected", ->
@view.render() @view.render()
expect(@view.$el).toContain("input[type=file]") expect(@view.$el).toContain("input[type=file]")
expect(@view.$(".action-upload")).toBeDisabled() # expect(@view.$(".action-upload")).toBeDisabled()
expect(@view.$(".action-upload")).toHaveClass("disabled")
it "should render with a PDF selected", -> it "should render with a PDF selected", ->
file = {name: "fake.pdf", "type": "application/pdf"} file = {name: "fake.pdf", "type": "application/pdf"}
...@@ -342,8 +354,9 @@ describe "CMS.Views.UploadDialog", -> ...@@ -342,8 +354,9 @@ describe "CMS.Views.UploadDialog", ->
@model.set("selectedFile", file) @model.set("selectedFile", file)
@view.render() @view.render()
expect(@view.$el).toContain("input[type=file]") expect(@view.$el).toContain("input[type=file]")
expect(@view.$el).not.toContain("p.error") expect(@view.$el).not.toContain("#upload_error")
expect(@view.$(".action-upload")).not.toBeDisabled() # expect(@view.$(".action-upload")).not.toBeDisabled()
expect(@view.$(".action-upload")).not.toHaveClass("disabled")
it "should render an error with an invalid file type selected", -> it "should render an error with an invalid file type selected", ->
file = {name: "fake.png", "type": "image/png"} file = {name: "fake.png", "type": "image/png"}
...@@ -351,8 +364,9 @@ describe "CMS.Views.UploadDialog", -> ...@@ -351,8 +364,9 @@ describe "CMS.Views.UploadDialog", ->
@model.set("selectedFile", file) @model.set("selectedFile", file)
@view.render() @view.render()
expect(@view.$el).toContain("input[type=file]") expect(@view.$el).toContain("input[type=file]")
expect(@view.$el).toContain("p.error") expect(@view.$el).toContain("#upload_error")
expect(@view.$(".action-upload")).toBeDisabled() # expect(@view.$(".action-upload")).toBeDisabled()
expect(@view.$(".action-upload")).toHaveClass("disabled")
it "adds body class on show()", -> it "adds body class on show()", ->
......
...@@ -42,7 +42,7 @@ ...@@ -42,7 +42,7 @@
<h3 class="sr"><%= gettext('Form Actions') %></h3> <h3 class="sr"><%= gettext('Form Actions') %></h3>
<ul> <ul>
<li class="action-item"> <li class="action-item">
<a href="#" class="button action-primary action-upload <% if (!selectedFile) { %>disabled<% } %>"><%= gettext('Upload') %></a> <a href="#" class="button action-primary action-upload <% if (!selectedFile || error) { %>disabled<% } %>"><%= gettext('Upload') %></a>
</li> </li>
<li class="action-item"> <li class="action-item">
<a href="#" class="button action-secondary action-cancel"><%= gettext('Cancel') %></a> <a href="#" class="button action-secondary action-cancel"><%= gettext('Cancel') %></a>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment