Commit f8594570 by Calen Pennington

Cache loaded plugins in memory

parent 520fac1a
...@@ -23,6 +23,9 @@ class Plugin(object): ...@@ -23,6 +23,9 @@ class Plugin(object):
entry_point: The name of the entry point to load plugins from entry_point: The name of the entry point to load plugins from
""" """
_plugin_cache = None
@classmethod @classmethod
def load_class(cls, identifier, default=None): def load_class(cls, identifier, default=None):
""" """
...@@ -33,20 +36,25 @@ class Plugin(object): ...@@ -33,20 +36,25 @@ class Plugin(object):
If default is not None, will return default if no entry_point matching identifier If default is not None, will return default if no entry_point matching identifier
is found. Otherwise, will raise a ModuleMissingError is found. Otherwise, will raise a ModuleMissingError
""" """
identifier = identifier.lower() if cls._plugin_cache is None:
classes = list(pkg_resources.iter_entry_points(cls.entry_point, name=identifier)) cls._plugin_cache = {}
if len(classes) > 1:
log.warning("Found multiple classes for {entry_point} with identifier {id}: {classes}. Returning the first one.".format( if identifier not in cls._plugin_cache:
entry_point=cls.entry_point, identifier = identifier.lower()
id=identifier, classes = list(pkg_resources.iter_entry_points(cls.entry_point, name=identifier))
classes=", ".join(class_.module_name for class_ in classes))) if len(classes) > 1:
log.warning("Found multiple classes for {entry_point} with identifier {id}: {classes}. Returning the first one.".format(
if len(classes) == 0: entry_point=cls.entry_point,
if default is not None: id=identifier,
return default classes=", ".join(class_.module_name for class_ in classes)))
raise ModuleMissingError(identifier)
if len(classes) == 0:
return classes[0].load() if default is not None:
return default
raise ModuleMissingError(identifier)
cls._plugin_cache[identifier] = classes[0].load()
return cls._plugin_cache[identifier]
@classmethod @classmethod
def load_classes(cls): def load_classes(cls):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment