Commit f2168356 by Martyn James Committed by Jonathan Piacenti

Don't consider complete if proforma is 0; cannot possibly be

parent 9eaf7206
...@@ -342,7 +342,7 @@ class OrganizationsApiTests(ModuleStoreTestCase): ...@@ -342,7 +342,7 @@ class OrganizationsApiTests(ModuleStoreTestCase):
def test_organizations_metrics_get_courses_filter(self): def test_organizations_metrics_get_courses_filter(self):
users = [] users = []
for i in xrange(1, 10): for i in xrange(1, 12):
data = { data = {
'email': 'test{}@example.com'.format(i), 'email': 'test{}@example.com'.format(i),
'username': 'test_user{}'.format(i), 'username': 'test_user{}'.format(i),
...@@ -367,8 +367,11 @@ class OrganizationsApiTests(ModuleStoreTestCase): ...@@ -367,8 +367,11 @@ class OrganizationsApiTests(ModuleStoreTestCase):
StudentGradebook.objects.create(user=user, grade=0.72, proforma_grade=0.78, course_id=course3.id) StudentGradebook.objects.create(user=user, grade=0.72, proforma_grade=0.78, course_id=course3.id)
elif i < 9: elif i < 9:
StudentGradebook.objects.create(user=user, grade=0.94, proforma_grade=0.67, course_id=course1.id) StudentGradebook.objects.create(user=user, grade=0.94, proforma_grade=0.67, course_id=course1.id)
else: elif i < 11:
StudentGradebook.objects.create(user=user, grade=0.90, proforma_grade=0.91, course_id=course2.id) StudentGradebook.objects.create(user=user, grade=0.90, proforma_grade=0.91, course_id=course2.id)
else:
# Not started student - should be considered incomplete
StudentGradebook.objects.create(user=user, grade=0.00, proforma_grade=0.00, course_id=course2.id)
data = { data = {
'name': self.test_organization_name, 'name': self.test_organization_name,
......
...@@ -44,7 +44,7 @@ class OrganizationsViewSet(viewsets.ModelViewSet): ...@@ -44,7 +44,7 @@ class OrganizationsViewSet(viewsets.ModelViewSet):
courses.append(get_course_key(course_string)) courses.append(get_course_key(course_string))
org_user_grades = org_user_grades.filter(course_id__in=courses) org_user_grades = org_user_grades.filter(course_id__in=courses)
users_grade_complete_count = org_user_grades\ users_grade_complete_count = org_user_grades\
.filter(proforma_grade__lte=F('grade') + grade_complete_match_range).count() .filter(proforma_grade__lte=F('grade') + grade_complete_match_range, proforma_grade__gt=0).count()
response_data['users_grade_complete_count'] = users_grade_complete_count response_data['users_grade_complete_count'] = users_grade_complete_count
return Response(response_data, status=status.HTTP_200_OK) return Response(response_data, status=status.HTTP_200_OK)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment