Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
ec13349a
Commit
ec13349a
authored
Jul 02, 2013
by
Peter Fogg
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove outdated deleteKeys from advanced settings.
parent
3d4f9268
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 additions
and
33 deletions
+1
-33
cms/static/js/models/settings/advanced.js
+0
-26
cms/static/js/views/settings/advanced_view.js
+1
-7
No files found.
cms/static/js/models/settings/advanced.js
View file @
ec13349a
...
...
@@ -5,8 +5,6 @@ CMS.Models.Settings.Advanced = Backbone.Model.extend({
defaults
:
{
// the properties are whatever the user types in (in addition to whatever comes originally from the server)
},
// which keys to send as the deleted keys on next save
deleteKeys
:
[],
validate
:
function
(
attrs
)
{
// Keys can no longer be edited. We are currently not validating values.
...
...
@@ -18,32 +16,8 @@ CMS.Models.Settings.Advanced = Backbone.Model.extend({
// add saveSuccess to the success
var
success
=
options
.
success
;
options
.
success
=
function
(
model
,
resp
,
options
)
{
model
.
afterSave
(
model
);
if
(
success
)
success
(
model
,
resp
,
options
);
};
Backbone
.
Model
.
prototype
.
save
.
call
(
this
,
attrs
,
options
);
},
afterSave
:
function
(
self
)
{
// remove deleted attrs
if
(
!
_
.
isEmpty
(
self
.
deleteKeys
))
{
// remove the to be deleted keys from the returned model
_
.
each
(
self
.
deleteKeys
,
function
(
key
)
{
self
.
unset
(
key
);
});
// not able to do via backbone since we're not destroying the model
$
.
ajax
({
url
:
self
.
url
,
// json to and fro
contentType
:
"application/json"
,
dataType
:
"json"
,
// delete
type
:
'DELETE'
,
// data
data
:
JSON
.
stringify
({
deleteKeys
:
self
.
deleteKeys
})
})
.
done
(
function
(
data
,
status
,
error
)
{
// clear deleteKeys on success
self
.
deleteKeys
=
[];
});
}
}
});
cms/static/js/views/settings/advanced_view.js
View file @
ec13349a
...
...
@@ -61,13 +61,7 @@ CMS.Views.Settings.Advanced = CMS.Views.ValidatingView.extend({
var
message
=
gettext
(
"Your changes will not take effect until you save your progress. Take care with key and value formatting, as validation is not implemented."
);
self
.
showNotificationBar
(
message
,
_
.
bind
(
self
.
saveView
,
self
),
function
()
{
self
.
model
.
deleteKeys
=
[];
self
.
revertView
();
});
if
(
self
.
saved
)
{
self
.
saved
.
hide
();
}
_
.
bind
(
self
.
revertView
,
self
));
}
},
onFocus
:
function
(
mirror
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment