Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
e8945ebd
Commit
e8945ebd
authored
Oct 05, 2017
by
Robert Raposa
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Course home event clean-up.
- Convert hero events to BI events. - Upgrade click event clean-up LEARNER-2026
parent
07061caf
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
13 additions
and
9 deletions
+13
-9
lms/static/js/courseware/course_home_events.js
+1
-1
lms/static/js/spec/courseware/course_home_events_spec.js
+4
-2
openedx/features/course_experience/static/course_experience/js/CourseHome.js
+5
-4
openedx/features/course_experience/static/course_experience/js/spec/CourseHome_spec.js
+3
-2
No files found.
lms/static/js/courseware/course_home_events.js
View file @
e8945ebd
...
@@ -9,7 +9,7 @@
...
@@ -9,7 +9,7 @@
});
});
});
});
$
(
'.date-summary-verified-upgrade-deadline .date-summary-link'
).
on
(
'click'
,
function
()
{
$
(
'.date-summary-verified-upgrade-deadline .date-summary-link'
).
on
(
'click'
,
function
()
{
Logger
.
log
(
'edx.course.enrollment.upgrade.clicked'
,
{
location
:
'sidebar'
});
Logger
.
log
(
'edx.course.enrollment.upgrade.clicked'
,
{
location
:
'
date-
sidebar'
});
});
});
};
};
});
});
...
...
lms/static/js/spec/courseware/course_home_events_spec.js
View file @
e8945ebd
...
@@ -17,9 +17,11 @@ define(['jquery', 'logger', 'js/courseware/course_home_events'], function($, Log
...
@@ -17,9 +17,11 @@ define(['jquery', 'logger', 'js/courseware/course_home_events'], function($, Log
});
});
});
});
it
(
'sends an event when "Upgrade to Verified" is clicked from the sidebar'
,
function
()
{
it
(
'sends an event when "Upgrade to Verified" is clicked from the
date
sidebar'
,
function
()
{
$
(
'.date-summary-link'
).
click
();
$
(
'.date-summary-link'
).
click
();
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'edx.course.enrollment.upgrade.clicked'
,
{
location
:
'sidebar'
});
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'edx.course.enrollment.upgrade.clicked'
,
{
location
:
'date-sidebar'
}
);
});
});
});
});
});
});
openedx/features/course_experience/static/course_experience/js/CourseHome.js
View file @
e8945ebd
...
@@ -96,7 +96,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
...
@@ -96,7 +96,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
const
$vcDismissToggle
=
$
(
'.vc-toggle'
,
$vcMessage
);
const
$vcDismissToggle
=
$
(
'.vc-toggle'
,
$vcMessage
);
const
logEventProperties
=
{
courseRunKey
:
this
.
courseRunKey
};
const
logEventProperties
=
{
courseRunKey
:
this
.
courseRunKey
};
Logger
.
log
(
'edx.course.upgrade.hero.displayed'
,
logEventProperties
);
Logger
.
log
(
'edx.
bi.
course.upgrade.hero.displayed'
,
logEventProperties
);
// Get height of container and button
// Get height of container and button
let
vcHeight
=
$vcMessage
.
outerHeight
();
let
vcHeight
=
$vcMessage
.
outerHeight
();
...
@@ -125,7 +125,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
...
@@ -125,7 +125,7 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
$vcDismissToggle
.
click
(()
=>
{
$vcDismissToggle
.
click
(()
=>
{
if
(
$vcMessage
.
hasClass
(
'polite'
))
{
if
(
$vcMessage
.
hasClass
(
'polite'
))
{
// Expand message
// Expand message
Logger
.
log
(
'edx.course.upgrade.hero.expanded'
,
logEventProperties
);
Logger
.
log
(
'edx.
bi.
course.upgrade.hero.expanded'
,
logEventProperties
);
this
.
persistUpgradeMessageState
(
false
);
this
.
persistUpgradeMessageState
(
false
);
$
(
'.vc-fade'
).
fadeOut
(
400
);
$
(
'.vc-fade'
).
fadeOut
(
400
);
...
@@ -136,14 +136,15 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
...
@@ -136,14 +136,15 @@ export class CourseHome { // eslint-disable-line import/prefer-default-export
});
});
}
else
{
}
else
{
// Collapse message
// Collapse message
Logger
.
log
(
'edx.course.upgrade.hero.collapsed'
,
logEventProperties
);
Logger
.
log
(
'edx.
bi.
course.upgrade.hero.collapsed'
,
logEventProperties
);
this
.
persistUpgradeMessageState
(
true
);
this
.
persistUpgradeMessageState
(
true
);
collapseMessage
();
collapseMessage
();
}
}
});
});
$
(
'.btn-upgrade'
,
$vcMessage
).
click
(()
=>
{
$
(
'.btn-upgrade'
,
$vcMessage
).
click
(()
=>
{
Logger
.
log
(
'edx.course.upgrade.hero.clicked'
,
logEventProperties
);
Logger
.
log
(
'edx.bi.course.upgrade.hero.clicked'
,
logEventProperties
);
Logger
.
log
(
'edx.course.enrollment.upgrade.clicked'
,
{
location
:
'hero'
});
});
});
}
}
}
}
openedx/features/course_experience/static/course_experience/js/spec/CourseHome_spec.js
View file @
e8945ebd
...
@@ -57,13 +57,14 @@ describe('Course Home factory', () => {
...
@@ -57,13 +57,14 @@ describe('Course Home factory', () => {
it
(
'should send events to Segment and edX on initial load'
,
()
=>
{
it
(
'should send events to Segment and edX on initial load'
,
()
=>
{
expect
(
window
.
analytics
.
track
).
toHaveBeenCalledWith
(
'Promotion Viewed'
,
segmentEventProperties
);
expect
(
window
.
analytics
.
track
).
toHaveBeenCalledWith
(
'Promotion Viewed'
,
segmentEventProperties
);
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'edx.course.upgrade.hero.displayed'
,
{
courseRunKey
:
runKey
});
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'edx.
bi.
course.upgrade.hero.displayed'
,
{
courseRunKey
:
runKey
});
});
});
it
(
'should send events to Segment and edX after clicking the upgrade button '
,
()
=>
{
it
(
'should send events to Segment and edX after clicking the upgrade button '
,
()
=>
{
$
(
'.vc-message .btn-upgrade'
).
click
();
$
(
'.vc-message .btn-upgrade'
).
click
();
expect
(
window
.
analytics
.
track
).
toHaveBeenCalledWith
(
'Promotion Viewed'
,
segmentEventProperties
);
expect
(
window
.
analytics
.
track
).
toHaveBeenCalledWith
(
'Promotion Viewed'
,
segmentEventProperties
);
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'edx.course.upgrade.hero.clicked'
,
{
courseRunKey
:
runKey
});
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'edx.bi.course.upgrade.hero.clicked'
,
{
courseRunKey
:
runKey
});
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'edx.course.enrollment.upgrade.clicked'
,
{
location
:
'hero'
});
});
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment