Skip to content

E
edx-platform
Commit e62c047f by polesye
Options

Fix a malformed custom_parameter bug.

parent c4bb2ac7
Showing with 6 additions and 4 deletions
common/lib/xmodule/xmodule/lti_module.py
...@@ -150,8 +150,9 @@ class LTIModule(LTIFields, XModule): ...@@ -150,8 +150,9 @@ class LTIModule(LTIFields, XModule):
try: try:
lti_id, key, secret = lti_passport.split(':') lti_id, key, secret = lti_passport.split(':')
except ValueError: except ValueError:
raise LTIError('Could not parse LTI passport: {0!r}. \ lti_id = key = secret = ''
Should be "id:key:secret" string.'.format(lti_passport)) log.error('Could not parse LTI passport: {0!r}. \
Should be "id:key:secret" string.'.format(lti_passport))
if lti_id == self.lti_id.strip(): if lti_id == self.lti_id.strip():
client_key, client_secret = key, secret client_key, client_secret = key, secret
break break
...@@ -162,8 +163,9 @@ class LTIModule(LTIFields, XModule): ...@@ -162,8 +163,9 @@ class LTIModule(LTIFields, XModule):
try: try:
param_name, param_value = custom_parameter.split('=', 1) param_name, param_value = custom_parameter.split('=', 1)
except ValueError: except ValueError:
raise LTIError('Could not parse custom parameter: {0!r}. \ param_name = param_value = ''
Should be "x=y" string.'.format(custom_parameter)) log.error('Could not parse custom parameter: {0!r}. \
Should be "x=y" string.'.format(custom_parameter))
custom_parameters[unicode(param_name.strip())] = unicode(param_value.strip()) custom_parameters[unicode(param_name.strip())] = unicode(param_value.strip())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment