Merge pull request #15829 from edx/efischer/EDU-1142

Fix Proctoring doc link

cms/djangoapps/contentstore/views/item.py

@@ -1192,9 +1192,10 @@ def create_xblock_info(xblock, data=None, metadata=None, include_ancestor_info=F
                     'enable_timed_exams': xblock.enable_timed_exams
                 })
             elif xblock.category == 'sequential':
+                rules_url = settings.PROCTORING_SETTINGS.get('LINK_URLS', {}).get('online_proctoring_rules', ""),
                 xblock_info.update({
                     'is_proctored_exam': xblock.is_proctored_exam,
-                    'online_proctoring_rules': settings.PROCTORING_SETTINGS.get('LINK_URLS', {}).get('online_proctoring_rules', {}),
+                    'online_proctoring_rules': rules_url,
                     'is_practice_exam': xblock.is_practice_exam,
                     'is_time_limited': xblock.is_time_limited,
                     'exam_review_rules': xblock.exam_review_rules,

cms/templates/js/timed-examination-preference-editor.underscore

@@ -44,15 +44,19 @@
                 </label>
                 <% var online_proctoring_rules = xblockInfo.get('online_proctoring_rules'); %>
                 <p class='field-message' id='review-rules-description'>
-                <%= edx.HtmlUtils.interpolateHtml(
-                    gettext('Specify any rules or rule exceptions that the proctoring review team should enforce when reviewing the videos. For example, you could specify that calculators are allowed. These specified rules are visible to learners before the learners start the exam, along with the {linkStart}general proctored exam rules{linkEnd}.'),
-                    {
-                        linkStart: edx.HtmlUtils.interpolateHtml(
-                            edx.HtmlUtils.HTML('<a href="{onlineProctoringUrl}" title="{onlineProctoringTitle}">'),
-                            { onlineProctoringUrl: online_proctoring_rules, onlineProctoringTitle: gettext('General Proctored Exam Rules')}),
-                        linkEnd: edx.HtmlUtils.HTML('</a>')
-                    })
-                %>
+                <% if (online_proctoring_rules) { %>
+                    <%= edx.HtmlUtils.interpolateHtml(
+                        gettext('Specify any rules or rule exceptions that the proctoring review team should enforce when reviewing the videos. For example, you could specify that calculators are allowed. These specified rules are visible to learners before the learners start the exam, along with the {linkStart}general proctored exam rules{linkEnd}.'),
+                        {
+                            linkStart: edx.HtmlUtils.interpolateHtml(
+                                edx.HtmlUtils.HTML('<a href="{onlineProctoringUrl}" title="{onlineProctoringTitle}">'),
+                                { onlineProctoringUrl: online_proctoring_rules, onlineProctoringTitle: gettext('General Proctored Exam Rules')}),
+                            linkEnd: edx.HtmlUtils.HTML('</a>')
+                        })
+                    %>
+                <% } else { %>
+                    <%- gettext('Specify any rules or rule exceptions that the proctoring review team should enforce when reviewing the videos. For example, you could specify that calculators are allowed. These specified rules are visible to learners before the learners start the exam.') %>
+                <% } %>
                 </p>
             </div>
         </div>