Skip to content

E
edx-platform
Commit e2e32e31 by Arthur Barrett
Options

make user id check more idiomatic

parent 6f7f9245
Showing with 3 additions and 3 deletions
lms/djangoapps/notes/api.py
...@@ -153,7 +153,7 @@ def read(request, course_id, note_id): ...@@ -153,7 +153,7 @@ def read(request, course_id, note_id):
except Note.DoesNotExist: except Note.DoesNotExist:
return ApiResponse(http_response=HttpResponse('', status=404), data=None) return ApiResponse(http_response=HttpResponse('', status=404), data=None)
if not note.user.id == request.user.id: if note.user.id != request.user.id:
return ApiResponse(http_response=HttpResponse('', status=403), data=None) return ApiResponse(http_response=HttpResponse('', status=403), data=None)
return ApiResponse(http_response=HttpResponse(), data=note.as_dict()) return ApiResponse(http_response=HttpResponse(), data=note.as_dict())
...@@ -168,7 +168,7 @@ def update(request, course_id, note_id): ...@@ -168,7 +168,7 @@ def update(request, course_id, note_id):
except Note.DoesNotExist: except Note.DoesNotExist:
return ApiResponse(http_response=HttpResponse('', status=404), data=None) return ApiResponse(http_response=HttpResponse('', status=404), data=None)
if not note.user.id == request.user.id: if note.user.id != request.user.id:
return ApiResponse(http_response=HttpResponse('', status=403), data=None) return ApiResponse(http_response=HttpResponse('', status=403), data=None)
try: try:
...@@ -194,7 +194,7 @@ def delete(request, course_id, note_id): ...@@ -194,7 +194,7 @@ def delete(request, course_id, note_id):
except Note.DoesNotExist: except Note.DoesNotExist:
return ApiResponse(http_response=HttpResponse('', status=404), data=None) return ApiResponse(http_response=HttpResponse('', status=404), data=None)
if not note.user.id == request.user.id: if note.user.id != request.user.id:
return ApiResponse(http_response=HttpResponse('', status=403), data=None) return ApiResponse(http_response=HttpResponse('', status=403), data=None)
note.delete() note.delete()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment