Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
e17504d7
Commit
e17504d7
authored
Feb 16, 2015
by
stv
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Pylint: E0012(bad-option-value)
parent
ee2404c0
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
7 additions
and
15 deletions
+7
-15
common/lib/xmodule/xmodule/tabs.py
+1
-7
lms/djangoapps/bulk_email/forms.py
+2
-2
lms/djangoapps/dashboard/models.py
+0
-2
lms/djangoapps/dashboard/support.py
+1
-1
lms/djangoapps/notes/api.py
+2
-2
lms/djangoapps/survey/admin.py
+1
-1
No files found.
common/lib/xmodule/xmodule/tabs.py
View file @
e17504d7
"""
Implement CourseTab
"""
# pylint: disable=incomplete-protocol
# Note: pylint complains that we do not implement __delitem__ and __len__, although we implement __setitem__
# and __getitem__. However, the former two do not apply to the CourseTab class so we do not implement them.
# The reason we implement the latter two is to enable callers to continue to use the CourseTab object with
# dict-type accessors.
from
abc
import
ABCMeta
,
abstractmethod
from
xblock.fields
import
List
...
...
@@ -15,7 +9,7 @@ from xblock.fields import List
_
=
lambda
text
:
text
class
CourseTab
(
object
):
# pylint: disable=incomplete-protocol
class
CourseTab
(
object
):
"""
The Course Tab class is a data abstraction for all tabs (i.e., course navigation links) within a course.
It is an abstract class - to be inherited by various tab types.
...
...
lms/djangoapps/bulk_email/forms.py
View file @
e17504d7
...
...
@@ -17,7 +17,7 @@ from opaque_keys.edx.locations import SlashSeparatedCourseKey
log
=
logging
.
getLogger
(
__name__
)
class
CourseEmailTemplateForm
(
forms
.
ModelForm
):
# pylint: disable=incomplete-protocol
class
CourseEmailTemplateForm
(
forms
.
ModelForm
):
"""Form providing validation of CourseEmail templates."""
name
=
forms
.
CharField
(
required
=
False
)
...
...
@@ -73,7 +73,7 @@ class CourseEmailTemplateForm(forms.ModelForm): # pylint: disable=incomplete-pr
return
name
class
CourseAuthorizationAdminForm
(
forms
.
ModelForm
):
# pylint: disable=incomplete-protocol
class
CourseAuthorizationAdminForm
(
forms
.
ModelForm
):
"""Input form for email enabling, allowing us to verify data."""
class
Meta
:
# pylint: disable=missing-docstring
...
...
lms/djangoapps/dashboard/models.py
View file @
e17504d7
...
...
@@ -6,8 +6,6 @@ from xmodule.modulestore.mongoengine_fields import CourseKeyField
class
CourseImportLog
(
mongoengine
.
Document
):
"""Mongoengine model for git log"""
# pylint: disable=incomplete-protocol
course_id
=
CourseKeyField
(
max_length
=
128
)
# NOTE: this location is not a Location object but a pathname
location
=
mongoengine
.
StringField
(
max_length
=
168
)
...
...
lms/djangoapps/dashboard/support.py
View file @
e17504d7
...
...
@@ -18,7 +18,7 @@ from opaque_keys.edx.locations import SlashSeparatedCourseKey
log
=
logging
.
getLogger
(
__name__
)
class
RefundForm
(
forms
.
Form
):
# pylint: disable=incomplete-protocol
class
RefundForm
(
forms
.
Form
):
"""
Form for manual refunds
"""
...
...
lms/djangoapps/notes/api.py
View file @
e17504d7
...
...
@@ -163,7 +163,7 @@ def read(request, _course_key, note_id):
return
ApiResponse
(
http_response
=
HttpResponse
(),
data
=
note
.
as_dict
())
def
update
(
request
,
course_key
,
note_id
):
# pylint: disable=unused-argument
(course_key)
def
update
(
request
,
course_key
,
note_id
):
# pylint: disable=unused-argument
'''
Updates an annotation object and returns a 303 with the read location.
'''
...
...
@@ -247,7 +247,7 @@ def search(request, course_key):
return
ApiResponse
(
http_response
=
HttpResponse
(),
data
=
result
)
def
root
(
request
,
course_key
):
# pylint: disable=unused-argument
(course_key, request)
def
root
(
request
,
course_key
):
# pylint: disable=unused-argument
'''
Returns version information about the API.
'''
...
...
lms/djangoapps/survey/admin.py
View file @
e17504d7
...
...
@@ -7,7 +7,7 @@ from django.contrib import admin
from
survey.models
import
SurveyForm
class
SurveyFormAdminForm
(
forms
.
ModelForm
):
# pylint: disable=incomplete-protocol
class
SurveyFormAdminForm
(
forms
.
ModelForm
):
"""Form providing validation of SurveyForm content."""
class
Meta
:
# pylint: disable=missing-docstring
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment