Global setting for asynchronous ajax calls - to overcome firefox's strictness…

Global setting for asynchronous ajax calls - to overcome firefox's strictness about using synchronous ajax with credentials

common/lib/xblock/discussion/discussion_forum/static/js/discussion_course.js

@@ -9,6 +9,7 @@ function DiscussionCourseBlock(runtime, element) {
     var hostname = testUrl.match(/^(.*:\/\/[a-z\-.]+)\//)[1];
     DiscussionUtil.setBaseUrl(hostname);
     DiscussionUtil.localUrls.push('user_profile');
+    DiscussionUtil.force_async = true;
     pushState = false
   }
 

common/lib/xblock/discussion/discussion_forum/static/js/discussion_inline.js

@@ -7,10 +7,8 @@ function DiscussionInlineBlock(runtime, element) {
   if (testUrl.match(/^(http|https):\/\//)) {
     var hostname = testUrl.match(/^(.*:\/\/[a-z0-9:\-.]+)\//)[1];
     DiscussionUtil.setBaseUrl(hostname);
+    DiscussionUtil.force_async = true;
   }
 
-  new DiscussionModuleView({
-    el: el,
-    async_thread_views: true
-  });
+  new DiscussionModuleView({ el: el });
 }

common/static/coffee/src/discussion/discussion_module_view.coffee

@@ -99,7 +99,6 @@ if Backbone?
         @$el.append($discussion)
 
       @newPostForm = $('.new-post-article')
-      async = @options.async_thread_views
       @threadviews = @discussion.map (thread) =>
         view = new DiscussionThreadView(
           el: @$("article#thread_#{thread.id}"),

common/static/coffee/src/discussion/utils.coffee

@@ -18,6 +18,8 @@ class @DiscussionUtil
 
   @localUrls: []
 
+  @force_async = false
+
   @getTemplate: (id) ->
     $("script##{id}").html()
 
@@ -161,6 +163,9 @@ class @DiscussionUtil
       else
         params["$loading"].loading(params["takeFocus"])
 
+    if @force_async
+      params["async"] = true
+
     request = $.ajax(params).always ->
       if $elem
         $elem.removeAttr("disabled")

common/static/coffee/src/discussion/views/discussion_thread_edit_view.coffee

@@ -60,7 +60,9 @@ if Backbone?
           url: DiscussionUtil.urlFor('update_thread', @model.id),
           type: 'POST',
           dataType: 'json',
-          async: false, # @TODO when the rest of the stuff below is made to work properly..
+          # TODO when the rest of the stuff below is made to work properly.
+          # Note it can be forced to true on global basis via DiscussionUtils.force_async
+          async: false,
           data: postData,
           error: DiscussionUtil.formErrorHandler(@$('.post-errors')),
           success: =>

common/static/coffee/src/discussion/views/discussion_thread_view.coffee

@@ -22,8 +22,6 @@ if Backbone?
       if @mode not in ["tab", "inline"]
         throw new Error("invalid mode: " + @mode)
 
-      @async_thread_views = if options.async_thread_views? then options.async_thread_views else false
-
       # Quick fix to have an actual model when we're receiving new models from
       # the server.
       @model.collection.on "reset", (collection) =>
@@ -225,7 +223,7 @@ if Backbone?
 
     renderResponseToList: (response, listSelector, options) =>
         response.set('thread', @model)
-        view = new ThreadResponseView($.extend({model: response, async: @async_thread_views}, options))
+        view = new ThreadResponseView($.extend({model: response}, options))
         view.on "comment:add", @addComment
         view.on "comment:endorse", @endorseThread
         view.render()

common/static/coffee/src/discussion/views/new_post_view.coffee

@@ -81,7 +81,9 @@ if Backbone?
               url: url
               type: "POST"
               dataType: 'json'
-              async: false # TODO when the rest of the stuff below is made to work properly..
+              # TODO when the rest of the stuff below is made to work properly..
+              # Note it can be forced to true on global basis via DiscussionUtils.force_async
+              async: false
               data:
                   thread_type: thread_type
                   title: title

common/static/coffee/src/discussion/views/thread_response_view.coffee

@@ -12,7 +12,6 @@ if Backbone?
 
     initialize: (options) ->
       @collapseComments = options.collapseComments
-      @async = if options.async? then options.async else false;
       @createShowView()
 
     renderTemplate: ->
@@ -198,7 +197,9 @@ if Backbone?
           url: url
           type: "POST"
           dataType: 'json'
-          async: @async # TODO when the rest of the stuff below is made to work properly..
+          # TODO when the rest of the stuff below is made to work properly..
+          # Note it can be forced to true on global basis via DiscussionUtils.force_async
+          async: false
           data:
               body: newBody
           error: DiscussionUtil.formErrorHandler(@$(".edit-post-form-errors"))