Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
de3c8027
Commit
de3c8027
authored
Jul 13, 2017
by
Matthew Piatetsky
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not count programs with no courses as completed
LEARNER-1143
parent
be3c29b0
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletions
+10
-1
openedx/core/djangoapps/programs/tests/test_utils.py
+8
-0
openedx/core/djangoapps/programs/utils.py
+2
-1
No files found.
openedx/core/djangoapps/programs/tests/test_utils.py
View file @
de3c8027
...
...
@@ -445,6 +445,14 @@ class TestProgramProgressMeter(TestCase):
)
self
.
assertEqual
(
meter
.
completed_programs
,
[
program_uuid
])
def
test_empty_programs
(
self
,
mock_get_programs
):
"""Verify that programs with no courses do not count as completed."""
program
=
ProgramFactory
()
program
[
'courses'
]
=
[]
meter
=
ProgramProgressMeter
(
self
.
user
)
program_complete
=
meter
.
_is_program_complete
(
program
)
self
.
assertFalse
(
program_complete
)
@mock.patch
(
UTILS_MODULE
+
'.ProgramProgressMeter.completed_course_runs'
,
new_callable
=
mock
.
PropertyMock
)
def
test_completed_programs
(
self
,
mock_completed_course_runs
,
mock_get_programs
):
"""Verify that completed programs are correctly identified."""
...
...
openedx/core/djangoapps/programs/utils.py
View file @
de3c8027
...
...
@@ -244,7 +244,8 @@ class ProgramProgressMeter(object):
Returns:
bool, indicating whether the program is complete.
"""
return
all
(
self
.
_is_course_complete
(
course
)
for
course
in
program
[
'courses'
])
return
all
(
self
.
_is_course_complete
(
course
)
for
course
in
program
[
'courses'
])
\
and
len
(
program
[
'courses'
])
>
0
def
_is_course_complete
(
self
,
course
):
"""Check if a user has completed a course.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment