Commit d981f98b by David Baumgold

Merge pull request #5814 from edx/disable-pylint-todo-comments

Pylint: ignore TODO comments
parents dd38f523 9902dcb1
...@@ -30,7 +30,9 @@ def run_pylint(options): ...@@ -30,7 +30,9 @@ def run_pylint(options):
# This makes the folder if it doesn't already exist. # This makes the folder if it doesn't already exist.
report_dir = (Env.REPORT_DIR / system).makedirs_p() report_dir = (Env.REPORT_DIR / system).makedirs_p()
flags = '-E' if errors else '' flags = []
if errors:
flags.append("--errors-only")
apps = [system] apps = [system]
...@@ -51,7 +53,7 @@ def run_pylint(options): ...@@ -51,7 +53,7 @@ def run_pylint(options):
"{pythonpath_prefix} pylint {flags} -f parseable {apps} | " "{pythonpath_prefix} pylint {flags} -f parseable {apps} | "
"tee {report_dir}/pylint.report".format( "tee {report_dir}/pylint.report".format(
pythonpath_prefix=pythonpath_prefix, pythonpath_prefix=pythonpath_prefix,
flags=flags, flags=" ".join(flags),
apps=apps_list, apps=apps_list,
report_dir=report_dir report_dir=report_dir
) )
...@@ -182,12 +184,15 @@ def run_quality(options): ...@@ -182,12 +184,15 @@ def run_quality(options):
try: try:
sh( sh(
"{pythonpath_prefix} diff-quality --violations=pylint {pylint_reports} {percentage_string} " "{pythonpath_prefix} diff-quality --violations=pylint "
"--html-report {dquality_dir}/diff_quality_pylint.html".format( "{pylint_reports} {percentage_string} "
"--html-report {dquality_dir}/diff_quality_pylint.html "
"--options='{pylint_options}'".format(
pythonpath_prefix=pythonpath_prefix, pythonpath_prefix=pythonpath_prefix,
pylint_reports=pylint_reports, pylint_reports=pylint_reports,
percentage_string=percentage_string, percentage_string=percentage_string,
dquality_dir=dquality_dir dquality_dir=dquality_dir,
pylint_options="--disable=fixme",
) )
) )
except BuildFailure, error_message: except BuildFailure, error_message:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment