Fix for flaky TeamDiscussionView js tests
After being able to reproduce the errors exactly by making certain elements unfindable, I concluded that the issues we've been seeing on headless jenkins runs are due to execution happening too quickly and elements not loading in time to be interacted with. The fix is to make liberal use of Jasmine 1.3 `runs` and `waitsFor` functionality, to ensure that execution happens in the order that we want, with rendering being checked before proceeding. Once again, I can't be 100% sure that this fixes the Jenkins errors, as those are very hard to reliably reproduce, but this is an educated guess at fixing the problem with no drawbacks, as I've been able to successfully run all tests locally.
Showing
This diff is collapsed.
Click to expand it.
Please
register
or
sign in
to comment