Commit d507ac6c by Rocky Duan

should be like this

parent 8bf4bc2d
...@@ -43,10 +43,12 @@ def render_discussion(request, course_id, threads, discussion_id=None, \ ...@@ -43,10 +43,12 @@ def render_discussion(request, course_id, threads, discussion_id=None, \
'forum': 'discussion/_forum.html', 'forum': 'discussion/_forum.html',
}[discussion_type] }[discussion_type]
base_url = { """base_url = {
'inline': (lambda: reverse('django_comment_client.forum.views.inline_discussion', args=[course_id, discussion_id])), 'inline': (lambda: reverse('django_comment_client.forum.views.inline_discussion', args=[course_id, discussion_id])),
'forum': (lambda: reverse('django_comment_client.forum.views.forum_form_discussion', args=[course_id, discussion_id])), 'forum': (lambda: reverse('django_comment_client.forum.views.forum_form_discussion', args=[course_id, discussion_id])),
}[discussion_type]() }[discussion_type]()"""
base_url = reverse('django_comment_client.forum.views.inline_discussion', args=[course_id, discussion_id])
annotated_content_info = {thread['id']: get_annotated_content_info(thread, request.user.id) for thread in threads} annotated_content_info = {thread['id']: get_annotated_content_info(thread, request.user.id) for thread in threads}
...@@ -69,7 +71,7 @@ def render_inline_discussion(*args, **kwargs): ...@@ -69,7 +71,7 @@ def render_inline_discussion(*args, **kwargs):
return render_discussion(discussion_type='inline', *args, **kwargs) return render_discussion(discussion_type='inline', *args, **kwargs)
def render_forum_discussion(*args, **kwargs): def render_forum_discussion(*args, **kwargs):
return render_discussion(discussion_type='inline', *args, **kwargs) # make everything inline for now return render_discussion(discussion_type='forum', *args, **kwargs)
def get_threads(request, course_id, discussion_id): def get_threads(request, course_id, discussion_id):
query_params = { query_params = {
......
...@@ -13,8 +13,8 @@ ...@@ -13,8 +13,8 @@
<label for="discussion-search-within-board-${discussion_id}" class="discussion-search-within-board">Search within board</label> <label for="discussion-search-within-board-${discussion_id}" class="discussion-search-within-board">Search within board</label>
</div> </div>
<div class="discussion-new-post control-button" href="javascript:void(0)">New Post</div> <div class="discussion-new-post control-button" href="javascript:void(0)">New Post</div>
<%include file="_sort.html" />
</div> </div>
<%include file="_sort.html" />
<div class="threads"> <div class="threads">
% for thread in threads: % for thread in threads:
${renderer.render_thread(course_id, thread, show_comments=False)} ${renderer.render_thread(course_id, thread, show_comments=False)}
......
...@@ -9,11 +9,7 @@ ...@@ -9,11 +9,7 @@
%> %>
<%def name="link_to_page(_page, text)"> <%def name="link_to_page(_page, text)">
% if discussion_type == 'inline': <a class="discussion-page-link discussion-inline-page-link" href="javascript:void(0)" page-url="${url_for_page(_page)}">${text}</a>
<a class="discussion-page-link discussion-inline-page-link" href="javascript:void(0)" page-url="${url_for_page(_page)}">${text}</a>
% else:
<a class="discussion-page-link" href="${url_for_page(_page)}">${text}</a>
% endif
</%def> </%def>
<%def name="div_page(_page)"> <%def name="div_page(_page)">
......
...@@ -20,11 +20,7 @@ ...@@ -20,11 +20,7 @@
def url_for_sort(key, order): def url_for_sort(key, order):
return base_url + '?' + urlencode(merge(query_params, {'page': 1, 'sort_key': key, 'sort_order': order})) return base_url + '?' + urlencode(merge(query_params, {'page': 1, 'sort_key': key, 'sort_order': order}))
%> %>
% if discussion_type == 'inline': <a class="discussion-sort-link discussion-inline-sort-link ${cls}" href="javascript:void(0)" sort-url="${url_for_sort(key, order)}">${title}</a>
<a class="discussion-sort-link discussion-inline-sort-link ${cls}" href="javascript:void(0)" sort-url="${url_for_sort(key, order)}">${title}</a>
% else:
<a class="discussion-sort-link ${cls}" href="${url_for_sort(key, order)}">${title}</a>
% endif
</%def> </%def>
<div class="discussion-sort"> <div class="discussion-sort">
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment