Skip to content

E
edx-platform
Commit cb034d4f by Uman Shahzad
Options

Implement client-side registration form validation. 

Input forms that need validation will have AJAX requests
performed to get validation decisions live.

All but a few important and common form fields perform
generic validation; these will need a back-end handler
in the future in order to have them validated through AJAX requests.

Information is conveyed on focus and blur for both
errors and successes.
parent 39ac333b
Showing with 513 additions and 266 deletions
common/djangoapps/student/tests/test_create_account.py
...@@ -22,7 +22,9 @@ from notification_prefs import NOTIFICATION_PREF_KEY ...@@ -22,7 +22,9 @@ from notification_prefs import NOTIFICATION_PREF_KEY
from openedx.core.djangoapps.external_auth.models import ExternalAuthMap from openedx.core.djangoapps.external_auth.models import ExternalAuthMap
from openedx.core.djangoapps.lang_pref import LANGUAGE_KEY from openedx.core.djangoapps.lang_pref import LANGUAGE_KEY
from openedx.core.djangoapps.site_configuration.tests.mixins import SiteMixin from openedx.core.djangoapps.site_configuration.tests.mixins import SiteMixin
from openedx.core.djangoapps.user_api.accounts import USERNAME_INVALID_CHARS_ASCII, USERNAME_INVALID_CHARS_UNICODE from openedx.core.djangoapps.user_api.accounts import (
USERNAME_BAD_LENGTH_MSG, USERNAME_INVALID_CHARS_ASCII, USERNAME_INVALID_CHARS_UNICODE
)
from openedx.core.djangoapps.user_api.preferences.api import get_user_preference from openedx.core.djangoapps.user_api.preferences.api import get_user_preference
from student.models import UserAttribute from student.models import UserAttribute
from student.views import REGISTRATION_AFFILIATE_ID, REGISTRATION_UTM_CREATED_AT, REGISTRATION_UTM_PARAMETERS from student.views import REGISTRATION_AFFILIATE_ID, REGISTRATION_UTM_CREATED_AT, REGISTRATION_UTM_PARAMETERS
...@@ -476,16 +478,16 @@ class TestCreateAccountValidation(TestCase): ...@@ -476,16 +478,16 @@ class TestCreateAccountValidation(TestCase):
# Missing # Missing
del params["username"] del params["username"]
assert_username_error("Username must be minimum of two characters long") assert_username_error(USERNAME_BAD_LENGTH_MSG)
# Empty, too short # Empty, too short
for username in ["", "a"]: for username in ["", "a"]:
params["username"] = username params["username"] = username
assert_username_error("Username must be minimum of two characters long") assert_username_error(USERNAME_BAD_LENGTH_MSG)
# Too long # Too long
params["username"] = "this_username_has_31_characters" params["username"] = "this_username_has_31_characters"
assert_username_error("Username cannot be more than 30 characters long") assert_username_error(USERNAME_BAD_LENGTH_MSG)
# Invalid # Invalid
params["username"] = "invalid username" params["username"] = "invalid username"
......
common/djangoapps/student/tests/test_long_username_email.py
...@@ -5,6 +5,8 @@ import json ...@@ -5,6 +5,8 @@ import json
from django.core.urlresolvers import reverse from django.core.urlresolvers import reverse
from django.test import TestCase from django.test import TestCase
from openedx.core.djangoapps.user_api.accounts import USERNAME_BAD_LENGTH_MSG
class TestLongUsernameEmail(TestCase): class TestLongUsernameEmail(TestCase):
...@@ -34,7 +36,7 @@ class TestLongUsernameEmail(TestCase): ...@@ -34,7 +36,7 @@ class TestLongUsernameEmail(TestCase):
obj = json.loads(response.content) obj = json.loads(response.content)
self.assertEqual( self.assertEqual(
obj['value'], obj['value'],
"Username cannot be more than 30 characters long", USERNAME_BAD_LENGTH_MSG,
) )
def test_long_email(self): def test_long_email(self):
......
common/static/common/js/utils/edx.utils.validate.js
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
var _fn = { var _fn = {
validate: { validate: {
template: _.template('<li><%= content %></li>'), template: _.template('<li id="<%- id %>-validation-error-container"><%- content %></li>'),
msg: { msg: {
email: gettext("The email address you've provided isn't formatted correctly."), email: gettext("The email address you've provided isn't formatted correctly."),
...@@ -32,6 +32,7 @@ ...@@ -32,6 +32,7 @@
field: function(el) { field: function(el) {
var $el = $(el), var $el = $(el),
id = $el.attr('id'),
required = true, required = true,
min = true, min = true,
max = true, max = true,
...@@ -66,6 +67,8 @@ ...@@ -66,6 +67,8 @@
}); });
} }
response.id = id;
return response; return response;
}, },
...@@ -107,7 +110,7 @@ ...@@ -107,7 +110,7 @@
regex: new RegExp( regex: new RegExp(
[ [
'(^[-!#$%&\'*+/=?^_`{}|~0-9A-Z]+(\\.[-!#$%&\'*+/=?^_`{}|~0-9A-Z]+)*', '(^[-!#$%&\'*+/=?^_`{}|~0-9A-Z]+(\\.[-!#$%&\'*+/=?^_`{}|~0-9A-Z]+)*',
'|^"([\\001-\\010\\013\\014\\016-\\037!#-\\[\\]-\\177]|\\\\[\\001-\\011\\013\\014\\016-\\177])*"', '|^"([\\001-\\010\\013\\014\\016-\\037!#-\\[\\]-\\177]|\\\\[\\001-\\011\\013\\014\\016-\\177])*"', // eslint-disable-line max-len
')@((?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\\.)+[A-Z]{2,6}\\.?$)', ')@((?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\\.)+[A-Z]{2,6}\\.?$)',
'|\\[(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)(\\.(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)){3}\\]$' '|\\[(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)(\\.(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)){3}\\]$'
].join(''), 'i' ].join(''), 'i'
...@@ -124,7 +127,7 @@ ...@@ -124,7 +127,7 @@
getLabel: function(id) { getLabel: function(id) {
// Extract the field label, remove the asterisk (if it appears) and any extra whitespace // Extract the field label, remove the asterisk (if it appears) and any extra whitespace
return $('label[for=' + id + ']').text().split('*')[0].trim(); return $('label[for=' + id + '] > span.label-text').text().split('*')[0].trim();
}, },
getMessage: function($el, tests) { getMessage: function($el, tests) {
...@@ -154,7 +157,10 @@ ...@@ -154,7 +157,10 @@
content = _.sprintf(_fn.validate.msg[key], context); content = _.sprintf(_fn.validate.msg[key], context);
} }
txt.push(_fn.validate.template({content: content})); txt.push(_fn.validate.template({
content: content,
id: $el.attr('id')
}));
} }
}); });
...@@ -173,7 +179,7 @@ ...@@ -173,7 +179,7 @@
return { return {
validate: _fn.validate.field validate: _fn.validate.field
}; };
})(); }());
return utils; return utils;
}); });
......
common/test/acceptance/tests/lms/test_lms.py
...@@ -344,10 +344,7 @@ class RegisterFromCombinedPageTest(UniqueCourseTest): ...@@ -344,10 +344,7 @@ class RegisterFromCombinedPageTest(UniqueCourseTest):
# Verify that the expected errors are displayed. # Verify that the expected errors are displayed.
errors = self.register_page.wait_for_errors() errors = self.register_page.wait_for_errors()
self.assertIn(u'Please enter your Public Username.', errors) self.assertIn(u'Please enter your Public Username.', errors)
self.assertIn( self.assertIn(u'You must agree to the édX Terms of Service and Honor Code', errors)
u'You must agree to the édX Terms of Service and Honor Code',
errors
)
self.assertIn(u'Please select your Country.', errors) self.assertIn(u'Please select your Country.', errors)
self.assertIn(u'Please tell us your favorite movie.', errors) self.assertIn(u'Please tell us your favorite movie.', errors)
......
conf/locale/en/LC_MESSAGES/django.po
...@@ -331,31 +331,6 @@ msgid "User profile" ...@@ -331,31 +331,6 @@ msgid "User profile"
msgstr "" msgstr ""
#: common/djangoapps/student/forms.py #: common/djangoapps/student/forms.py
msgid "Username must be minimum of two characters long"
msgstr ""
#: common/djangoapps/student/forms.py
#, python-format
msgid "Username cannot be more than %(limit_value)s characters long"
msgstr ""
#. Translators: This message is shown when the Unicode usernames are NOT
#. allowed
#: common/djangoapps/student/forms.py
msgid ""
"Usernames can only contain Roman letters, western numerals (0-9), "
"underscores (_), and hyphens (-)."
msgstr ""
#. Translators: This message is shown only when the Unicode usernames are
#. allowed
#: common/djangoapps/student/forms.py
msgid ""
"Usernames can only contain letters, numerals, underscore (_), numbers and "
"@/./+/-/_ characters."
msgstr ""
#: common/djangoapps/student/forms.py
msgid "" msgid ""
"That e-mail address doesn't have an associated user account. Are you sure " "That e-mail address doesn't have an associated user account. Are you sure "
"you've registered?" "you've registered?"
...@@ -9288,23 +9263,83 @@ msgstr "" ...@@ -9288,23 +9263,83 @@ msgstr ""
msgid "Enable course home page improvements." msgid "Enable course home page improvements."
msgstr "" msgstr ""
#: openedx/core/djangoapps/theming/views.py #: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid ""
"Usernames can only contain letters (A-Z, a-z), numerals (0-9), underscores "
"(_), and hyphens (-)."
msgstr ""
#: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid ""
"Usernames can only contain letters, numerals, and @/./+/-/_ characters."
msgstr ""
#. Translators: This message is shown to users who attempt to create a new
#. account using
#. an invalid email format.
#: openedx/core/djangoapps/user_api/accounts/__init__.py
#, python-brace-format #, python-brace-format
msgid "Site theme changed to {site_theme}" msgid "\"{email}\" is not a valid email address."
msgstr "" msgstr ""
#: openedx/core/djangoapps/theming/views.py #: openedx/core/djangoapps/user_api/accounts/__init__.py
#, python-brace-format #, python-brace-format
msgid "Theme {site_theme} does not exist" msgid ""
"It looks like {email_address} belongs to an existing account. Try again with"
" a different email address."
msgstr "" msgstr ""
#: openedx/core/djangoapps/theming/views.py #: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid "Site theme reverted to the default" #, python-brace-format
msgid ""
"It looks like {username} belongs to an existing account. Try again with a "
"different username."
msgstr "" msgstr ""
#: openedx/core/djangoapps/theming/views.py #. Translators: This message is shown to users who enter a
#: openedx/core/djangoapps/theming/templates/theming/theming-admin-fragment.html #. username/email/password
msgid "Theming Administration" #. with an inappropriate length (too short or too long).
#: openedx/core/djangoapps/user_api/accounts/__init__.py
#, python-brace-format
msgid "Username must be between {min} and {max} characters long."
msgstr ""
#: openedx/core/djangoapps/user_api/accounts/__init__.py
#, python-brace-format
msgid "Enter a valid email address that contains at least {min} characters."
msgstr ""
#: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid "Please enter a password."
msgstr ""
#: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid "Password is not long enough."
msgstr ""
#: openedx/core/djangoapps/user_api/accounts/__init__.py
#, python-brace-format
msgid "Password cannot be longer than {max} character."
msgstr ""
#. Translators: This message is shown to users who enter a password matching
#. the username they enter(ed).
#: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid "Password cannot be the same as the username."
msgstr ""
#. Translators: These messages are shown to users who do not enter information
#. into the required field or enter it incorrectly.
#: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid "Please enter your Full Name."
msgstr ""
#: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid "The email addresses do not match."
msgstr ""
#: openedx/core/djangoapps/user_api/accounts/__init__.py
msgid "Please select your Country."
msgstr "" msgstr ""
#: openedx/core/djangoapps/user_api/accounts/api.py #: openedx/core/djangoapps/user_api/accounts/api.py
...@@ -9392,24 +9427,6 @@ msgstr "" ...@@ -9392,24 +9427,6 @@ msgstr ""
msgid "Remember me" msgid "Remember me"
msgstr "" msgstr ""
#. Translators: This message is shown to users who attempt to create a new
#. account using an email address associated with an existing account.
#: openedx/core/djangoapps/user_api/views.py
#, python-brace-format
msgid ""
"It looks like {email_address} belongs to an existing account. Try again with"
" a different email address."
msgstr ""
#. Translators: This message is shown to users who attempt to create a new
#. account using a username associated with an existing account.
#: openedx/core/djangoapps/user_api/views.py
#, python-brace-format
msgid ""
"It looks like {username} belongs to an existing account. Try again with a "
"different username."
msgstr ""
#. Translators: These instructions appear on the registration form, #. Translators: These instructions appear on the registration form,
#. immediately #. immediately
#. below a field meant to hold the user's email address. #. below a field meant to hold the user's email address.
...@@ -9423,10 +9440,6 @@ msgstr "" ...@@ -9423,10 +9440,6 @@ msgstr ""
msgid "Confirm Email" msgid "Confirm Email"
msgstr "" msgstr ""
#: openedx/core/djangoapps/user_api/views.py
msgid "The email addresses do not match."
msgstr ""
#. Translators: This example name is used as a placeholder in #. Translators: This example name is used as a placeholder in
#. a field on the registration form meant to hold the user's name. #. a field on the registration form meant to hold the user's name.
#: openedx/core/djangoapps/user_api/views.py #: openedx/core/djangoapps/user_api/views.py
...@@ -9506,10 +9519,6 @@ msgid "Company" ...@@ -9506,10 +9519,6 @@ msgid "Company"
msgstr "" msgstr ""
#: openedx/core/djangoapps/user_api/views.py #: openedx/core/djangoapps/user_api/views.py
msgid "Please select your Country."
msgstr ""
#: openedx/core/djangoapps/user_api/views.py
msgid "Review the Honor Code" msgid "Review the Honor Code"
msgstr "" msgstr ""
......
conf/locale/en/LC_MESSAGES/djangojs.po
...@@ -4219,6 +4219,10 @@ msgid "We couldn't create your account." ...@@ -4219,6 +4219,10 @@ msgid "We couldn't create your account."
msgstr "" msgstr ""
#: lms/static/js/student_account/views/RegisterView.js #: lms/static/js/student_account/views/RegisterView.js
msgid "(required)"
msgstr ""
#: lms/static/js/student_account/views/RegisterView.js
msgid "You've successfully signed into %(currentProvider)s." msgid "You've successfully signed into %(currentProvider)s."
msgstr "" msgstr ""
......
lms/static/js/student_account/tos_modal.js
...@@ -79,6 +79,7 @@ ...@@ -79,6 +79,7 @@
var buildIframe = function(link, modalSelector, contentSelector, tosLinkSelector) { var buildIframe = function(link, modalSelector, contentSelector, tosLinkSelector) {
// Create an iframe with contents from the link and set its height to match the content area // Create an iframe with contents from the link and set its height to match the content area
return $('<iframe>', { return $('<iframe>', {
title: 'Terms of Service and Honor Code',
src: link.href, src: link.href,
load: function() { load: function() {
var $iframeHead = $(this).contents().find('head'), var $iframeHead = $(this).contents().find('head'),
......
lms/static/js/student_account/views/FormView.js
...@@ -6,43 +6,30 @@ ...@@ -6,43 +6,30 @@
'backbone', 'backbone',
'common/js/utils/edx.utils.validate', 'common/js/utils/edx.utils.validate',
'edx-ui-toolkit/js/utils/html-utils', 'edx-ui-toolkit/js/utils/html-utils',
'edx-ui-toolkit/js/utils/string-utils',
'text!templates/student_account/form_errors.underscore' 'text!templates/student_account/form_errors.underscore'
], ], function($, _, Backbone, EdxUtilsValidate, HtmlUtils, StringUtils, formErrorsTpl) {
function($, _, Backbone, EdxUtilsValidate, HtmlUtils, formErrorsTpl) {
return Backbone.View.extend({ return Backbone.View.extend({
tagName: 'form', tagName: 'form',
el: '', el: '',
tpl: '', tpl: '',
fieldTpl: '#form_field-tpl', fieldTpl: '#form_field-tpl',
formErrorsTpl: formErrorsTpl, formErrorsTpl: formErrorsTpl,
formErrorsJsHook: 'js-form-errors', formErrorsJsHook: 'js-form-errors',
defaultFormErrorsTitle: gettext('An error occurred.'), defaultFormErrorsTitle: gettext('An error occurred.'),
events: {}, events: {},
errors: [], errors: [],
formType: '', formType: '',
$form: {}, $form: {},
fields: [], fields: [],
liveValidationFields: [],
// String to append to required label fields // String to append to required label fields
requiredStr: '', requiredStr: '',
/* /*
Translators: This string is appended to optional field labels on the student login, registration, and Translators: This string is appended to optional field labels on the student login, registration, and
profile forms. profile forms.
*/ */
optionalStr: gettext('(optional)'), optionalStr: gettext('(optional)'),
submitButton: '', submitButton: '',
initialize: function(data) { initialize: function(data) {
...@@ -157,7 +144,7 @@ ...@@ -157,7 +144,7 @@
$label, $label,
key = '', key = '',
errors = [], errors = [],
test = {}; validation = {};
for (i = 0; i < len; i++) { for (i = 0; i < len; i++) {
$el = $(elements[i]); $el = $(elements[i]);
...@@ -171,13 +158,13 @@ ...@@ -171,13 +158,13 @@
} }
if (key) { if (key) {
test = this.validate(elements[i]); validation = this.validate(elements[i]);
if (test.isValid) { if (validation.isValid) {
obj[key] = $el.attr('type') === 'checkbox' ? $el.is(':checked') : $el.val(); obj[key] = $el.attr('type') === 'checkbox' ? $el.is(':checked') : $el.val();
$el.removeClass('error'); $el.removeClass('error');
$label.removeClass('error'); $label.removeClass('error');
} else { } else {
errors.push(test.message); errors.push(validation.message);
$el.addClass('error'); $el.addClass('error');
$label.addClass('error'); $label.addClass('error');
} }
...@@ -190,7 +177,13 @@ ...@@ -190,7 +177,13 @@
}, },
saveError: function(error) { saveError: function(error) {
this.errors = ['<li>' + error.responseText + '</li>']; this.errors = [
StringUtils.interpolate(
'<li>{error}</li>', {
error: error.responseText
}
)
];
this.renderErrors(this.defaultFormErrorsTitle, this.errors); this.renderErrors(this.defaultFormErrorsTitle, this.errors);
this.toggleDisableButton(false); this.toggleDisableButton(false);
}, },
...@@ -201,24 +194,48 @@ ...@@ -201,24 +194,48 @@
renderErrors: function(title, errorMessages) { renderErrors: function(title, errorMessages) {
this.clearFormErrors(); this.clearFormErrors();
this.renderFormFeedback(this.formErrorsTpl, { if (title || errorMessages.length) {
jsHook: this.formErrorsJsHook, this.renderFormFeedback(this.formErrorsTpl, {
title: title, jsHook: this.formErrorsJsHook,
messagesHtml: HtmlUtils.HTML(errorMessages.join('')) title: title,
}); messagesHtml: HtmlUtils.HTML(errorMessages.join(''))
});
}
}, },
renderFormFeedback: function(template, context) { renderFormFeedback: function(template, context) {
var tpl = HtmlUtils.template(template); var tpl = HtmlUtils.template(template);
HtmlUtils.prepend(this.$formFeedback, tpl(context)); HtmlUtils.prepend(this.$formFeedback, tpl(context));
},
// Scroll to feedback container doOnErrorList: function(id, action) {
$('html,body').animate({ var i;
scrollTop: this.$formFeedback.offset().top for (i = 0; i < this.errors.length; ++i) {
}, 'slow'); if (this.errors[i].includes(id)) {
action(i);
}
}
},
updateError: function(error, id) {
this.deleteError(id);
this.addError(error, id);
},
deleteError: function(id) {
var self = this;
this.doOnErrorList(id, function(index) {
self.errors.splice(index, 1);
});
},
// Focus on the feedback container to ensure screen readers see the messages. addError: function(error, id) {
this.$formFeedback.focus(); this.errors.push(StringUtils.interpolate(
'<li id="{errorId}">{error}</li>', {
errorId: id,
error: error
}
));
}, },
/* Allows extended views to add non-form attributes /* Allows extended views to add non-form attributes
...@@ -244,6 +261,14 @@ ...@@ -244,6 +261,14 @@
this.clearFormErrors(); this.clearFormErrors();
} else { } else {
this.renderErrors(this.defaultFormErrorsTitle, this.errors); this.renderErrors(this.defaultFormErrorsTitle, this.errors);
// Scroll to feedback container
$('html,body').animate({
scrollTop: this.$formFeedback.offset().top
}, 'slow');
// Focus on the feedback container to ensure screen readers see the messages.
this.$formFeedback.focus();
this.toggleDisableButton(false); this.toggleDisableButton(false);
} }
...@@ -285,6 +310,29 @@ ...@@ -285,6 +310,29 @@
validate: function($el) { validate: function($el) {
return EdxUtilsValidate.validate($el); return EdxUtilsValidate.validate($el);
},
liveValidate: function($el, url, dataType, data, method, model) {
$.ajax({
url: url,
dataType: dataType,
data: data,
method: method,
success: function(response) {
model.trigger('validation', $el, response);
}
});
},
inLiveValidationFields: function($el) {
var i,
name = $el.attr('name') || false;
for (i = 0; i < this.liveValidationFields.length; ++i) {
if (this.liveValidationFields[i] === name) {
return true;
}
}
return false;
} }
}); });
}); });
......
lms/static/sass/views/_login-register.scss
...@@ -296,10 +296,6 @@ ...@@ -296,10 +296,6 @@
display: inline; display: inline;
} }
&.error {
color: $red;
}
&[for="register-data_sharing_consent"], &[for="register-data_sharing_consent"],
&[for="register-honor_code"], &[for="register-honor_code"],
&[for="register-terms_of_service"] { &[for="register-terms_of_service"] {
...@@ -365,7 +361,22 @@ ...@@ -365,7 +361,22 @@
} }
&.error { &.error {
border-color: $error-color; border-color: $red;
}
&.success {
border-color: $success-color-hover;
}
}
textarea,
select {
&.error {
outline-color: $red;
}
&.success {
outline-color: $success-color-hover;
} }
} }
...@@ -384,9 +395,16 @@ ...@@ -384,9 +395,16 @@
&:active, &:focus { &:active, &:focus {
outline: auto; outline: auto;
} }
}
span,
label {
&.error { &.error {
outline-color: $error-color; color: $red;
}
&.success {
color: $success-color-hover;
} }
} }
...@@ -394,6 +412,7 @@ ...@@ -394,6 +412,7 @@
@extend %t-copy-sub1; @extend %t-copy-sub1;
color: $uxpl-gray-base; color: $uxpl-gray-base;
} }
.tip { .tip {
display: block; display: block;
} }
......
lms/templates/student_account/form_field.underscore
<div class="form-field <%=type%>-<%= name %>"> <div class="form-field <%- type %>-<%- name %>">
<% if ( type !== 'checkbox' ) { %> <% if ( type !== 'checkbox' ) { %>
<label for="<%= form %>-<%= name %>"> <label for="<%- form %>-<%- name %>">
<span class="label-text"><%= label %></span> <span class="label-text"><%- label %></span>
<% if ( required && requiredStr && (type !== 'hidden') ) { %><span class="label-required"><%= requiredStr %></span><% } %> <% if ( required && type !== 'hidden' ) { %>
<% if ( !required && optionalStr && (type !== 'hidden') ) { %><span class="label-optional"><%= optionalStr %></span><% } %> <span id="<%- form %>-<%- name %>-required-label"
class="label-required <% if ( !requiredStr ) { %>hidden<% } %>">
<% if ( requiredStr ) { %><%- requiredStr %><% }%>
</span>
<span class="icon fa" id="<%- form %>-<%- name %>-validation-icon" aria-hidden="true"></span>
<% } %>
<% if ( !required && optionalStr && (type !== 'hidden') ) { %>
<span class="label-optional" id="<%- form %>-<%- name %>-optional-label"><%- optionalStr %></span>
<% } %>
</label> </label>
<% if (supplementalLink && supplementalText) { %> <% if (supplementalLink && supplementalText) { %>
<div class="supplemental-link"> <div class="supplemental-link">
...@@ -13,50 +21,59 @@ ...@@ -13,50 +21,59 @@
<% } %> <% } %>
<% if ( type === 'select' ) { %> <% if ( type === 'select' ) { %>
<select id="<%= form %>-<%= name %>" <select id="<%- form %>-<%- name %>"
name="<%= name %>" name="<%- name %>"
class="input-inline" class="input-inline"
<% if ( instructions ) { %> <% if ( instructions ) { %>
aria-describedby="<%= form %>-<%= name %>-desc" aria-describedby="<%- form %>-<%- name %>-desc <%- form %>-<%- name %>-validation-error"
<% } %> <% } %>
<% if ( typeof errorMessages !== 'undefined' ) { <% if ( typeof errorMessages !== 'undefined' ) {
_.each(errorMessages, function( msg, type ) {%> _.each(errorMessages, function( msg, type ) {%>
data-errormsg-<%= type %>="<%= msg %>" data-errormsg-<%- type %>="<%- msg %>"
<% }); <% });
} %> } %>
<% if ( required ) { %> aria-required="true" required<% } %>> <% if ( required ) { %> aria-required="true" required<% } %>
<% _.each(options, function(el) { %> >
<option value="<%= el.value%>"<% if ( el.default ) { %> data-isdefault="true" selected<% } %>><%= el.name %></option> <% _.each(options, function(el) { %>
<% }); %> <option value="<%- el.value%>"<% if ( el.default ) { %> data-isdefault="true" selected<% } %>><%- el.name %></option>
<% }); %>
</select> </select>
<% if ( instructions ) { %> <span class="tip tip-input" id="<%= form %>-<%= name %>-desc"><%= instructions %></span><% } %> <span id="<%- form %>-<%- name %>-validation-error" class="tip error" aria-live="assertive">
<span class="sr-only">ERROR: </span>
<span id="<%- form %>-<%- name %>-validation-error-msg"></span>
</span>
<% if ( instructions ) { %> <span class="tip tip-input" id="<%- form %>-<%- name %>-desc"><%- instructions %></span><% } %>
<% if (supplementalLink && supplementalText) { %> <% if (supplementalLink && supplementalText) { %>
<div class="supplemental-link"> <div class="supplemental-link">
<a href="<%- supplementalLink %>" target="_blank"><%- supplementalText %></a> <a href="<%- supplementalLink %>" target="_blank"><%- supplementalText %></a>
</div> </div>
<% } %> <% } %>
<% } else if ( type === 'textarea' ) { %> <% } else if ( type === 'textarea' ) { %>
<textarea id="<%= form %>-<%= name %>" <textarea id="<%- form %>-<%- name %>"
type="<%= type %>" type="<%- type %>"
name="<%= name %>" name="<%- name %>"
class="input-block" class="input-block"
<% if ( instructions ) { %> <% if ( instructions ) { %>
aria-describedby="<%= form %>-<%= name %>-desc" aria-describedby="<%- form %>-<%- name %>-desc <%- form %>-<%- name %>-validation-error"
<% } %> <% } %>
<% if ( restrictions.min_length ) { %> minlength="<%= restrictions.min_length %>"<% } %> <% if ( restrictions.min_length ) { %> minlength="<%- restrictions.min_length %>"<% } %>
<% if ( restrictions.max_length ) { %> maxlength="<%= restrictions.max_length %>"<% } %> <% if ( restrictions.max_length ) { %> maxlength="<%- restrictions.max_length %>"<% } %>
<% if ( typeof errorMessages !== 'undefined' ) { <% if ( typeof errorMessages !== 'undefined' ) {
_.each(errorMessages, function( msg, type ) {%> _.each(errorMessages, function( msg, type ) {%>
data-errormsg-<%= type %>="<%= msg %>" data-errormsg-<%- type %>="<%- msg %>"
<% }); <% });
} %> } %>
<% if ( required ) { %> aria-required="true" required<% } %> ></textarea> <% if ( required ) { %> aria-required="true" required<% } %>></textarea>
<% if ( instructions ) { %> <span class="tip tip-input" id="<%= form %>-<%= name %>-desc"><%= instructions %></span><% } %> <span id="<%- form %>-<%- name %>-validation-error" class="tip error" aria-live="assertive">
<% if (supplementalLink && supplementalText) { %> <span class="sr-only">ERROR: </span>
<div class="supplemental-link"> <span id="<%- form %>-<%- name %>-validation-error-msg"></span>
<a href="<%- supplementalLink %>" target="_blank"><%- supplementalText %></a> </span>
</div> <% if ( instructions ) { %> <span class="tip tip-input" id="<%- form %>-<%- name %>-desc"><%- instructions %></span><% } %>
<% } %> <% if (supplementalLink && supplementalText) { %>
<div class="supplemental-link">
<a href="<%- supplementalLink %>" target="_blank"><%- supplementalText %></a>
</div>
<% } %>
<% } else { %> <% } else { %>
<% if ( type === 'checkbox' ) { %> <% if ( type === 'checkbox' ) { %>
<% if (supplementalLink && supplementalText) { %> <% if (supplementalLink && supplementalText) { %>
...@@ -65,30 +82,44 @@ ...@@ -65,30 +82,44 @@
</div> </div>
<% } %> <% } %>
<% } %> <% } %>
<input id="<%= form %>-<%= name %>" <input id="<%- form %>-<%- name %>"
type="<%= type %>" type="<%- type %>"
name="<%= name %>" name="<%- name %>"
class="input-block <% if ( type === 'checkbox' ) { %>checkbox<% } %>" class="input-block <% if ( type === 'checkbox' ) { %>checkbox<% } %>"
<% if ( instructions ) { %> aria-describedby="<%= form %>-<%= name %>-desc" <% } %> <% if ( instructions ) { %>
<% if ( restrictions.min_length ) { %> minlength="<%= restrictions.min_length %>"<% } %> aria-describedby="<%- form %>-<%- name %>-desc <%- form %>-<%- name %>-validation-error"
<% if ( restrictions.max_length ) { %> maxlength="<%= restrictions.max_length %>"<% } %> <% } %>
<% if ( restrictions.min_length ) { %> minlength="<%- restrictions.min_length %>"<% } %>
<% if ( restrictions.max_length ) { %> maxlength="<%- restrictions.max_length %>"<% } %>
<% if ( required ) { %> required<% } %> <% if ( required ) { %> required<% } %>
<% if ( typeof errorMessages !== 'undefined' ) { <% if ( typeof errorMessages !== 'undefined' ) {
_.each(errorMessages, function( msg, type ) {%> _.each(errorMessages, function( msg, type ) {%>
data-errormsg-<%= type %>="<%= msg %>" data-errormsg-<%- type %>="<%- msg %>"
<% }); <% });
} %> } %>
<% if ( placeholder ) { %> placeholder="<%= placeholder %>"<% } %> <% if ( placeholder ) { %> placeholder="<%- placeholder %>"<% } %>
value="<%- defaultValue %>" value="<%- defaultValue %>"
/> />
<% if ( type === 'checkbox' ) { %> <% if ( type === 'checkbox' ) { %>
<label for="<%= form %>-<%= name %>"> <label for="<%- form %>-<%- name %>">
<span class="label-text"><%= label %></span> <span class="label-text"><%- label %></span>
<% if ( required && requiredStr ) { %><span class="label-required"><%= requiredStr %></span><% } %> <% if ( required && type !== 'hidden' ) { %>
<% if ( !required && optionalStr ) { %><span class="label-optional"><%= optionalStr %></span><% } %> <span id="<%- form %>-<%- name %>-required-label"
class="label-required <% if ( !requiredStr ) { %>hidden<% } %>">
<% if ( requiredStr ) { %><%- requiredStr %><% }%>
</span>
<span class="icon fa" id="<%- form %>-<%- name %>-validation-icon" aria-hidden="true"></span>
<% } %>
<% if ( !required && optionalStr ) { %>
<span class="label-optional" id="<%- form %>-<%- name %>-optional-label"><%- optionalStr %></span>
<% } %>
</label> </label>
<% } %> <% } %>
<% if ( instructions ) { %> <span class="tip tip-input" id="<%= form %>-<%= name %>-desc"><%= instructions %></span><% } %> <span id="<%- form %>-<%- name %>-validation-error" class="tip error" aria-live="assertive">
<span class="sr-only">ERROR: </span>
<span id="<%- form %>-<%- name %>-validation-error-msg"></span>
</span>
<% if ( instructions ) { %> <span class="tip tip-input" id="<%- form %>-<%- name %>-desc"><%- instructions %></span><% } %>
<% } %> <% } %>
<% if( form === 'login' && name === 'password' ) { %> <% if( form === 'login' && name === 'password' ) { %>
......
openedx/core/djangoapps/user_api/accounts/__init__.py
...@@ -45,7 +45,7 @@ USERNAME_INVALID_CHARS_UNICODE = _( ...@@ -45,7 +45,7 @@ USERNAME_INVALID_CHARS_UNICODE = _(
# Translators: This message is shown to users who attempt to create a new account using # Translators: This message is shown to users who attempt to create a new account using
# an invalid email format. # an invalid email format.
EMAIL_INVALID_MSG = _(u"Email '{email}' format is not valid") EMAIL_INVALID_MSG = _(u'"{email}" is not a valid email address.')
# Translators: This message is shown to users who attempt to create a new # Translators: This message is shown to users who attempt to create a new
# account using an username/email associated with an existing account. # account using an username/email associated with an existing account.
...@@ -60,15 +60,31 @@ USERNAME_CONFLICT_MSG = _( ...@@ -60,15 +60,31 @@ USERNAME_CONFLICT_MSG = _(
# Translators: This message is shown to users who enter a username/email/password # Translators: This message is shown to users who enter a username/email/password
# with an inappropriate length (too short or too long). # with an inappropriate length (too short or too long).
USERNAME_BAD_LENGTH_MSG = _(u"Username '{username}' must be between {min} and {max} characters long") USERNAME_BAD_LENGTH_MSG = _(u"Username must be between {min} and {max} characters long.").format(
EMAIL_BAD_LENGTH_MSG = _(u"Email '{email}' must be between {min} and {max} characters long") min=USERNAME_MIN_LENGTH, max=USERNAME_MAX_LENGTH
PASSWORD_BAD_LENGTH_MSG = _(u"Password must be between {min} and {max} characters long") )
EMAIL_BAD_LENGTH_MSG = _(u"Enter a valid email address that contains at least {min} characters.").format(
min=EMAIL_MIN_LENGTH
)
PASSWORD_EMPTY_MSG = _(u"Please enter a password.")
PASSWORD_BAD_MIN_LENGTH_MSG = _(u"Password is not long enough.")
PASSWORD_BAD_MAX_LENGTH_MSG = _(u"Password cannot be longer than {max} character.").format(max=PASSWORD_MAX_LENGTH)
# These strings are normally not user-facing. # These strings are normally not user-facing.
USERNAME_BAD_TYPE_MSG = u"Username must be a string" USERNAME_BAD_TYPE_MSG = u"Username must be a string."
EMAIL_BAD_TYPE_MSG = u"Email must be a string" EMAIL_BAD_TYPE_MSG = u"Email must be a string."
PASSWORD_BAD_TYPE_MSG = u"Password must be a string" PASSWORD_BAD_TYPE_MSG = u"Password must be a string."
# Translators: This message is shown to users who enter a password matching # Translators: This message is shown to users who enter a password matching
# the username they enter(ed). # the username they enter(ed).
PASSWORD_CANT_EQUAL_USERNAME_MSG = _(u"Password cannot be the same as the username") PASSWORD_CANT_EQUAL_USERNAME_MSG = _(u"Password cannot be the same as the username.")
# Translators: These messages are shown to users who do not enter information
# into the required field or enter it incorrectly.
REQUIRED_FIELD_NAME_MSG = _(u"Please enter your Full Name.")
REQUIRED_FIELD_CONFIRM_EMAIL_MSG = _(u"The email addresses do not match.")
REQUIRED_FIELD_COUNTRY_MSG = _(u"Please select your Country.")
REQUIRED_FIELD_CITY_MSG = _(u"Please enter your City.")
REQUIRED_FIELD_GOALS_MSG = _(u"Please tell us your goals.")
REQUIRED_FIELD_LEVEL_OF_EDUCATION_MSG = _(u"Please select your highest level of education completed.")
REQUIRED_FIELD_MAILING_ADDRESS_MSG = _(u"Please enter your mailing address.")
openedx/core/djangoapps/user_api/accounts/tests/test_api.py
...@@ -36,7 +36,7 @@ from openedx.core.djangoapps.user_api.errors import ( ...@@ -36,7 +36,7 @@ from openedx.core.djangoapps.user_api.errors import (
AccountRequestError AccountRequestError
) )
from openedx.core.djangoapps.user_api.accounts.tests.testutils import ( from openedx.core.djangoapps.user_api.accounts.tests.testutils import (
INVALID_EMAILS, INVALID_PASSWORDS, INVALID_USERNAMES INVALID_EMAILS, INVALID_PASSWORDS, INVALID_USERNAMES, VALID_USERNAMES_UNICODE
) )
from openedx.core.djangolib.testing.utils import skip_unless_lms from openedx.core.djangolib.testing.utils import skip_unless_lms
from student.models import PendingEmailChange from student.models import PendingEmailChange
...@@ -450,14 +450,7 @@ class AccountCreationUnicodeUsernameTest(TestCase): ...@@ -450,14 +450,7 @@ class AccountCreationUnicodeUsernameTest(TestCase):
PASSWORD = u'unicode-user-password' PASSWORD = u'unicode-user-password'
EMAIL = u'unicode-user-username@example.com' EMAIL = u'unicode-user-username@example.com'
UNICODE_USERNAMES = [ @ddt.data(*VALID_USERNAMES_UNICODE)
u'Enchanté',
u'username_with_@',
u'username with spaces',
u'eastern_arabic_numbers_١٢٣',
]
@ddt.data(*UNICODE_USERNAMES)
def test_unicode_usernames(self, unicode_username): def test_unicode_usernames(self, unicode_username):
with patch.dict(settings.FEATURES, {'ENABLE_UNICODE_USERNAME': False}): with patch.dict(settings.FEATURES, {'ENABLE_UNICODE_USERNAME': False}):
with self.assertRaises(AccountUsernameInvalid): with self.assertRaises(AccountUsernameInvalid):
......
openedx/core/djangoapps/user_api/accounts/tests/testutils.py
...@@ -10,6 +10,12 @@ from openedx.core.djangoapps.user_api.accounts import ( ...@@ -10,6 +10,12 @@ from openedx.core.djangoapps.user_api.accounts import (
) )
INVALID_NAMES = [
None,
'',
u''
]
INVALID_USERNAMES_ASCII = [ INVALID_USERNAMES_ASCII = [
'$invalid-ascii$', '$invalid-ascii$',
'invalid-fŕáńḱ', 'invalid-fŕáńḱ',
...@@ -52,6 +58,24 @@ INVALID_PASSWORDS = [ ...@@ -52,6 +58,24 @@ INVALID_PASSWORDS = [
u'a' * (PASSWORD_MAX_LENGTH + 1) u'a' * (PASSWORD_MAX_LENGTH + 1)
] ]
INVALID_COUNTRIES = [
None,
"",
"--"
]
VALID_NAMES = [
'Validation Bot',
u'Validation Bot'
]
VALID_USERNAMES_UNICODE = [
u'Enchanté',
u'username_with_@',
u'username with spaces',
u'eastern_arabic_numbers_١٢٣',
]
VALID_USERNAMES = [ VALID_USERNAMES = [
u'username', u'username',
u'a' * USERNAME_MIN_LENGTH, u'a' * USERNAME_MIN_LENGTH,
...@@ -72,3 +96,9 @@ VALID_PASSWORDS = [ ...@@ -72,3 +96,9 @@ VALID_PASSWORDS = [
u'a' * PASSWORD_MIN_LENGTH, u'a' * PASSWORD_MIN_LENGTH,
u'a' * PASSWORD_MAX_LENGTH u'a' * PASSWORD_MAX_LENGTH
] ]
VALID_COUNTRIES = [
u'PK',
u'Pakistan',
u'US'
]
openedx/core/djangoapps/user_api/errors.py
...@@ -58,6 +58,11 @@ class AccountPasswordInvalid(AccountRequestError): ...@@ -58,6 +58,11 @@ class AccountPasswordInvalid(AccountRequestError):
pass pass
class AccountCountryInvalid(AccountRequestError):
"""The requested country does not exist. """
pass
class AccountDataBadLength(AccountRequestError): class AccountDataBadLength(AccountRequestError):
"""The requested account data is either too short or too long. """ """The requested account data is either too short or too long. """
pass pass
......
openedx/core/djangoapps/user_api/tests/test_views.py
...@@ -33,7 +33,7 @@ from xmodule.modulestore.tests.django_utils import SharedModuleStoreTestCase ...@@ -33,7 +33,7 @@ from xmodule.modulestore.tests.django_utils import SharedModuleStoreTestCase
from xmodule.modulestore.tests.factories import CourseFactory from xmodule.modulestore.tests.factories import CourseFactory
from ..accounts import ( from ..accounts import (
NAME_MAX_LENGTH, EMAIL_MIN_LENGTH, EMAIL_MAX_LENGTH, PASSWORD_MIN_LENGTH, PASSWORD_MAX_LENGTH, NAME_MAX_LENGTH, EMAIL_MIN_LENGTH, EMAIL_MAX_LENGTH, PASSWORD_MIN_LENGTH, PASSWORD_MAX_LENGTH,
USERNAME_MIN_LENGTH, USERNAME_MAX_LENGTH USERNAME_MIN_LENGTH, USERNAME_MAX_LENGTH, USERNAME_BAD_LENGTH_MSG
) )
from ..accounts.api import get_account_settings from ..accounts.api import get_account_settings
from ..models import UserOrgTag from ..models import UserOrgTag
...@@ -1198,6 +1198,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase): ...@@ -1198,6 +1198,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase):
{"value": "none", "name": "No formal education", "default": False}, {"value": "none", "name": "No formal education", "default": False},
{"value": "other", "name": "Other education", "default": False}, {"value": "other", "name": "Other education", "default": False},
], ],
"errorMessages": {
"required": "Please select your highest level of education completed."
}
} }
) )
...@@ -1224,6 +1227,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase): ...@@ -1224,6 +1227,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase):
{"value": "none", "name": "No formal education TRANSLATED", "default": False}, {"value": "none", "name": "No formal education TRANSLATED", "default": False},
{"value": "other", "name": "Other education TRANSLATED", "default": False}, {"value": "other", "name": "Other education TRANSLATED", "default": False},
], ],
"errorMessages": {
"required": "Please select your highest level of education completed."
}
} }
) )
...@@ -1301,6 +1307,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase): ...@@ -1301,6 +1307,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase):
"type": "textarea", "type": "textarea",
"required": False, "required": False,
"label": "Mailing address", "label": "Mailing address",
"errorMessages": {
"required": "Please enter your mailing address."
}
} }
) )
...@@ -1313,7 +1322,10 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase): ...@@ -1313,7 +1322,10 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase):
"required": False, "required": False,
"label": u"Tell us why you're interested in {platform_name}".format( "label": u"Tell us why you're interested in {platform_name}".format(
platform_name=settings.PLATFORM_NAME platform_name=settings.PLATFORM_NAME
) ),
"errorMessages": {
"required": "Please tell us your goals."
}
} }
) )
...@@ -1325,6 +1337,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase): ...@@ -1325,6 +1337,9 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase):
"type": "text", "type": "text",
"required": False, "required": False,
"label": "City", "label": "City",
"errorMessages": {
"required": "Please enter your City."
}
} }
) )
...@@ -1992,8 +2007,8 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase): ...@@ -1992,8 +2007,8 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase):
self.assertEqual( self.assertEqual(
response_json, response_json,
{ {
"username": [{"user_message": "Username must be minimum of two characters long"}], u"username": [{u"user_message": USERNAME_BAD_LENGTH_MSG}],
"password": [{"user_message": "A valid password is required"}], u"password": [{u"user_message": u"A valid password is required"}],
} }
) )
......
openedx/core/djangoapps/user_api/validation/tests/test_views.py
...@@ -10,19 +10,8 @@ from django.conf import settings ...@@ -10,19 +10,8 @@ from django.conf import settings
from django.contrib.auth.models import User from django.contrib.auth.models import User
from django.core.urlresolvers import reverse from django.core.urlresolvers import reverse
from openedx.core.djangoapps.user_api.accounts import ( from openedx.core.djangoapps.user_api import accounts
EMAIL_BAD_LENGTH_MSG, EMAIL_INVALID_MSG, from openedx.core.djangoapps.user_api.accounts.tests import testutils
EMAIL_CONFLICT_MSG, EMAIL_MAX_LENGTH, EMAIL_MIN_LENGTH,
PASSWORD_BAD_LENGTH_MSG, PASSWORD_CANT_EQUAL_USERNAME_MSG,
PASSWORD_MAX_LENGTH, PASSWORD_MIN_LENGTH,
USERNAME_BAD_LENGTH_MSG, USERNAME_INVALID_CHARS_ASCII, USERNAME_INVALID_CHARS_UNICODE,
USERNAME_CONFLICT_MSG, USERNAME_MAX_LENGTH, USERNAME_MIN_LENGTH
)
from openedx.core.djangoapps.user_api.accounts.tests.testutils import (
VALID_EMAILS, VALID_PASSWORDS, VALID_USERNAMES,
INVALID_EMAILS, INVALID_PASSWORDS, INVALID_USERNAMES,
INVALID_USERNAMES_ASCII, INVALID_USERNAMES_UNICODE
)
from openedx.core.lib.api import test_utils from openedx.core.lib.api import test_utils
...@@ -45,16 +34,30 @@ class RegistrationValidationViewTests(test_utils.ApiTestCase): ...@@ -45,16 +34,30 @@ class RegistrationValidationViewTests(test_utils.ApiTestCase):
decision decision
) )
def assertNotValidationDecision(self, data, decision):
self.assertNotEqual(
self.get_validation_decision(data),
decision
)
def test_no_decision_for_empty_request(self): def test_no_decision_for_empty_request(self):
self.assertValidationDecision({}, {}) self.assertValidationDecision(
{},
{}
)
def test_no_decision_for_invalid_request(self): def test_no_decision_for_invalid_request(self):
self.assertValidationDecision({'invalid_field': 'random_user_data'}, {}) self.assertValidationDecision(
{'invalid_field': 'random_user_data'},
{}
)
@ddt.data( @ddt.data(
['email', (email for email in VALID_EMAILS)], ['name', (name for name in testutils.VALID_NAMES)],
['password', (password for password in VALID_PASSWORDS)], ['email', (email for email in testutils.VALID_EMAILS)],
['username', (username for username in VALID_USERNAMES)] ['password', (password for password in testutils.VALID_PASSWORDS)],
['username', (username for username in testutils.VALID_USERNAMES)],
['country', (country for country in testutils.VALID_COUNTRIES)]
) )
@ddt.unpack @ddt.unpack
def test_positive_validation_decision(self, form_field_name, user_data): def test_positive_validation_decision(self, form_field_name, user_data):
...@@ -68,17 +71,19 @@ class RegistrationValidationViewTests(test_utils.ApiTestCase): ...@@ -68,17 +71,19 @@ class RegistrationValidationViewTests(test_utils.ApiTestCase):
@ddt.data( @ddt.data(
# Skip None type for invalidity checks. # Skip None type for invalidity checks.
['email', (email for email in INVALID_EMAILS[1:])], ['name', (name for name in testutils.INVALID_NAMES[1:])],
['password', (password for password in INVALID_PASSWORDS[1:])], ['email', (email for email in testutils.INVALID_EMAILS[1:])],
['username', (username for username in INVALID_USERNAMES[1:])] ['password', (password for password in testutils.INVALID_PASSWORDS[1:])],
['username', (username for username in testutils.INVALID_USERNAMES[1:])],
['country', (country for country in testutils.INVALID_COUNTRIES[1:])]
) )
@ddt.unpack @ddt.unpack
def test_negative_validation_decision(self, form_field_name, user_data): def test_negative_validation_decision(self, form_field_name, user_data):
""" """
Test if {0} as any item in {1} gives a negative validation decision. Test if {0} as any item in {1} gives a negative validation decision.
""" """
self.assertNotEqual( self.assertNotValidationDecision(
self.get_validation_decision({form_field_name: user_data}), {form_field_name: user_data},
{form_field_name: ''} {form_field_name: ''}
) )
...@@ -101,71 +106,91 @@ class RegistrationValidationViewTests(test_utils.ApiTestCase): ...@@ -101,71 +106,91 @@ class RegistrationValidationViewTests(test_utils.ApiTestCase):
'email': email 'email': email
}, },
{ {
"username": USERNAME_CONFLICT_MSG.format(username=user.username) if username == user.username else '', "username": accounts.USERNAME_CONFLICT_MSG.format(
"email": EMAIL_CONFLICT_MSG.format(email_address=user.email) if email == user.email else '' username=user.username
) if username == user.username else '',
"email": accounts.EMAIL_CONFLICT_MSG.format(
email_address=user.email
) if email == user.email else ''
} }
) )
@ddt.data('', ('e' * EMAIL_MAX_LENGTH) + '@email.com') @ddt.data('', ('e' * accounts.EMAIL_MAX_LENGTH) + '@email.com')
def test_email_less_than_min_length_validation_decision(self, email): def test_email_bad_length_validation_decision(self, email):
self.assertValidationDecision( self.assertValidationDecision(
{'email': email}, {'email': email},
{'email': EMAIL_BAD_LENGTH_MSG.format(email=email, min=EMAIL_MIN_LENGTH, max=EMAIL_MAX_LENGTH)} {'email': accounts.EMAIL_BAD_LENGTH_MSG}
) )
def test_email_generically_invalid_validation_decision(self): def test_email_generically_invalid_validation_decision(self):
email = 'email' email = 'email'
self.assertValidationDecision( self.assertValidationDecision(
{'email': email}, {'email': email},
{'email': EMAIL_INVALID_MSG.format(email=email)} {'email': accounts.EMAIL_INVALID_MSG.format(email=email)}
)
def test_confirm_email_matches_email(self):
email = 'user@email.com'
self.assertValidationDecision(
{'email': email, 'confirm_email': email},
{'email': '', 'confirm_email': ''}
)
@ddt.data('', 'users@other.email')
def test_confirm_email_doesnt_equal_email(self, confirm_email):
self.assertValidationDecision(
{'email': 'user@email.com', 'confirm_email': confirm_email},
{'email': '', 'confirm_email': accounts.REQUIRED_FIELD_CONFIRM_EMAIL_MSG}
) )
@ddt.data( @ddt.data(
'u' * (USERNAME_MIN_LENGTH - 1), 'u' * (accounts.USERNAME_MIN_LENGTH - 1),
'u' * (USERNAME_MAX_LENGTH + 1) 'u' * (accounts.USERNAME_MAX_LENGTH + 1)
) )
def test_username_less_than_min_length_validation_decision(self, username): def test_username_bad_length_validation_decision(self, username):
self.assertValidationDecision( self.assertValidationDecision(
{'username': username}, {'username': username},
{ {'username': accounts.USERNAME_BAD_LENGTH_MSG}
'username': USERNAME_BAD_LENGTH_MSG.format(
username=username,
min=USERNAME_MIN_LENGTH,
max=USERNAME_MAX_LENGTH
)
}
) )
@unittest.skipUnless(settings.FEATURES.get("ENABLE_UNICODE_USERNAME"), "Unicode usernames disabled.") @unittest.skipUnless(settings.FEATURES.get("ENABLE_UNICODE_USERNAME"), "Unicode usernames disabled.")
@ddt.data(*INVALID_USERNAMES_UNICODE) @ddt.data(*testutils.INVALID_USERNAMES_UNICODE)
@ddt.unpack
def test_username_invalid_unicode_validation_decision(self, username): def test_username_invalid_unicode_validation_decision(self, username):
self.assertValidationDecision( self.assertValidationDecision(
{'username': username}, {'username': username},
{'username': USERNAME_INVALID_CHARS_UNICODE} {'username': accounts.USERNAME_INVALID_CHARS_UNICODE}
) )
@unittest.skipIf(settings.FEATURES.get("ENABLE_UNICODE_USERNAME"), "Unicode usernames enabled.") @unittest.skipIf(settings.FEATURES.get("ENABLE_UNICODE_USERNAME"), "Unicode usernames enabled.")
@ddt.data(*INVALID_USERNAMES_ASCII) @ddt.data(*testutils.INVALID_USERNAMES_ASCII)
@ddt.unpack
def test_username_invalid_ascii_validation_decision(self, username): def test_username_invalid_ascii_validation_decision(self, username):
self.assertValidationDecision( self.assertValidationDecision(
{'username': username}, {'username': username},
{"username": USERNAME_INVALID_CHARS_ASCII} {"username": accounts.USERNAME_INVALID_CHARS_ASCII}
) )
@ddt.data( def test_password_empty_validation_decision(self):
'p' * (PASSWORD_MIN_LENGTH - 1), self.assertValidationDecision(
'p' * (PASSWORD_MAX_LENGTH + 1) {'password': ''},
) {"password": accounts.PASSWORD_EMPTY_MSG}
def test_password_less_than_min_length_validation_decision(self, password): )
def test_password_bad_min_length_validation_decision(self):
password = 'p' * (accounts.PASSWORD_MIN_LENGTH - 1)
self.assertValidationDecision(
{'password': password},
{"password": accounts.PASSWORD_BAD_MIN_LENGTH_MSG}
)
def test_password_bad_max_length_validation_decision(self):
password = 'p' * (accounts.PASSWORD_MAX_LENGTH + 1)
self.assertValidationDecision( self.assertValidationDecision(
{'password': password}, {'password': password},
{"password": PASSWORD_BAD_LENGTH_MSG.format(min=PASSWORD_MIN_LENGTH, max=PASSWORD_MAX_LENGTH)} {"password": accounts.PASSWORD_BAD_MAX_LENGTH_MSG}
) )
def test_password_equals_username_validation_decision(self): def test_password_equals_username_validation_decision(self):
self.assertValidationDecision( self.assertValidationDecision(
{"username": "somephrase", "password": "somephrase"}, {"username": "somephrase", "password": "somephrase"},
{"username": "", "password": PASSWORD_CANT_EQUAL_USERNAME_MSG} {"username": "", "password": accounts.PASSWORD_CANT_EQUAL_USERNAME_MSG}
) )
openedx/core/djangoapps/user_api/validation/views.py
...@@ -9,6 +9,9 @@ from rest_framework.views import APIView ...@@ -9,6 +9,9 @@ from rest_framework.views import APIView
from openedx.core.djangoapps.user_api.accounts.api import ( from openedx.core.djangoapps.user_api.accounts.api import (
get_email_validation_error, get_email_validation_error,
get_email_existence_validation_error, get_email_existence_validation_error,
get_confirm_email_validation_error,
get_country_validation_error,
get_name_validation_error,
get_password_validation_error, get_password_validation_error,
get_username_validation_error, get_username_validation_error,
get_username_existence_validation_error get_username_existence_validation_error
...@@ -85,38 +88,66 @@ class RegistrationValidationView(APIView): ...@@ -85,38 +88,66 @@ class RegistrationValidationView(APIView):
**Available Handlers** **Available Handlers**
"name":
A handler to check the validity of the user's real name.
"username": "username":
A handler to check the validity of usernames. A handler to check the validity of usernames.
"email": "email":
A handler to check the validity of emails. A handler to check the validity of emails.
"confirm_email":
A handler to check whether the confirmation email field matches
the email field.
"password": "password":
A handler to check the validity of passwords; a compatibility A handler to check the validity of passwords; a compatibility
decision with the username is made if it exists in the input. decision with the username is made if it exists in the input.
"country":
A handler to check whether the validity of country fields.
""" """
# This end-point is available to anonymous users, so no authentication is needed.
authentication_classes = []
def name_handler(self, request):
name = request.data.get('name')
return get_name_validation_error(name)
def username_handler(self, request): def username_handler(self, request):
username = request.data.get('username') username = request.data.get('username')
invalid_username_error = get_username_validation_error(username) invalid_username_error = get_username_validation_error(username)
username_exists_error = get_username_existence_validation_error(username) username_exists_error = get_username_existence_validation_error(username)
# Existing usernames are already valid, so we prefer that error. # We prefer seeing for invalidity first.
return username_exists_error or invalid_username_error # Some invalid usernames (like for superusers) may exist.
return invalid_username_error or username_exists_error
def email_handler(self, request): def email_handler(self, request):
email = request.data.get('email') email = request.data.get('email')
invalid_email_error = get_email_validation_error(email) invalid_email_error = get_email_validation_error(email)
email_exists_error = get_email_existence_validation_error(email) email_exists_error = get_email_existence_validation_error(email)
# Existing emails are already valid, so we prefer that error. # We prefer seeing for invalidity first.
return email_exists_error or invalid_email_error # Some invalid emails (like a blank one for superusers) may exist.
return invalid_email_error or email_exists_error
def confirm_email_handler(self, request):
email = request.data.get('email', None)
confirm_email = request.data.get('confirm_email')
return get_confirm_email_validation_error(confirm_email, email)
def password_handler(self, request): def password_handler(self, request):
username = request.data.get('username') or None username = request.data.get('username', None)
password = request.data.get('password') password = request.data.get('password')
return get_password_validation_error(password, username) return get_password_validation_error(password, username)
def country_handler(self, request):
country = request.data.get('country')
return get_country_validation_error(country)
validation_handlers = { validation_handlers = {
"name": name_handler,
"username": username_handler, "username": username_handler,
"email": email_handler, "email": email_handler,
"confirm_email": confirm_email_handler,
"password": password_handler, "password": password_handler,
"country": country_handler
} }
def post(self, request): def post(self, request):
...@@ -125,9 +156,12 @@ class RegistrationValidationView(APIView): ...@@ -125,9 +156,12 @@ class RegistrationValidationView(APIView):
Expects request of the form Expects request of the form
>>> { >>> {
>>> "name": "Dan the Validator",
>>> "username": "mslm", >>> "username": "mslm",
>>> "email": "mslm@gmail.com", >>> "email": "mslm@gmail.com",
>>> "password": "password123" >>> "confirm_email": "mslm@gmail.com",
>>> "password": "password123",
>>> "country": "PK"
>>> } >>> }
where each key is the appropriate form field name and the value is where each key is the appropriate form field name and the value is
user input. One may enter individual inputs if needed. Some inputs user input. One may enter individual inputs if needed. Some inputs
......
openedx/core/djangoapps/user_api/views.py
...@@ -31,15 +31,7 @@ from student.forms import get_registration_extension_form ...@@ -31,15 +31,7 @@ from student.forms import get_registration_extension_form
from student.views import create_account_with_params, AccountValidationError from student.views import create_account_with_params, AccountValidationError
from util.json_request import JsonResponse from util.json_request import JsonResponse
from .accounts import ( import accounts
EMAIL_MAX_LENGTH, EMAIL_MIN_LENGTH,
NAME_MAX_LENGTH,
PASSWORD_MAX_LENGTH, PASSWORD_MIN_LENGTH,
USERNAME_MAX_LENGTH, USERNAME_MIN_LENGTH,
EMAIL_CONFLICT_MSG,
USERNAME_CONFLICT_MSG
)
from .accounts.api import check_account_exists
from .helpers import FormDescription, require_post_params, shim_student_view from .helpers import FormDescription, require_post_params, shim_student_view
from .models import UserPreference, UserProfile from .models import UserPreference, UserProfile
from .preferences.api import get_country_time_zones, update_email_opt_in from .preferences.api import get_country_time_zones, update_email_opt_in
...@@ -91,8 +83,8 @@ class LoginSessionView(APIView): ...@@ -91,8 +83,8 @@ class LoginSessionView(APIView):
placeholder=email_placeholder, placeholder=email_placeholder,
instructions=email_instructions, instructions=email_instructions,
restrictions={ restrictions={
"min_length": EMAIL_MIN_LENGTH, "min_length": accounts.EMAIL_MIN_LENGTH,
"max_length": EMAIL_MAX_LENGTH, "max_length": accounts.EMAIL_MAX_LENGTH,
} }
) )
...@@ -105,8 +97,8 @@ class LoginSessionView(APIView): ...@@ -105,8 +97,8 @@ class LoginSessionView(APIView):
label=password_label, label=password_label,
field_type="password", field_type="password",
restrictions={ restrictions={
"min_length": PASSWORD_MIN_LENGTH, "min_length": accounts.PASSWORD_MIN_LENGTH,
"max_length": PASSWORD_MAX_LENGTH, "max_length": accounts.PASSWORD_MAX_LENGTH,
} }
) )
...@@ -336,11 +328,11 @@ class RegistrationView(APIView): ...@@ -336,11 +328,11 @@ class RegistrationView(APIView):
username = data.get('username') username = data.get('username')
# Handle duplicate email/username # Handle duplicate email/username
conflicts = check_account_exists(email=email, username=username) conflicts = accounts.api.check_account_exists(email=email, username=username)
if conflicts: if conflicts:
conflict_messages = { conflict_messages = {
"email": EMAIL_CONFLICT_MSG.format(email_address=email), "email": accounts.EMAIL_CONFLICT_MSG.format(email_address=email),
"username": USERNAME_CONFLICT_MSG.format(username=username), "username": accounts.USERNAME_CONFLICT_MSG.format(username=username),
} }
errors = { errors = {
field: [{"user_message": conflict_messages[field]}] field: [{"user_message": conflict_messages[field]}]
...@@ -414,8 +406,8 @@ class RegistrationView(APIView): ...@@ -414,8 +406,8 @@ class RegistrationView(APIView):
placeholder=email_placeholder, placeholder=email_placeholder,
instructions=email_instructions, instructions=email_instructions,
restrictions={ restrictions={
"min_length": EMAIL_MIN_LENGTH, "min_length": accounts.EMAIL_MIN_LENGTH,
"max_length": EMAIL_MAX_LENGTH, "max_length": accounts.EMAIL_MAX_LENGTH,
}, },
required=required required=required
) )
...@@ -433,7 +425,7 @@ class RegistrationView(APIView): ...@@ -433,7 +425,7 @@ class RegistrationView(APIView):
# Translators: This label appears above a field on the registration form # Translators: This label appears above a field on the registration form
# meant to confirm the user's email address. # meant to confirm the user's email address.
email_label = _(u"Confirm Email") email_label = _(u"Confirm Email")
error_msg = _(u"The email addresses do not match.") error_msg = accounts.REQUIRED_FIELD_CONFIRM_EMAIL_MSG
form_desc.add_field( form_desc.add_field(
"confirm_email", "confirm_email",
...@@ -472,7 +464,7 @@ class RegistrationView(APIView): ...@@ -472,7 +464,7 @@ class RegistrationView(APIView):
placeholder=name_placeholder, placeholder=name_placeholder,
instructions=name_instructions, instructions=name_instructions,
restrictions={ restrictions={
"max_length": NAME_MAX_LENGTH, "max_length": accounts.NAME_MAX_LENGTH,
}, },
required=required required=required
) )
...@@ -508,8 +500,8 @@ class RegistrationView(APIView): ...@@ -508,8 +500,8 @@ class RegistrationView(APIView):
instructions=username_instructions, instructions=username_instructions,
placeholder=username_placeholder, placeholder=username_placeholder,
restrictions={ restrictions={
"min_length": USERNAME_MIN_LENGTH, "min_length": accounts.USERNAME_MIN_LENGTH,
"max_length": USERNAME_MAX_LENGTH, "max_length": accounts.USERNAME_MAX_LENGTH,
}, },
required=required required=required
) )
...@@ -533,8 +525,8 @@ class RegistrationView(APIView): ...@@ -533,8 +525,8 @@ class RegistrationView(APIView):
label=password_label, label=password_label,
field_type="password", field_type="password",
restrictions={ restrictions={
"min_length": PASSWORD_MIN_LENGTH, "min_length": accounts.PASSWORD_MIN_LENGTH,
"max_length": PASSWORD_MAX_LENGTH, "max_length": accounts.PASSWORD_MAX_LENGTH,
}, },
required=required required=required
) )
...@@ -552,6 +544,7 @@ class RegistrationView(APIView): ...@@ -552,6 +544,7 @@ class RegistrationView(APIView):
# Translators: This label appears above a dropdown menu on the registration # Translators: This label appears above a dropdown menu on the registration
# form used to select the user's highest completed level of education. # form used to select the user's highest completed level of education.
education_level_label = _(u"Highest level of education completed") education_level_label = _(u"Highest level of education completed")
error_msg = accounts.REQUIRED_FIELD_LEVEL_OF_EDUCATION_MSG
# The labels are marked for translation in UserProfile model definition. # The labels are marked for translation in UserProfile model definition.
options = [(name, _(label)) for name, label in UserProfile.LEVEL_OF_EDUCATION_CHOICES] # pylint: disable=translation-of-non-string options = [(name, _(label)) for name, label in UserProfile.LEVEL_OF_EDUCATION_CHOICES] # pylint: disable=translation-of-non-string
...@@ -561,7 +554,10 @@ class RegistrationView(APIView): ...@@ -561,7 +554,10 @@ class RegistrationView(APIView):
field_type="select", field_type="select",
options=options, options=options,
include_default_option=True, include_default_option=True,
required=required required=required,
error_messages={
"required": error_msg
}
) )
def _add_gender_field(self, form_desc, required=True): def _add_gender_field(self, form_desc, required=True):
...@@ -626,12 +622,16 @@ class RegistrationView(APIView): ...@@ -626,12 +622,16 @@ class RegistrationView(APIView):
# Translators: This label appears above a field on the registration form # Translators: This label appears above a field on the registration form
# meant to hold the user's mailing address. # meant to hold the user's mailing address.
mailing_address_label = _(u"Mailing address") mailing_address_label = _(u"Mailing address")
error_msg = accounts.REQUIRED_FIELD_MAILING_ADDRESS_MSG
form_desc.add_field( form_desc.add_field(
"mailing_address", "mailing_address",
label=mailing_address_label, label=mailing_address_label,
field_type="textarea", field_type="textarea",
required=required required=required,
error_messages={
"required": error_msg
}
) )
def _add_goals_field(self, form_desc, required=True): def _add_goals_field(self, form_desc, required=True):
...@@ -649,12 +649,16 @@ class RegistrationView(APIView): ...@@ -649,12 +649,16 @@ class RegistrationView(APIView):
goals_label = _(u"Tell us why you're interested in {platform_name}").format( goals_label = _(u"Tell us why you're interested in {platform_name}").format(
platform_name=configuration_helpers.get_value("PLATFORM_NAME", settings.PLATFORM_NAME) platform_name=configuration_helpers.get_value("PLATFORM_NAME", settings.PLATFORM_NAME)
) )
error_msg = accounts.REQUIRED_FIELD_GOALS_MSG
form_desc.add_field( form_desc.add_field(
"goals", "goals",
label=goals_label, label=goals_label,
field_type="textarea", field_type="textarea",
required=required required=required,
error_messages={
"required": error_msg
}
) )
def _add_city_field(self, form_desc, required=True): def _add_city_field(self, form_desc, required=True):
...@@ -670,11 +674,15 @@ class RegistrationView(APIView): ...@@ -670,11 +674,15 @@ class RegistrationView(APIView):
# Translators: This label appears above a field on the registration form # Translators: This label appears above a field on the registration form
# which allows the user to input the city in which they live. # which allows the user to input the city in which they live.
city_label = _(u"City") city_label = _(u"City")
error_msg = accounts.REQUIRED_FIELD_CITY_MSG
form_desc.add_field( form_desc.add_field(
"city", "city",
label=city_label, label=city_label,
required=required required=required,
error_messages={
"required": error_msg
}
) )
def _add_state_field(self, form_desc, required=False): def _add_state_field(self, form_desc, required=False):
...@@ -790,7 +798,7 @@ class RegistrationView(APIView): ...@@ -790,7 +798,7 @@ class RegistrationView(APIView):
# Translators: This label appears above a dropdown menu on the registration # Translators: This label appears above a dropdown menu on the registration
# form used to select the country in which the user lives. # form used to select the country in which the user lives.
country_label = _(u"Country") country_label = _(u"Country")
error_msg = _(u"Please select your Country.") error_msg = accounts.REQUIRED_FIELD_COUNTRY_MSG
# If we set a country code, make sure it's uppercase for the sake of the form. # If we set a country code, make sure it's uppercase for the sake of the form.
default_country = form_desc._field_overrides.get('country', {}).get('defaultValue') default_country = form_desc._field_overrides.get('country', {}).get('defaultValue')
...@@ -1025,8 +1033,8 @@ class PasswordResetView(APIView): ...@@ -1025,8 +1033,8 @@ class PasswordResetView(APIView):
placeholder=email_placeholder, placeholder=email_placeholder,
instructions=email_instructions, instructions=email_instructions,
restrictions={ restrictions={
"min_length": EMAIL_MIN_LENGTH, "min_length": accounts.EMAIL_MIN_LENGTH,
"max_length": EMAIL_MAX_LENGTH, "max_length": accounts.EMAIL_MAX_LENGTH,
} }
) )
...@@ -1094,7 +1102,9 @@ class PreferenceUsersListView(generics.ListAPIView): ...@@ -1094,7 +1102,9 @@ class PreferenceUsersListView(generics.ListAPIView):
paginate_by_param = "page_size" paginate_by_param = "page_size"
def get_queryset(self): def get_queryset(self):
return User.objects.filter(preferences__key=self.kwargs["pref_key"]).prefetch_related("preferences").select_related("profile") return User.objects.filter(
preferences__key=self.kwargs["pref_key"]
).prefetch_related("preferences").select_related("profile")
class UpdateEmailOptInPreference(APIView): class UpdateEmailOptInPreference(APIView):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment