Commit c3e1d592 by M. Rehan Committed by GitHub

Merge pull request #15528 from edx/mrehan/fix-noisy-ajax-captions

Dont fetch captions while fetching translations
parents d8133c3a c9bbc0b6
...@@ -779,7 +779,6 @@ ...@@ -779,7 +779,6 @@
Caption.fetchAvailableTranslations(); Caption.fetchAvailableTranslations();
expect($.ajaxWithPrefix).toHaveBeenCalled(); expect($.ajaxWithPrefix).toHaveBeenCalled();
expect(Caption.fetchCaption).toHaveBeenCalled();
expect(state.config.transcriptLanguages).toEqual({ expect(state.config.transcriptLanguages).toEqual({
'uk': 'Ukrainian', 'uk': 'Ukrainian',
'de': 'German' 'de': 'German'
...@@ -799,7 +798,6 @@ ...@@ -799,7 +798,6 @@
Caption.fetchAvailableTranslations(); Caption.fetchAvailableTranslations();
expect($.ajaxWithPrefix).toHaveBeenCalled(); expect($.ajaxWithPrefix).toHaveBeenCalled();
expect(Caption.fetchCaption).not.toHaveBeenCalled();
expect(state.config.transcriptLanguages).toEqual({}); expect(state.config.transcriptLanguages).toEqual({});
expect(Caption.renderLanguageMenu).not.toHaveBeenCalled(); expect(Caption.renderLanguageMenu).not.toHaveBeenCalled();
}); });
......
...@@ -596,8 +596,8 @@ ...@@ -596,8 +596,8 @@
}, },
/** /**
* @desc Fetch the list of available translations. Upon successful receipt, * @desc Fetch the list of available language codes. Upon successful receipt
* the list of available translations will be updated. * the list of available languages will be updated.
* *
* @returns {jquery Promise} * @returns {jquery Promise}
*/ */
...@@ -618,8 +618,6 @@ ...@@ -618,8 +618,6 @@
self.container.find('.langs-list').remove(); self.container.find('.langs-list').remove();
if (_.keys(newLanguages).length) { if (_.keys(newLanguages).length) {
// And try again to fetch transcript.
self.fetchCaption();
self.renderLanguageMenu(newLanguages); self.renderLanguageMenu(newLanguages);
} }
}, },
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment