Commit c37e2412 by Don Mitchell Committed by Calen Pennington

Make reverse matching robust to errored courses

Conflicts:
	cms/djangoapps/contentstore/tests/test_course_listing.py
parent f25dd8dd
...@@ -189,9 +189,9 @@ def _accessible_courses_list_from_groups(request): ...@@ -189,9 +189,9 @@ def _accessible_courses_list_from_groups(request):
course_key = course_access.course_id course_key = course_access.course_id
if course_key not in courses_list: if course_key not in courses_list:
course = modulestore('direct').get_course(course_key) course = modulestore('direct').get_course(course_key)
if course is None: if course is not None and not isinstance(course, ErrorDescriptor):
raise ItemNotFoundError(course_key) # ignore deleted or errored courses
courses_list[course_key] = course courses_list[course_key] = course
return courses_list.values() return courses_list.values()
......
...@@ -208,7 +208,7 @@ class CachingDescriptorSystem(MakoDescriptorSystem): ...@@ -208,7 +208,7 @@ class CachingDescriptorSystem(MakoDescriptorSystem):
module.save() module.save()
return module return module
except: except:
log.warning("Failed to load descriptor", exc_info=True) log.warning("Failed to load descriptor from %s", json_data, exc_info=True)
return ErrorDescriptor.from_json( return ErrorDescriptor.from_json(
json_data, json_data,
self, self,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment