Commit c170ff44 by Eric Fischer

Fixing flaky bokchoy TeamPageTests

The flaky test problems we've been seeing here are coming from not
waiting long enough after performing actions. By forcing
is_browser_on_page checks to wait until the page is fully loaded
instead of just looking for the presence of a single element, we
ensure that there will not be issues interacting with non-loaded
elements.

TNL-3069
parent a495847b
...@@ -402,6 +402,7 @@ class InlineDiscussionPage(PageObject): ...@@ -402,6 +402,7 @@ class InlineDiscussionPage(PageObject):
return self.q(css=self._discussion_selector + " " + selector) return self.q(css=self._discussion_selector + " " + selector)
def is_browser_on_page(self): def is_browser_on_page(self):
self.wait_for_ajax()
return self.q(css=self._discussion_selector).present return self.q(css=self._discussion_selector).present
def is_discussion_expanded(self): def is_discussion_expanded(self):
......
...@@ -261,6 +261,7 @@ class TeamPage(CoursePage, PaginatedUIMixin): ...@@ -261,6 +261,7 @@ class TeamPage(CoursePage, PaginatedUIMixin):
def is_browser_on_page(self): def is_browser_on_page(self):
"""Check if we're on the teams list page for a particular team.""" """Check if we're on the teams list page for a particular team."""
self.wait_for_ajax()
if self.team: if self.team:
if not self.url.endswith(self.url_path): if not self.url.endswith(self.url_path):
return False return False
......
...@@ -748,7 +748,6 @@ class CreateTeamTest(TeamsTabBase): ...@@ -748,7 +748,6 @@ class CreateTeamTest(TeamsTabBase):
self.verify_my_team_count(0) self.verify_my_team_count(0)
@flaky # TODO fix this, see TNL-3069
@attr('shard_5') @attr('shard_5')
@ddt.ddt @ddt.ddt
class TeamPageTest(TeamsTabBase): class TeamPageTest(TeamsTabBase):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment