Commit c07ce2ad by David Baumgold

Simplify test_only_expected_fields_are_displayed

Use sets to accomplish the same result.
parent 04ca163f
...@@ -397,10 +397,17 @@ class AdvancedSettingsValidationTest(StudioCourseTest): ...@@ -397,10 +397,17 @@ class AdvancedSettingsValidationTest(StudioCourseTest):
When I view the Advanced Settings screen for the course When I view the Advanced Settings screen for the course
The total number of fields displayed matches the number I expect The total number of fields displayed matches the number I expect
And the actual fields displayed match the fields I expect to see And the actual fields displayed match the fields I expect to see
Note that this test will NOT fail if fields that we expect to see are
not displayed, only if fields show up that we did not expect to see.
""" """
expected_fields = self.advanced_settings.expected_settings_names expected_fields = self.advanced_settings.expected_settings_names
displayed_fields = self.advanced_settings.displayed_settings_names displayed_fields = self.advanced_settings.displayed_settings_names
self.assertEqual(len(expected_fields), len(displayed_fields)) unexpectedly_displayed = set(displayed_fields) - set(expected_fields)
for field in displayed_fields: self.assertEquals(
if field not in expected_fields: len(unexpectedly_displayed),
self.fail("Field '{}' not expected for Advanced Settings display.".format(field)) 0,
"The following fields were unexpectedly displayed: {fields}".format(
fields=", ".join(unexpectedly_displayed)
)
)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment