Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
bedcf814
Commit
bedcf814
authored
Sep 14, 2015
by
Matt Drayer
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #9757 from edx/mattdrayer/signatory-title-length
mattdrayer/signatory-title-length: Bump to 106 characters
parents
e38fc826
60a85313
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
cms/static/js/certificates/models/signatory.js
+2
-2
cms/static/js/certificates/spec/views/certificate_details_spec.js
+1
-1
cms/static/js/certificates/spec/views/certificate_editor_spec.js
+2
-2
No files found.
cms/static/js/certificates/models/signatory.js
View file @
bedcf814
...
...
@@ -46,8 +46,8 @@ function(_, str, Backbone, BackboneRelational, gettext) {
'title'
:
gettext
(
'Signatory title should span over maximum of 2 lines.'
)
},
errors
);
}
else
if
((
lines
.
length
>
1
&&
(
lines
[
0
].
length
>
40
||
lines
[
1
].
length
>
40
))
||
(
lines
.
length
===
1
&&
title
.
length
>
40
))
{
else
if
((
lines
.
length
>
1
&&
(
lines
[
0
].
length
>
53
&&
lines
[
1
].
length
>
53
))
||
(
lines
.
length
===
1
&&
title
.
length
>
106
))
{
errors
=
_
.
extend
({
'title'
:
gettext
(
'Signatory title should have maximum of 40 characters per line.'
)
},
errors
);
...
...
cms/static/js/certificates/spec/views/certificate_details_spec.js
View file @
bedcf814
...
...
@@ -246,7 +246,7 @@ function(_, Course, CertificatesCollection, CertificateModel, CertificateDetails
});
setValuesToInputs
(
this
.
view
,
{
inputSignatoryTitle
:
'
New Signatory Test Title longer than 40 characters in length
'
inputSignatoryTitle
:
'
This is a certificate signatory title that has waaaaaaay more than 106 characters, in order to cause an exception.
'
});
setValuesToInputs
(
this
.
view
,
{
...
...
cms/static/js/certificates/spec/views/certificate_editor_spec.js
View file @
bedcf814
...
...
@@ -228,7 +228,7 @@ function(_, Course, CertificateModel, SignatoryModel, CertificatesCollection, Ce
}
);
it
(
'signatories should not save when
title has more than 40
characters per line'
,
function
()
{
it
(
'signatories should not save when
fields have too many
characters per line'
,
function
()
{
this
.
view
.
$
(
SELECTORS
.
addSignatoryButton
).
click
();
setValuesToInputs
(
this
.
view
,
{
inputCertificateName
:
'New Certificate Name'
...
...
@@ -239,7 +239,7 @@ function(_, Course, CertificateModel, SignatoryModel, CertificatesCollection, Ce
});
setValuesToInputs
(
this
.
view
,
{
inputSignatoryTitle
:
'
New Signatory title longer than 40 characters on one line
'
inputSignatoryTitle
:
'
This is a certificate signatory title that has waaaaaaay more than 106 characters, in order to cause an exception.
'
});
setValuesToInputs
(
this
.
view
,
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment