Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
bc5e27fe
Commit
bc5e27fe
authored
Aug 19, 2013
by
Chris Dodge
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
update some more call sites in LMS to always pass in a course_id
parent
a16aee34
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
lms/djangoapps/courseware/tests/tests.py
+1
-1
lms/djangoapps/instructor/hint_manager.py
+3
-3
No files found.
lms/djangoapps/courseware/tests/tests.py
View file @
bc5e27fe
...
...
@@ -64,7 +64,7 @@ class PageLoaderTestCase(LoginEnrollmentTestCase):
location_query
=
Location
(
course_loc
.
tag
,
course_loc
.
org
,
course_loc
.
course
,
None
,
None
,
None
)
items
=
module_store
.
get_items
(
location_query
)
items
=
module_store
.
get_items
(
location_query
,
course_id
=
course_id
)
if
len
(
items
)
<
1
:
self
.
fail
(
'Could not retrieve any items from course'
)
...
...
lms/djangoapps/instructor/hint_manager.py
View file @
bc5e27fe
...
...
@@ -89,7 +89,7 @@ def get_hints(request, course_id, field):
for
hints_by_problem
in
all_hints
:
loc
=
Location
(
hints_by_problem
.
definition_id
)
name
=
location_to_problem_name
(
loc
)
name
=
location_to_problem_name
(
course_id
,
loc
)
if
name
is
None
:
continue
id_to_name
[
hints_by_problem
.
definition_id
]
=
name
...
...
@@ -119,13 +119,13 @@ def get_hints(request, course_id, field):
return
render_dict
def
location_to_problem_name
(
loc
):
def
location_to_problem_name
(
course_id
,
loc
):
"""
Given the location of a crowdsource_hinter module, try to return the name of the
problem it wraps around. Return None if the hinter no longer exists.
"""
try
:
descriptor
=
modulestore
()
.
get_items
(
loc
)[
0
]
descriptor
=
modulestore
()
.
get_items
(
loc
,
course_id
=
course_id
)[
0
]
return
descriptor
.
get_children
()[
0
]
.
display_name
except
IndexError
:
# Sometimes, the problem is no longer in the course. Just
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment