Merge pull request #14275 from edx/revert-14216-noraiz/TNL-6197

Revert "Error while exporting course with too long filename"

cms/djangoapps/contentstore/tests/test_transcripts_utils.py

@@ -9,7 +9,6 @@ from mock import patch, Mock
 from django.test.utils import override_settings
 from django.conf import settings
 from django.utils import translation
-from django.utils.crypto import get_random_string
 
 from nose.plugins.skip import SkipTest
 
@@ -231,17 +230,6 @@ class TestDownloadYoutubeSubs(SharedModuleStoreTestCase):
         self.assertEqual(html5_ids[2], 'baz.1.4')
         self.assertEqual(html5_ids[3], 'foo')
 
-    def test_html5_id_length(self):
-        """
-        Test that html5_id is parsed with length less than 255, as html5 ids are
-        used as name for transcript objects and ultimately as filename while creating
-        file for transcript at the time of exporting a course.
-        Filename can't be longer than 255 characters.
-        150 chars is agreed length.
-        """
-        html5_ids = transcripts_utils.get_html5_ids([get_random_string(255)])
-        self.assertEqual(len(html5_ids[0]), 150)
-
     @patch('xmodule.video_module.transcripts_utils.requests.get')
     def test_fail_downloading_subs(self, mock_get):
 

cms/static/js/spec/video/transcripts/utils_spec.js

@@ -215,42 +215,6 @@ function($, _, Utils, _str) {
                     });
                 });
             });
-
-            describe('Too long arguments ', function() {
-                var longFileName = (function() {
-                        var text = '';
-                        var possibleChars = 'abcdefghijklmnopqrstuvwxyz';
-                        /* eslint vars-on-top: 0 */
-                        for (var i = 0; i < 255; i++) {
-                            text += possibleChars.charAt(Math.floor(Math.random() * possibleChars.length));
-                        }
-                        return text;
-                    }()),
-                    html5LongUrls = (function(videoName) {
-                        var links = [
-                            'http://somelink.com/%s?param=1&param=2#hash',
-                            'http://somelink.com/%s#hash',
-                            'http://somelink.com/%s?param=1&param=2',
-                            'http://somelink.com/%s',
-                            'ftp://somelink.com/%s',
-                            'https://somelink.com/%s',
-                            'https://somelink.com/sub/sub/%s',
-                            'http://cdn.somecdn.net/v/%s',
-                            'somelink.com/%s',
-                            '%s'
-                        ];
-                        return $.map(links, function(link) {
-                            return _str.sprintf(link, videoName);
-                        });
-                    }(longFileName));
-
-                $.each(html5LongUrls, function(index, link) {
-                    it(link, function() {
-                        var result = Utils.parseHTML5Link(link);
-                        expect(result.video.length).toBe(150);
-                    });
-                });
-            });
         });
 
         it('Method: getYoutubeLink', function() {

cms/static/js/views/video/transcripts/utils.js

@@ -110,7 +110,6 @@ define(['jquery', 'underscore', 'jquery.ajaxQueue'], function($) {
      */
         var _videoLinkParser = (function() {
             var cache = {};
-            var maxVideoNameLength = 150;
 
             return function(url) {
                 if (typeof url !== 'string') {
@@ -130,10 +129,7 @@ define(['jquery', 'underscore', 'jquery.ajaxQueue'], function($) {
                 match = link.pathname.match(/\/{1}([^\/]+)\.([^\/]+)$/);
                 if (match) {
                     cache[url] = {
-                        /* avoid too long video name, as it will be used as filename for video's transcript
-                        and a filename can not be more that 255 chars, limiting here to 150.
-                        */
-                        video: match[1].slice(0, maxVideoNameLength),
+                        video: match[1],
                         type: match[2]
                     };
                 } else {
@@ -143,7 +139,7 @@ define(['jquery', 'underscore', 'jquery.ajaxQueue'], function($) {
                     match = link.pathname.match(/\/{1}([^\/\.]+)$/);
                     if (match) {
                         cache[url] = {
-                            video: match[1].slice(0, maxVideoNameLength),
+                            video: match[1],
                             type: 'other'
                         };
                     }

common/lib/xmodule/xmodule/video_module/transcripts_utils.py

@@ -296,11 +296,9 @@ def copy_or_rename_transcript(new_name, old_name, item, delete_old=False, user=N
 def get_html5_ids(html5_sources):
     """
     Helper method to parse out an HTML5 source into the ideas
-    NOTE: This assumes that '/' are not in the filename.
-    Slices each id by 150, restricting too long strings as video names.
+    NOTE: This assumes that '/' are not in the filename
     """
-    html5_ids = [x.split('/')[-1].rsplit('.', 1)[0][:150] for x in html5_sources]
-
+    html5_ids = [x.split('/')[-1].rsplit('.', 1)[0] for x in html5_sources]
     return html5_ids