Commit b8c248fd by Victor Shnayder Committed by Matthew Mongeau

minor edits to address Calen's comments.

parent 4590f976
...@@ -367,7 +367,8 @@ class Module(XModule): ...@@ -367,7 +367,8 @@ class Module(XModule):
answers = dict() answers = dict()
for key in get: for key in get:
# e.g. input_resistor_1 ==> resistor_1 # e.g. input_resistor_1 ==> resistor_1
answers['_'.join(key.split('_')[1:])] = get[key] _, _, name = key.partition('_')
answers[name] = get[key]
return answers return answers
...@@ -390,7 +391,7 @@ class Module(XModule): ...@@ -390,7 +391,7 @@ class Module(XModule):
if self.closed(): if self.closed():
event_info['failure'] = 'closed' event_info['failure'] = 'closed'
self.tracker('save_problem_check_fail', event_info) self.tracker('save_problem_check_fail', event_info)
# TODO: probably not 404? # TODO (vshnayder): probably not 404?
raise self.system.exception404 raise self.system.exception404
# Problem submitted. Student should reset before checking # Problem submitted. Student should reset before checking
...@@ -405,7 +406,7 @@ class Module(XModule): ...@@ -405,7 +406,7 @@ class Module(XModule):
lcp_id = self.lcp.problem_id lcp_id = self.lcp.problem_id
correct_map = self.lcp.grade_answers(answers) correct_map = self.lcp.grade_answers(answers)
except StudentInputError as inst: except StudentInputError as inst:
# TODO: why is this line here? # TODO (vshnayder): why is this line here?
self.lcp = LoncapaProblem(self.filestore.open(self.filename), self.lcp = LoncapaProblem(self.filestore.open(self.filename),
id=lcp_id, state=old_state, system=self.system) id=lcp_id, state=old_state, system=self.system)
traceback.print_exc() traceback.print_exc()
...@@ -436,7 +437,7 @@ class Module(XModule): ...@@ -436,7 +437,7 @@ class Module(XModule):
html = self.get_problem_html(encapsulate=False) # render problem into HTML html = self.get_problem_html(encapsulate=False) # render problem into HTML
except Exception,err: except Exception,err:
log.error('failed to generate html') log.error('failed to generate html')
raise Exception, err raise
return {'success': success, return {'success': success,
'contents': html, 'contents': html,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment