Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
a96acd2f
Commit
a96acd2f
authored
Apr 01, 2015
by
Ahsan Ulhaq
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
iframe elements require a meaningful title attribute
TNL-1675
parent
ec2f4dc2
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
3 deletions
+4
-3
cms/djangoapps/models/settings/course_details.py
+1
-1
cms/templates/settings.html
+1
-1
lms/templates/index.html
+1
-1
lms/templates/lti.html
+1
-0
No files found.
cms/djangoapps/models/settings/course_details.py
View file @
a96acd2f
...
...
@@ -215,7 +215,7 @@ class CourseDetails(object):
# the right thing
result
=
None
if
video_key
:
result
=
'<iframe width="560" height="315" src="//www.youtube.com/embed/'
+
\
result
=
'<iframe
title="YouTube Video"
width="560" height="315" src="//www.youtube.com/embed/'
+
\
video_key
+
'?rel=0" frameborder="0" allowfullscreen=""></iframe>'
return
result
...
...
cms/templates/settings.html
View file @
a96acd2f
...
...
@@ -263,7 +263,7 @@ CMS.URL.UPLOAD_ASSET = '${upload_asset_url}';
<label
for=
"course-overview"
>
${_("Course Introduction Video")}
</label>
<div
class=
"input input-existing"
>
<div
class=
"current current-course-introduction-video"
>
<iframe
width=
"618"
height=
"350"
src=
""
frameborder=
"0"
allowfullscreen
></iframe>
<iframe
width=
"618"
height=
"350"
title=
"Course Introduction Video"
src=
""
frameborder=
"0"
allowfullscreen
></iframe>
</div>
<div
class=
"actions"
>
<a
href=
"#"
class=
"remove-item remove-course-introduction-video remove-video-data"
><span
class=
"delete-icon"
></span>
${_("Delete Current Video")}
</a>
...
...
lms/templates/index.html
View file @
a96acd2f
...
...
@@ -74,7 +74,7 @@
if
self
.
stanford_theme_enabled
()
:
youtube_video_id =
"2gmreZObCY4"
%
>
<iframe
width=
"640"
height=
"360"
src=
"//www.youtube.com/embed/${youtube_video_id}?showinfo=0"
frameborder=
"0"
allowfullscreen
></iframe>
<iframe
title=
"YouTube Video"
width=
"640"
height=
"360"
src=
"//www.youtube.com/embed/${youtube_video_id}?showinfo=0"
frameborder=
"0"
allowfullscreen
></iframe>
</div>
</section>
...
...
lms/templates/lti.html
View file @
a96acd2f
...
...
@@ -39,6 +39,7 @@
% else:
## The result of the form submit will be rendered here.
<iframe
title=
"Form Result"
class=
"ltiLaunchFrame"
name=
"ltiFrame-${element_id}"
src=
"${form_url}"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment