Commit a5f107bc by Zia Fazal Committed by Jonathan Piacenti

ziafazal/api-remove-rounding: remove round in progress

avoid auto round by casting denominator to float
parent a7a8e196
...@@ -48,7 +48,7 @@ class CourseCompletionsLeadersSerializer(serializers.Serializer): ...@@ -48,7 +48,7 @@ class CourseCompletionsLeadersSerializer(serializers.Serializer):
completions = obj['completions'] or 0 completions = obj['completions'] or 0
completion_percentage = 0 completion_percentage = 0
if total_completions > 0: if total_completions > 0:
completion_percentage = int(round(100 * completions / total_completions)) completion_percentage = 100 * completions / float(total_completions)
return completion_percentage return completion_percentage
......
...@@ -1631,13 +1631,13 @@ class CoursesMetricsCompletionsLeadersList(SecureAPIView): ...@@ -1631,13 +1631,13 @@ class CoursesMetricsCompletionsLeadersList(SecureAPIView):
data['position'] = completions_above_user + 1 data['position'] = completions_above_user + 1
completion_percentage = 0 completion_percentage = 0
if total_possible_completions > 0: if total_possible_completions > 0:
completion_percentage = int(round(100 * user_completions/total_possible_completions)) completion_percentage = 100 * user_completions/total_possible_completions
data['completions'] = completion_percentage data['completions'] = completion_percentage
total_users = CourseEnrollment.users_enrolled_in(course_key).exclude(id__in=exclude_users).count() total_users = CourseEnrollment.users_enrolled_in(course_key).exclude(id__in=exclude_users).count()
if total_users and total_actual_completions: if total_users and total_actual_completions:
course_avg = round(total_actual_completions / float(total_users), 1) course_avg = total_actual_completions / float(total_users)
course_avg = int(round(100 * course_avg / total_possible_completions)) # avg in percentage course_avg = 100 * course_avg / total_possible_completions # avg in percentage
data['course_avg'] = course_avg data['course_avg'] = course_avg
if not skipleaders: if not skipleaders:
queryset = queryset.filter(user__is_active=True).values('user__id', 'user__username', queryset = queryset.filter(user__is_active=True).values('user__id', 'user__username',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment