Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
a35a6b73
Commit
a35a6b73
authored
Jul 28, 2016
by
Christina Roberts
Committed by
GitHub
Jul 28, 2016
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #13116 from edx/christina/remove-extra-save
There is no need to call save after add/remove.
parents
194c5096
c195e7eb
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
3 deletions
+0
-3
openedx/core/djangoapps/course_groups/models.py
+0
-3
No files found.
openedx/core/djangoapps/course_groups/models.py
View file @
a35a6b73
...
@@ -95,7 +95,6 @@ class CohortMembership(models.Model):
...
@@ -95,7 +95,6 @@ class CohortMembership(models.Model):
if
'force_insert'
in
kwargs
and
kwargs
[
'force_insert'
]
is
True
:
if
'force_insert'
in
kwargs
and
kwargs
[
'force_insert'
]
is
True
:
with
transaction
.
atomic
():
with
transaction
.
atomic
():
self
.
course_user_group
.
users
.
add
(
self
.
user
)
self
.
course_user_group
.
users
.
add
(
self
.
user
)
self
.
course_user_group
.
save
()
super
(
CohortMembership
,
self
)
.
save
(
*
args
,
**
kwargs
)
super
(
CohortMembership
,
self
)
.
save
(
*
args
,
**
kwargs
)
return
return
...
@@ -127,11 +126,9 @@ class CohortMembership(models.Model):
...
@@ -127,11 +126,9 @@ class CohortMembership(models.Model):
self
.
previous_cohort_name
=
saved_membership
.
course_user_group
.
name
self
.
previous_cohort_name
=
saved_membership
.
course_user_group
.
name
self
.
previous_cohort_id
=
saved_membership
.
course_user_group
.
id
self
.
previous_cohort_id
=
saved_membership
.
course_user_group
.
id
self
.
previous_cohort
.
users
.
remove
(
self
.
user
)
self
.
previous_cohort
.
users
.
remove
(
self
.
user
)
self
.
previous_cohort
.
save
()
saved_membership
.
course_user_group
=
self
.
course_user_group
saved_membership
.
course_user_group
=
self
.
course_user_group
self
.
course_user_group
.
users
.
add
(
self
.
user
)
self
.
course_user_group
.
users
.
add
(
self
.
user
)
self
.
course_user_group
.
save
()
super
(
CohortMembership
,
saved_membership
)
.
save
(
update_fields
=
[
'course_user_group'
])
super
(
CohortMembership
,
saved_membership
)
.
save
(
update_fields
=
[
'course_user_group'
])
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment