Commit 9fc190dd by Waheed Ahmed

Merge pull request #3445 from edx/waheed/stud1514-toggle-cheatsheet-not-working

Added code to remove css on closing cheatsheet.
parents dead7801 49ef8c56
...@@ -135,6 +135,12 @@ define(["jquery", "underscore", "gettext", "js/views/modals/base_modal", ...@@ -135,6 +135,12 @@ define(["jquery", "underscore", "gettext", "js/views/modals/base_modal",
var parent = $(event.target.parentElement), var parent = $(event.target.parentElement),
mode = parent.data('mode'); mode = parent.data('mode');
event.preventDefault(); event.preventDefault();
var $cheatsheet = $('.simple-editor-cheatsheet');
if ($cheatsheet.hasClass("shown")) {
$(".CodeMirror").removeAttr("style");
$(".modal-content").removeAttr("style");
$cheatsheet.removeClass('shown');
}
this.selectMode(mode); this.selectMode(mode);
}, },
......
...@@ -48,6 +48,7 @@ class @MarkdownEditingDescriptor extends XModule.Descriptor ...@@ -48,6 +48,7 @@ class @MarkdownEditingDescriptor extends XModule.Descriptor
### ###
onShowXMLButton: (e) => onShowXMLButton: (e) =>
e.preventDefault(); e.preventDefault();
@addRemoveCheatsheetCSS()
if @confirmConversionToXml() if @confirmConversionToXml()
@createXMLEditor(MarkdownEditingDescriptor.markdownToXml(@markdown_editor.getValue())) @createXMLEditor(MarkdownEditingDescriptor.markdownToXml(@markdown_editor.getValue()))
# Need to refresh to get line numbers to display properly (and put cursor position to 0) # Need to refresh to get line numbers to display properly (and put cursor position to 0)
...@@ -94,11 +95,22 @@ class @MarkdownEditingDescriptor extends XModule.Descriptor ...@@ -94,11 +95,22 @@ class @MarkdownEditingDescriptor extends XModule.Descriptor
@cheatsheet = $($('#simple-editor-cheatsheet').html()) @cheatsheet = $($('#simple-editor-cheatsheet').html())
$(@markdown_editor.getWrapperElement()).append(@cheatsheet) $(@markdown_editor.getWrapperElement()).append(@cheatsheet)
$(".CodeMirror").css({"overflow": "visible"}) @addRemoveCheatsheetCSS()
$(".modal-content").css({"overflow-y": "visible", "overflow-x": "visible"})
setTimeout (=> @cheatsheet.toggleClass('shown')), 10 setTimeout (=> @cheatsheet.toggleClass('shown')), 10
###
Function to add/remove CSS for cheatsheet.
###
addRemoveCheatsheetCSS: () =>
if !@cheatsheet.hasClass("shown")
$(".CodeMirror").css({"overflow": "visible"})
$(".modal-content").css({"overflow-y": "visible", "overflow-x": "visible"})
else
$(".CodeMirror").removeAttr("style")
$(".modal-content").removeAttr("style")
### ###
Stores the current editor and hides the one that is not displayed. Stores the current editor and hides the one that is not displayed.
### ###
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment