Commit 9ec38176 by Bridger Maxwell

Small cleanup tweaks in grading.

parent 9ce3b83b
...@@ -35,7 +35,6 @@ def yield_dynamic_descriptor_descendents(descriptor, module_creator): ...@@ -35,7 +35,6 @@ def yield_dynamic_descriptor_descendents(descriptor, module_creator):
""" """
def get_dynamic_descriptor_children(descriptor): def get_dynamic_descriptor_children(descriptor):
if descriptor.has_dynamic_children(): if descriptor.has_dynamic_children():
print "descriptor has dynamic children" , descriptor.location
module = module_creator(descriptor) module = module_creator(descriptor)
child_locations = module.get_children_locations() child_locations = module.get_children_locations()
return [descriptor.system.load_item(child_location) for child_location in child_locations ] return [descriptor.system.load_item(child_location) for child_location in child_locations ]
...@@ -238,7 +237,7 @@ def grade_for_percentage(grade_cutoffs, percentage): ...@@ -238,7 +237,7 @@ def grade_for_percentage(grade_cutoffs, percentage):
# TODO: This method is not very good. It was written in the old course style and # TODO: This method is not very good. It was written in the old course style and
# then converted over and performance is not good. Once the progress page is redesigned # then converted over and performance is not good. Once the progress page is redesigned
# to not have the progress summary this method should be deleted (so it won't be copied). # to not have the progress summary this method should be deleted (so it won't be copied).
def progress_summary(student, request, course, grader, student_module_cache): def progress_summary(student, request, course, student_module_cache):
""" """
This pulls a summary of all problems in the course. This pulls a summary of all problems in the course.
......
...@@ -22,7 +22,7 @@ from django.views.decorators.cache import cache_control ...@@ -22,7 +22,7 @@ from django.views.decorators.cache import cache_control
from courseware import grades from courseware import grades
from courseware.access import has_access from courseware.access import has_access
from courseware.courses import (get_course_with_access, get_courses_by_university) from courseware.courses import (get_course_with_access, get_courses_by_university)
from models import StudentModuleCache from courseware.models import StudentModuleCache
from module_render import toc_for_course, get_module, get_instance_module from module_render import toc_for_course, get_module, get_instance_module
from student.models import UserProfile from student.models import UserProfile
...@@ -457,7 +457,7 @@ def progress(request, course_id, student_id=None): ...@@ -457,7 +457,7 @@ def progress(request, course_id, student_id=None):
course_id, student, course) course_id, student, course)
courseware_summary = grades.progress_summary(student, request, course, courseware_summary = grades.progress_summary(student, request, course,
course.grader, student_module_cache) student_module_cache)
grade_summary = grades.grade(student, request, course, student_module_cache) grade_summary = grades.grade(student, request, course, student_module_cache)
if courseware_summary is None: if courseware_summary is None:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment