Commit 9d284d2f by louyihua

Fix quotation mark & apostrophe related i18n bug

Just done by using the escapejs function :)
parent fba7bb91
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
<%! <%!
from django.utils.translation import ugettext as _ from django.utils.translation import ugettext as _
from contentstore import utils from contentstore import utils
from django.utils.html import escapejs
%> %>
<%block name="title">${_("Advanced Settings")}</%block> <%block name="title">${_("Advanced Settings")}</%block>
<%block name="bodyclass">is-signedin course advanced view-settings</%block> <%block name="bodyclass">is-signedin course advanced view-settings</%block>
...@@ -40,12 +41,12 @@ require(["domReady!", "jquery", "gettext", "js/models/settings/advanced", "js/vi ...@@ -40,12 +41,12 @@ require(["domReady!", "jquery", "gettext", "js/models/settings/advanced", "js/vi
var deprecatedSettingsLabel = $('.deprecated-settings-label'); var deprecatedSettingsLabel = $('.deprecated-settings-label');
if ($this.is(':checked')) { if ($this.is(':checked')) {
wrapperDeprecatedSetting.addClass('is-set'); wrapperDeprecatedSetting.addClass('is-set');
deprecatedSettingsLabel.text('${_('Hide Deprecated Settings') | h}'); deprecatedSettingsLabel.text('${escapejs(_('Hide Deprecated Settings'))}');
editor.render_deprecated = true; editor.render_deprecated = true;
} }
else { else {
wrapperDeprecatedSetting.removeClass('is-set'); wrapperDeprecatedSetting.removeClass('is-set');
deprecatedSettingsLabel.text('${_('Show Deprecated Settings') | h}'); deprecatedSettingsLabel.text('${escapejs(_('Show Deprecated Settings'))}');
editor.render_deprecated = false; editor.render_deprecated = false;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment