Unverified Commit 98b391a2 by AlasdairSwan Committed by GitHub

Merge pull request #16805 from…

Merge pull request #16805 from edx/alasdair/LEARNER-3128-sequence-list-role-presentation-a11y-update

LEARNER-3128 add role=presentation to sequence nav list items
parents 8b59c6d5 acab64be
...@@ -11,14 +11,14 @@ ...@@ -11,14 +11,14 @@
</button> </button>
<nav class="sequence-list-wrapper" aria-label="Unit"> <nav class="sequence-list-wrapper" aria-label="Unit">
<ol id="sequence-list" role="tablist"> <ol id="sequence-list" role="tablist">
<li> <li role="presentation">
<button role="tab" tabindex="0" aria-selected="true" aria-expanded="true" aria-controls="seq_content" class="seq_problem nav-item tab active" data-index="0" data-id="block-v1:edX+DemoX+Demo_Course+type@vertical+block@fb79dcbad35b466a8c6364f8ffee9050" data-element="1" data-page-title="Unit 101" data-path="Example Week 2: Get Interactive > Homework - Part 1 > Unit 101" id="tab_0"> <button role="tab" tabindex="0" aria-selected="true" aria-expanded="true" aria-controls="seq_content" class="seq_problem nav-item tab active" data-index="0" data-id="block-v1:edX+DemoX+Demo_Course+type@vertical+block@fb79dcbad35b466a8c6364f8ffee9050" data-element="1" data-page-title="Unit 101" data-path="Example Week 2: Get Interactive > Homework - Part 1 > Unit 101" id="tab_0">
<span class="icon fa seq_problem" aria-hidden="true"></span> <span class="icon fa seq_problem" aria-hidden="true"></span>
<span class="fa fa-fw fa-bookmark bookmark-icon is-hidden" aria-hidden="true"></span> <span class="fa fa-fw fa-bookmark bookmark-icon is-hidden" aria-hidden="true"></span>
<div class="sequence-tooltip sr"><span class="sr">problem</span>Unit 101<span class="sr bookmark-icon-sr"></span></div> <div class="sequence-tooltip sr"><span class="sr">problem</span>Unit 101<span class="sr bookmark-icon-sr"></span></div>
</button> </button>
</li> </li>
<li> <li role="presentation">
<button role="tab" tabindex="-1" aria-selected="true" aria-expanded="true" aria-controls="seq_content" class="seq_problem inactive nav-item tab" data-index="1" data-id="block-v1:edX+DemoX+Demo_Course+type@vertical+block@fb79dcbad35b466a8c6364f8ffee9051" data-element="2" data-page-title="Unit 102" data-path="Example Week 2: Get Interactive > Homework - Part 1 > Unit 102" id="tab_1"> <button role="tab" tabindex="-1" aria-selected="true" aria-expanded="true" aria-controls="seq_content" class="seq_problem inactive nav-item tab" data-index="1" data-id="block-v1:edX+DemoX+Demo_Course+type@vertical+block@fb79dcbad35b466a8c6364f8ffee9051" data-element="2" data-page-title="Unit 102" data-path="Example Week 2: Get Interactive > Homework - Part 1 > Unit 102" id="tab_1">
<span class="icon fa seq_problem" aria-hidden="true"></span> <span class="icon fa seq_problem" aria-hidden="true"></span>
<span class="fa fa-fw fa-bookmark bookmark-icon is-hidden" aria-hidden="true"></span> <span class="fa fa-fw fa-bookmark bookmark-icon is-hidden" aria-hidden="true"></span>
......
...@@ -24,8 +24,8 @@ ...@@ -24,8 +24,8 @@
<nav class="sequence-list-wrapper" aria-label="${_('Sequence')}"> <nav class="sequence-list-wrapper" aria-label="${_('Sequence')}">
<ol id="sequence-list" role="tablist"> <ol id="sequence-list" role="tablist">
% for idx, item in enumerate(items): % for idx, item in enumerate(items):
<li> <li role="presentation">
<button class="seq_${item['type']} inactive nav-item tab" <button class="seq_${item['type']} inactive nav-item tab"
role="tab" role="tab"
tabindex="-1" tabindex="-1"
aria-selected="false" aria-selected="false"
......
...@@ -43,7 +43,7 @@ ...@@ -43,7 +43,7 @@
</button> </button>
<nav class="sequence-list-wrapper" aria-label="Sequence"> <nav class="sequence-list-wrapper" aria-label="Sequence">
<ol id="sequence-list" role="tablist"> <ol id="sequence-list" role="tablist">
<li> <li role="presentation">
<button class="seq_video nav-item tab active" role="tab" tabindex="0" aria-selected="true" aria-expanded="true" aria-controls="seq_content" data-index="0" data-id="block-v1:edX+DemoX+Demo_Course+type@vertical+block@vertical_0270f6de40fc" data-element="1" data-page-title="Introduction: Video and Sequences" data-path="Introduction > Demo Course Overview > Introduction: Video and Sequences" id="tab_0"> <button class="seq_video nav-item tab active" role="tab" tabindex="0" aria-selected="true" aria-expanded="true" aria-controls="seq_content" data-index="0" data-id="block-v1:edX+DemoX+Demo_Course+type@vertical+block@vertical_0270f6de40fc" data-element="1" data-page-title="Introduction: Video and Sequences" data-path="Introduction > Demo Course Overview > Introduction: Video and Sequences" id="tab_0">
<span class="icon fa seq_video" aria-hidden="true"></span> <span class="icon fa seq_video" aria-hidden="true"></span>
<span class="fa fa-fw fa-bookmark bookmark-icon is-hidden" aria-hidden="true"></span> <span class="fa fa-fw fa-bookmark bookmark-icon is-hidden" aria-hidden="true"></span>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment