Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
93ba637e
Commit
93ba637e
authored
Jun 03, 2016
by
Renzo Lucioni
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #12638 from edx/renzo/fix-failing-a11y
Fix program details a11y test
parents
90286cd9
9c4a3dc9
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
8 deletions
+5
-8
common/test/acceptance/tests/lms/test_programs.py
+0
-3
lms/static/js/spec/learner_dashboard/course_card_view_spec.js
+2
-2
lms/templates/learner_dashboard/course_card.underscore
+2
-2
lms/templates/learner_dashboard/program_header_view.underscore
+1
-1
No files found.
common/test/acceptance/tests/lms/test_programs.py
View file @
93ba637e
"""Acceptance tests for LMS-hosted Programs pages"""
from
unittest
import
skip
from
nose.plugins.attrib
import
attr
from
...fixtures.programs
import
ProgramsFixture
,
ProgramsConfigMixin
...
...
@@ -139,7 +137,6 @@ class ProgramListingPageA11yTest(ProgramPageBase):
@attr
(
'a11y'
)
@skip
(
'The tested page is currently disabled. This test will be re-enabled once a11y failures are resolved.'
)
class
ProgramDetailsPageA11yTest
(
ProgramPageBase
):
"""Test program details page accessibility."""
def
setUp
(
self
):
...
...
lms/static/js/spec/learner_dashboard/course_card_view_spec.js
View file @
93ba637e
...
...
@@ -61,7 +61,7 @@ define([
expect
(
view
.
$
(
'.header-img'
).
attr
(
'src'
)).
toEqual
(
context
.
run_modes
[
0
].
course_image_url
);
expect
(
view
.
$
(
'.course-details .course-title-link'
).
text
().
trim
()).
toEqual
(
context
.
display_name
);
expect
(
view
.
$
(
'.course-details .course-title-link'
).
attr
(
'href'
)).
toEqual
(
context
.
run_modes
[
0
].
marketing
_url
);
context
.
run_modes
[
0
].
course
_url
);
expect
(
view
.
$
(
'.course-details .course-text .course-key'
).
html
()).
toEqual
(
context
.
key
);
expect
(
view
.
$
(
'.course-details .course-text .run-period'
).
html
())
.
toEqual
(
context
.
run_modes
[
0
].
start_date
+
' - '
+
context
.
run_modes
[
0
].
end_date
);
...
...
@@ -71,7 +71,7 @@ define([
expect
(
view
.
$
(
'.header-img'
).
attr
(
'src'
)).
toEqual
(
context
.
run_modes
[
0
].
course_image_url
);
expect
(
view
.
$
(
'.course-details .course-title-link'
).
text
().
trim
()).
toEqual
(
context
.
display_name
);
expect
(
view
.
$
(
'.course-details .course-title-link'
).
attr
(
'href'
)).
toEqual
(
context
.
run_modes
[
0
].
marketing
_url
);
context
.
run_modes
[
0
].
course
_url
);
expect
(
view
.
$
(
'.course-details .course-text .course-key'
).
html
()).
toEqual
(
context
.
key
);
expect
(
view
.
$
(
'.course-details .course-text .run-period'
).
html
()).
not
.
toBeDefined
();
});
...
...
lms/templates/learner_dashboard/course_card.underscore
View file @
93ba637e
<div class="grid-container grid-manual">
<div class="course-meta-container col-12 md-col-8 sm-col-12">
<a href="<%-
marketing
_url %>" class="course-image-link">
<a href="<%-
course
_url %>" class="course-image-link">
<img
class="header-img"
src="<%- course_image_url %>"
...
...
@@ -8,7 +8,7 @@
</a>
<div class="course-details">
<h3 class="course-title">
<a href="<%-
marketing
_url %>" class="course-title-link">
<a href="<%-
course
_url %>" class="course-title-link">
<%- display_name %>
</a>
</h3>
...
...
lms/templates/learner_dashboard/program_header_view.underscore
View file @
93ba637e
...
...
@@ -5,7 +5,7 @@
</picture>
<h2 class="hd-2 title"><%- name %></h2>
<p class="subtitle"><%- subtitle %></p>
<a href="" class="breadcrumb"><%- gettext('Programs') %></a>
<a href="
/dashboard/programs
" class="breadcrumb"><%- gettext('Programs') %></a>
<span><%- StringUtils.interpolate(
gettext('{category}\'s program'),
{category: category}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment