Merge pull request #12250 from edx/bjacobel/underscore.string-removal-v2

remove usage of minifed Underscore.string

common/static/karma_common.conf.js

@@ -38,7 +38,7 @@ var libraryFiles = [
     {pattern: 'js/vendor/jquery.truncate.js', included: true},
     {pattern: 'js/vendor/mustache.js', included: true},
     {pattern: 'common/js/vendor/underscore.js', included: true},
-    {pattern: 'js/vendor/underscore.string.min.js', included: true},
+    {pattern: 'common/js/vendor/underscore.string.js', included: true},
     {pattern: 'js/vendor/backbone-min.js', included: true},
     {pattern: 'js/vendor/jquery.timeago.js', included: true},
     {pattern: 'js/vendor/URI.min.js', included: true},

common/static/karma_common_requirejs.conf.js

@@ -36,7 +36,7 @@ var libraryFiles = [
     {pattern: 'js/vendor/jquery.simulate.js', included: false},
     {pattern: 'js/vendor/jquery.truncate.js', included: false},
     {pattern: 'common/js/vendor/underscore.js', included: false},
-    {pattern: 'js/vendor/underscore.string.min.js', included: false},
+    {pattern: 'common/js/vendor/underscore.string.js', included: false},
     {pattern: 'js/vendor/backbone-min.js', included: false},
     {pattern: 'js/vendor/backbone.paginator.min.js', included: false},
     {pattern: 'js/vendor/jquery.timeago.js', included: false},

lms/envs/common.py

@@ -1257,7 +1257,6 @@ base_vendor_js = [
     'js/vendor/url.min.js',
     'common/js/vendor/underscore.js',
     'common/js/vendor/underscore.string.js',
-    'js/vendor/underscore.string.min.js',
     'common/js/vendor/picturefill.min.js',
 
     # Make some edX UI Toolkit utilities available in the global "edx" namespace

lms/static/karma_lms.conf.js

@@ -60,7 +60,7 @@ var libraryFiles = [
     {pattern: 'xmodule_js/src/xmodule.js', included: false},
     {pattern: 'xmodule_js/common_static/js/src/**/*.js', included: false},
     {pattern: 'xmodule_js/common_static/common/js/vendor/underscore.js', included: false},
-    {pattern: 'xmodule_js/common_static/js/vendor/underscore.string.min.js', included: false},
+    {pattern: 'xmodule_js/common_static/common/js/vendor/underscore.string.js', included: false},
     {pattern: 'xmodule_js/common_static/js/vendor/backbone-min.js', included: false},
     {pattern: 'xmodule_js/common_static/js/vendor/backbone.paginator.min.js', included: false},
     {pattern: 'xmodule_js/common_static/js/vendor/edxnotes/annotator-full.min.js', included: false},
@@ -151,4 +151,3 @@ module.exports = function (config) {
 
     config.set(_.extend(commonConfig, localConfig));
 };
-